All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keno Fischer <keno@juliacomputing.com>
To: qemu-devel@nongnu.org
Cc: Keno Fischer <keno@juliacomputing.com>, groug@kaod.org
Subject: [Qemu-devel] [PATCH v3 05/13] 9p: darwin: Explicitly cast comparisons of mode_t with -1
Date: Sat, 16 Jun 2018 20:56:49 -0400	[thread overview]
Message-ID: <08ebbb93dbfc29bbb727c05a16cd5ded6dec42b3.1529196703.git.keno@juliacomputing.com> (raw)
In-Reply-To: <cover.1529196703.git.keno@juliacomputing.com>
In-Reply-To: <cover.1529196703.git.keno@juliacomputing.com>

Comparisons of mode_t with -1 require an explicit cast, since mode_t
is unsigned on Darwin.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
---
 hw/9pfs/9p-local.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
index d713983..98d4073 100644
--- a/hw/9pfs/9p-local.c
+++ b/hw/9pfs/9p-local.c
@@ -310,7 +310,7 @@ update_map_file:
     if (credp->fc_gid != -1) {
         gid = credp->fc_gid;
     }
-    if (credp->fc_mode != -1) {
+    if (credp->fc_mode != (mode_t)-1) {
         mode = credp->fc_mode;
     }
     if (credp->fc_rdev != -1) {
@@ -416,7 +416,7 @@ static int local_set_xattrat(int dirfd, const char *path, FsCred *credp)
             return err;
         }
     }
-    if (credp->fc_mode != -1) {
+    if (credp->fc_mode != (mode_t)-1) {
         uint32_t tmp_mode = cpu_to_le32(credp->fc_mode);
         err = fsetxattrat_nofollow(dirfd, path, "user.virtfs.mode", &tmp_mode,
                                    sizeof(mode_t), 0);
-- 
2.8.1

  parent reply	other threads:[~2018-06-17  0:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-17  0:56 [Qemu-devel] [PATCH v3 00/13] 9p: Add support for Darwin Keno Fischer
2018-06-17  0:56 ` [Qemu-devel] [PATCH v3 01/13] 9p: linux: Fix a couple Linux assumptions Keno Fischer
2018-06-25 14:27   ` Greg Kurz
2018-06-17  0:56 ` [Qemu-devel] [PATCH v3 02/13] 9p: Rename 9p-util -> 9p-util-linux Keno Fischer
2018-06-25 15:17   ` Greg Kurz
2018-06-17  0:56 ` [Qemu-devel] [PATCH v3 03/13] 9p: darwin: Handle struct stat(fs) differences Keno Fischer
2018-06-25 13:14   ` Greg Kurz
2018-06-17  0:56 ` [Qemu-devel] [PATCH v3 04/13] 9p: darwin: Handle struct dirent differences Keno Fischer
2018-06-25 13:24   ` Greg Kurz
2018-06-17  0:56 ` Keno Fischer [this message]
2018-06-25 15:18   ` [Qemu-devel] [PATCH v3 05/13] 9p: darwin: Explicitly cast comparisons of mode_t with -1 Greg Kurz
2018-06-17  0:56 ` [Qemu-devel] [PATCH v3 06/13] 9p: darwin: Ignore O_{NOATIME, DIRECT} Keno Fischer
2018-06-26  9:15   ` Greg Kurz
2018-06-17  0:56 ` [Qemu-devel] [PATCH v3 07/13] 9p: darwin: Provide a compatibility definition for XATTR_SIZE_MAX Keno Fischer
2018-06-26 10:15   ` Greg Kurz
2018-06-17  0:56 ` [Qemu-devel] [PATCH v3 08/13] 9p: darwin: *xattr_nofollow implementations Keno Fischer
2018-06-26 11:09   ` Greg Kurz
2018-06-17  0:56 ` [Qemu-devel] [PATCH v3 09/13] 9p: darwin: Compatibility for f/l*xattr Keno Fischer
2018-06-26 13:57   ` Greg Kurz
2018-06-17  0:56 ` [Qemu-devel] [PATCH v3 10/13] 9p: darwin: Provide a fallback implementation for utimensat Keno Fischer
2018-06-17  0:56 ` [Qemu-devel] [PATCH v3 11/13] 9p: darwin: Implement compatibility for mknodat Keno Fischer
2018-06-17  0:56 ` [Qemu-devel] [PATCH v3 12/13] 9p: darwin: virtfs-proxy: Implement setuid code for darwin Keno Fischer
2018-06-17  0:56 ` [Qemu-devel] [PATCH v3 13/13] 9p: darwin: configure: Allow VirtFS on Darwin Keno Fischer
2018-06-17  2:13 ` [Qemu-devel] [PATCH v3 00/13] 9p: Add support for Darwin no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08ebbb93dbfc29bbb727c05a16cd5ded6dec42b3.1529196703.git.keno@juliacomputing.com \
    --to=keno@juliacomputing.com \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.