From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"pannengyuan@huawei.com" <pannengyuan@huawei.com>,
"kwolf@redhat.com" <kwolf@redhat.com>,
"mreitz@redhat.com" <mreitz@redhat.com>,
"sgarzare@redhat.com" <sgarzare@redhat.com>
Cc: "liyiting@huawei.com" <liyiting@huawei.com>,
"zhang.zhanghailiang@huawei.com" <zhang.zhanghailiang@huawei.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
qemu-stable <qemu-stable@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kuhn.chenqun@huawei.com" <kuhn.chenqun@huawei.com>
Subject: Re: for 4.2 ??? Re: [PATCH V3 2/2] block/nbd: fix memory leak in nbd_open()
Date: Tue, 3 Dec 2019 12:54:58 -0600 [thread overview]
Message-ID: <08f0d51d-f352-5d64-26a4-9a741a4cf2e0@redhat.com> (raw)
In-Reply-To: <1cff97de-303b-3b27-f737-3f69759746b0@virtuozzo.com>
On 12/3/19 11:52 AM, Vladimir Sementsov-Ogievskiy wrote:
> It's just a memory leak, but it's a regression in 4.2.
>
> Should we take it into 4.2?
Sorry, I was on holiday and then jury service, so I missed any chance at
getting this into -rc3. The memory leak only happens on failure, and
you'd have to be pretty desperate to purposefully attempt to open a lot
of NBD devices where you know you'll get a failure just to trigger
enough of a leak to cause the OOM-killer to target qemu. So I'm fine if
this is deferred to 5.0, and just cc's qemu-stable (now done).
I'll queue this through my NBD tree for 5.0.
>
>
> 29.11.2019 10:25, pannengyuan@huawei.com wrote:
>> From: PanNengyuan <pannengyuan@huawei.com>
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: PanNengyuan <pannengyuan@huawei.com>
I'm not one to tell you that your name is written incorrectly, but it
does look odd to have a single word rather than a space between two
capitalized portions. If that's really how you want your S-o-b and
authorship to appear, I'm happy to preserve it; but you may want to
consider updating your git settings, and posting a v4 with an updated
spelling if you would prefer something different. (It is also
acceptable to use UTF-8 characters; some people like listing an S-o-b in
both native characters and a Westernized variant).
>
> May add:
>
> Fixes: 8f071c9db506e03ab
Yes, information like that helps in deciding how long the problem has
been present (in this case, it is indeed a regression added in 4.2, even
if minor in nature).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-12-03 20:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 7:25 [PATCH V3 1/2] block/nbd: extract the common cleanup code pannengyuan
2019-11-29 7:25 ` [PATCH V3 2/2] block/nbd: fix memory leak in nbd_open() pannengyuan
2019-12-03 17:52 ` for 4.2 ??? " Vladimir Sementsov-Ogievskiy
2019-12-03 18:54 ` Eric Blake [this message]
2019-12-03 21:59 ` Eric Blake
2019-12-04 3:30 ` pannengyuan
2019-12-03 17:38 ` [PATCH V3 1/2] block/nbd: extract the common cleanup code Vladimir Sementsov-Ogievskiy
2019-12-04 3:12 ` pannengyuan
2019-12-04 7:19 ` Vladimir Sementsov-Ogievskiy
2019-12-04 7:24 ` Pan Nengyuan
2019-12-03 19:00 ` Eric Blake
2019-12-04 3:20 ` pannengyuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08f0d51d-f352-5d64-26a4-9a741a4cf2e0@redhat.com \
--to=eblake@redhat.com \
--cc=kuhn.chenqun@huawei.com \
--cc=kwolf@redhat.com \
--cc=liyiting@huawei.com \
--cc=mreitz@redhat.com \
--cc=pannengyuan@huawei.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=vsementsov@virtuozzo.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.