All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: Omar Sandoval <osandov@osandov.com>, linux-block@vger.kernel.org
Cc: kernel-team@fb.com, Hannes Reinecke <hare@suse.de>,
	Ming Lei <ming.lei@redhat.com>, Karel Zak <kzak@redhat.com>
Subject: Re: [PATCH v2 0/3] loop: LO_FLAGS_BLOCKSIZE fixes
Date: Tue, 22 Aug 2017 12:53:28 +0200	[thread overview]
Message-ID: <08f953e4-204d-a278-0021-09dfc77cae88@gmail.com> (raw)
In-Reply-To: <cover.1503084216.git.osandov@fb.com>

On 08/18/2017 09:27 PM, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
> 
> Patches 1 and 3 are from the original series.
> 
> Patch 2 gets rid of the redundant struct loop_device.lo_logical_blocksize
> in favor of using the queue's own logical_block_size. Karel, I decided
> against adding another sysfs entry since it will always be the same as
> queue/logical_block_size, is that alright with you?
> 
> Omar Sandoval (3):
>   loop: fix hang if LOOP_SET_STATUS gets invalid blocksize or encrypt
>     type
>   loop: use queue limit instead of private lo_logical_blocksize
>   loop: always return block size in LOOP_GET_STATUS

I tested these with cryptsetup & loop mapping with added block size setting
and it fixes loop problems I see in 4.13.

I think all these patches should go to 4.13.

Thanks!
Milan

      parent reply	other threads:[~2017-08-22 10:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 19:27 [PATCH v2 0/3] loop: LO_FLAGS_BLOCKSIZE fixes Omar Sandoval
2017-08-18 19:27 ` [PATCH v2 1/3] loop: fix hang if LOOP_SET_STATUS gets invalid blocksize or encrypt type Omar Sandoval
2017-08-18 19:27 ` [PATCH v2 2/3] loop: use queue limit instead of private lo_logical_blocksize Omar Sandoval
2017-08-21  5:58   ` Hannes Reinecke
2017-08-21 16:45     ` Omar Sandoval
2017-08-18 19:27 ` [PATCH v2 3/3] loop: always return block size in LOOP_GET_STATUS Omar Sandoval
2017-08-21  5:59   ` Hannes Reinecke
2017-08-22 10:53 ` Milan Broz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08f953e4-204d-a278-0021-09dfc77cae88@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=hare@suse.de \
    --cc=kernel-team@fb.com \
    --cc=kzak@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.