From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752362AbcFFUhN (ORCPT ); Mon, 6 Jun 2016 16:37:13 -0400 Received: from mail-db3on0083.outbound.protection.outlook.com ([157.55.234.83]:2080 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751058AbcFFUhL (ORCPT ); Mon, 6 Jun 2016 16:37:11 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=cmetcalf@mellanox.com; Subject: Re: undefined reference to `early_panic' To: Andrew Morton , kbuild test robot References: <201606051227.HWQZ0zJJ%fengguang.wu@intel.com> <20160606133120.cb13d4fa3b6bba4f5b427ca5@linux-foundation.org> CC: , , Dan Williams , Linux Memory Management List From: Chris Metcalf Message-ID: <0900b611-cfda-23bc-c56b-7e44a4d56a0d@mellanox.com> Date: Mon, 6 Jun 2016 16:36:47 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160606133120.cb13d4fa3b6bba4f5b427ca5@linux-foundation.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: CY1PR14CA0076.namprd14.prod.outlook.com (10.164.65.172) To AM4PR05MB1682.eurprd05.prod.outlook.com (10.165.245.153) X-MS-Office365-Filtering-Correlation-Id: bbcef3a7-bae6-4cf8-fd73-08d38e4a530b X-Microsoft-Exchange-Diagnostics: 1;AM4PR05MB1682;2:GnSg0VehlUDinJ54YJnew1tKl8iPJWiY6UR0IhRqIe84nkgIwh3zRwOTsJxo/1d2OjLSiprFp0vHeUxNpRkx299LjVASrBiuhE+G+3YM/lCWRZmw4kJqREUc0RrUyA5x6KH3l4JN5j8CIyWIO1tsm+S7e44UQbeBUkrdrgKqGmcP0Z6E9fbieIUDtJ6ut/Q8;3:rT/J6/ZlOtImjL2a426VV1K7XdV+o/DqDk9l0s93TaMw7MnYjKmwwF6Lw8K1yGI+5zGhOI9N6hspnVsuaP64TsdfDJqNOaS2J9bpkjfv+2H0TqPj7tsi6jm62vs0I6h5;25:PvaZx/4qFFntllzbDh80NIDKm/nAPWTHHCLYVdHokaDPaDIdpiqH/8rdJ8jDnGQ0/NV+iBJcgMjRQhpA2cEwMcVB3HV+uZnydzfu/2qvdz/x+5njrka4+jZFhS2BsYeDiJFobwKTxUPI6cvBXm+wZ+wEafCOA0UMA9eW1VmJVIWAVpVovtxHzgfx0MGgT5Qxgmv+94KJ1faGSjnrjkymYLQJWbKNhjCeQaCq586yzqyKSFYC8QjUSOdjs7MjP7njBO2W8uif8BFHP2BJDjOJriSOdHAvChyqU/ktOmL9uKw7wXba5W+/+NJFZI/ulU8+5rJ+7VgmCTo1hpOKK7+MmDePca1kvtaDtiIHZyhaM87x8OBqPmRwoKjI/T/jMyVnTX0MZTyuv6/P+IqxFGFU0XPibK/ax1Pztxg0jAkFyZE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR05MB1682; X-Microsoft-Exchange-Diagnostics: 1;AM4PR05MB1682;20:s69YtlUDpdLxPotRxcngDRhvHyvp31bMUnw2JUTp3Vc9UksDbTEIY+eT3h8TZTHnCnDNY2j6r2jPay7HMAIhjnF1fuPXvDu2z1vFLufEz2VauV7yXS2VZVG+T6iHIHTDx6wXkVIUjvQVmOdy0bgxc91JHJkDE6FrG7+digUJsVYQvJ8NDTJQUhgcthNfsPKjy/RNPHejHTxHQaEgaz13jO7cqJBa/mgqgJ7VBDEp3OKQJ2PrBHNoUZNrjiKp3bZuwmH6N6voSA0glaDSrieOT37RBidvWPDWvNHJcIaX7/wHKLKJL9VXBktKGYD9HjZeSvbJ4l98iuwNkx4uICG03fmJDTFxyEV2JOe3s22f0yzWsKN3gYAi4GkAszJYHiZv0loRMm7tzmqHyFvB63h9IsgtKr4qOmlZcGL4xAX0yAY25u4f7jzFrxIjUNnmTLWZRuxxXCjJPWzF4d2mPL06GEilJX9UKyi9yvaV2cBbCkOim/eOPwQ1sSJKUEAn3SVh X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(171992500451332)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:AM4PR05MB1682;BCL:0;PCL:0;RULEID:;SRVR:AM4PR05MB1682; X-Microsoft-Exchange-Diagnostics: 1;AM4PR05MB1682;4:N7mhSx6zE1LTDi4mv2XN9EA40bnLqXmJSdVbhGVtG+j1k/eiCcZ+PCt8CWJJslnBXD672oHXFF+eeQMldTBqTj6ZsR7iPN9ZtHcG3IwBoHoXVowVJllR3pYLLDwFjh+kCDh/LLKvKsKZqn7ts41+xoKRYBLVLZjpMNaDXATkIZLlh/1a7O0FmKtYn0H9q4D3gmozB10P2jR8z4aZWkG7TFyfeuM55wvpfIVT6HMPk7GwzKMTYQaDifHsh0IrfjmbwMUMbYSFLtEmljN6BkQz1Kyjwz9V+kQdAfxBD9US393imX4Iy1Ds3/dMdevW3GAZcERqqDoqq3kxfoIAdVNmDHK5QAjEHCrNoCdc8OBN8KQjlPsXlCM6HrrQo2Jntm61WPWqz8o06Q9fRsG+BY5oHxD8/W1U3tSa1IHCmrSzbtjJN1Uvt2vFLSkPS5rIiqHjCRtsFYQ82QD0mvz32YXfbA== X-Forefront-PRVS: 096507C068 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(377454003)(24454002)(199003)(189002)(5001770100001)(47776003)(68736007)(23746002)(101416001)(33646002)(66066001)(65806001)(3846002)(65956001)(6116002)(97736004)(86362001)(42186005)(31686004)(4326007)(83506001)(92566002)(105586002)(50466002)(64126003)(106356001)(5004730100002)(50986999)(230700001)(54356999)(36756003)(15975445007)(77096005)(4001350100001)(76176999)(5008740100001)(586003)(19580395003)(19580405001)(31696002)(8676002)(189998001)(2950100001)(2906002)(81166006)(81156014)(65826006)(81973001)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR05MB1682;H:[10.15.7.169];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM4PR05MB1682;23:hJpAValhVlvxiCA/rVpPAlb8tO/f1k2NCWnTQ?= =?Windows-1252?Q?piYoDM1Lk+pu8/ZrR5w2W9gq0wainKLqNdVadgXyRZSq1ovbySN03g8I?= =?Windows-1252?Q?pHk4apx4jCh1HhMyANw/OUfYeQix55o7cqMyw6muZqqdP8+/nDkm2z0o?= =?Windows-1252?Q?gOFqNWb7GSyLiS3/QNGRFDi9shh0UWX1FiNHK+CfYfZcGFjj+6cp3dFE?= =?Windows-1252?Q?Lb7ggyFmzsdgJuWqZoRKd4QiO/HuE5eGEKOT5w0aruaL5R9yRLrxcYc5?= =?Windows-1252?Q?X9VSUbmheG17igNm3mZg8+ewNmZG5RmYO3UH3KJAvoGo7vyvw5ai80gB?= =?Windows-1252?Q?J2zU6FbeKczKzdw3/qjPTQcxuFREt0AG0wCjIXBnwu7lD8PMKvmiAtZc?= =?Windows-1252?Q?X1A+Y/2zTEPkbkYOyDdQdrAA7uSFdI6XxA7bmMWxsa2qY8Jj++ZVaOHt?= =?Windows-1252?Q?Bev4VcHbE1rVZ26jzY5nTopwriUt3oiiKot5Dm2hTjP5BgCc6a7J82Xu?= =?Windows-1252?Q?A6u9O4zd5s8UszPkVmYfld5I7jQVX9xMImeIKtneTWmOaZS8MJOdObGZ?= =?Windows-1252?Q?7OpIzDkUSOb4+Xv0V5OBkfsN+3NjjqevfCzAdvMRzwdY21CkfZZKPM5Q?= =?Windows-1252?Q?KCYPW9EaZ47zHKeQfOHJXw58StkWakXDMCrOZDvI546gEffRuRgWmnZm?= =?Windows-1252?Q?NXkGiTJNboM293G4EC/TD/3pMpvR2HHIraTYngp7RtJ2wC5o2ofi1f0f?= =?Windows-1252?Q?Yd3SLYu23N8/B9ushGaTuSpr1wuF89KPfcQFlLdT+UNb75Q6nRtF3wYi?= =?Windows-1252?Q?oMwm/enKWqkhb9RGq9UK2hb1m70YGEbIwZMV8FP/WH5CwN3yCpxPeIkc?= =?Windows-1252?Q?xjhCUlKu3wXDaICWIXO5eLEAg4vd0bVYFGe1JPiolSg0k1Ayge+9xNQZ?= =?Windows-1252?Q?OE+5/YSK8cZb7B4778QpidohvQy0eBUFH+UaSRD6zGzg93RWzcQ9wxsv?= =?Windows-1252?Q?R4yrjvIfDfMNYfhmEE0Oaio0Vd7TVZgTGbHgSI30y7ey7AWLq/RFsEVH?= =?Windows-1252?Q?+zDViG5cL71gtpyBTl5Wuvojw90qRQk+Xls7y/ACcJQ0bYlOaRvFJ4l3?= =?Windows-1252?Q?yv4s7wkz1nz3ITUcRx/+xNc5le4UjScB1Nm1zA/Px2XOhsHPwiuNQMz4?= =?Windows-1252?Q?b8M4lIgrnWFMaN751zHkWVq4Yj4R40XGpnzKJFGTQQg/KEgc9BkS60rU?= =?Windows-1252?Q?C9FtrPKaac5eNqWkFrxvmcuFrquIFkrJTzgUOQT2PaP51ENppQUVK2Kb?= =?Windows-1252?Q?uSRKFtteFr0aosxV1puBs5bweoe7gr1jB8hMcYuBu7c0zPJw1CZwo2hP?= =?Windows-1252?Q?20A1L9lsRwVki84xt+XN/oqBvyBH9gWJtQMvDUYvnW8PoIc6qF4A0kvm?= =?Windows-1252?Q?8mb2hE4qsUHhpJjgR1X?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR05MB1682;5:GzYvL67hET/h4i5hFdjsJ+S68uD/Gn3Nqn5K6gdcRvq1JRFWfltGTLSM8HFJj00sYMDXHTuWhto1GIPDCed5V8O2VZAtAnHSkFisecuKvTaZf7J9RjmS4uTpeIn3D6zqgTU1z58JC1LFE4T4BH7BJg==;24:zKeu/rsjM11tmWABBIMZDbF+BAFmjMA7peaSWJOZT2lZcO9jHoGzGbx1UoXwgqeFYUvmySqrySNECnu8MoKdTA8pk/fGKZoD4Jz8YZRu8B0=;7:BVf2ofXbmZYch/A3BH+mckBgt5mHRd1+04Qdrwuey9sRcVfVgTqKfjaAjBSv6tlWPO4u30B9kAJHVzGqqFzDr3p4qdOztF/k+Gsxu4qM/OEKo9CNiWnmVGYWAVZS01PnZysksJIOkqixfB+FGiM35tPAM21w/kxX9kxuAstuIV0gndwUjxMe7auk58pNT4XhzAL4fCOowhUK65RdaCVu7gv4g/MhYeGjHeoJGhUg1e0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2016 20:37:04.0608 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB1682 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/6/2016 4:31 PM, Andrew Morton wrote: > On Sun, 5 Jun 2016 12:33:29 +0800 kbuild test robot wrote: > >> [...] >> >> arch/tile/built-in.o: In function `setup_arch': >>>> (.init.text+0x15d8): undefined reference to `early_panic' >> > This? > > From: Andrew Morton > Subject: tile: early_printk.o is always required > > arch/tile/setup.o is always compiled, and it requires early_panic() and > hence early_printk(), so we must always build and link early_printk.o. > > [...] > > diff -puN arch/tile/Kconfig~tile-early_printko-is-always-required arch/tile/Kconfig > --- a/arch/tile/Kconfig~tile-early_printko-is-always-required > +++ a/arch/tile/Kconfig > @@ -14,6 +14,7 @@ config TILE > select GENERIC_FIND_FIRST_BIT > select GENERIC_IRQ_PROBE > select GENERIC_IRQ_SHOW > + select EARLY_PRINTK > select GENERIC_PENDING_IRQ if SMP > select GENERIC_STRNCPY_FROM_USER > select GENERIC_STRNLEN_USER Seems plausible; thanks. Acked-by: Chris Metcalf -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f70.google.com (mail-it0-f70.google.com [209.85.214.70]) by kanga.kvack.org (Postfix) with ESMTP id C79316B0005 for ; Mon, 6 Jun 2016 16:37:09 -0400 (EDT) Received: by mail-it0-f70.google.com with SMTP id f67so99515305ith.2 for ; Mon, 06 Jun 2016 13:37:09 -0700 (PDT) Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-eopbgr30057.outbound.protection.outlook.com. [40.107.3.57]) by mx.google.com with ESMTPS id t83si9782479oig.89.2016.06.06.13.37.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Jun 2016 13:37:09 -0700 (PDT) Subject: Re: undefined reference to `early_panic' References: <201606051227.HWQZ0zJJ%fengguang.wu@intel.com> <20160606133120.cb13d4fa3b6bba4f5b427ca5@linux-foundation.org> From: Chris Metcalf Message-ID: <0900b611-cfda-23bc-c56b-7e44a4d56a0d@mellanox.com> Date: Mon, 6 Jun 2016 16:36:47 -0400 MIME-Version: 1.0 In-Reply-To: <20160606133120.cb13d4fa3b6bba4f5b427ca5@linux-foundation.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton , kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, Dan Williams , Linux Memory Management List On 6/6/2016 4:31 PM, Andrew Morton wrote: > On Sun, 5 Jun 2016 12:33:29 +0800 kbuild test robot wrote: > >> [...] >> >> arch/tile/built-in.o: In function `setup_arch': >>>> (.init.text+0x15d8): undefined reference to `early_panic' >> > This? > > From: Andrew Morton > Subject: tile: early_printk.o is always required > > arch/tile/setup.o is always compiled, and it requires early_panic() and > hence early_printk(), so we must always build and link early_printk.o. > > [...] > > diff -puN arch/tile/Kconfig~tile-early_printko-is-always-required arch/tile/Kconfig > --- a/arch/tile/Kconfig~tile-early_printko-is-always-required > +++ a/arch/tile/Kconfig > @@ -14,6 +14,7 @@ config TILE > select GENERIC_FIND_FIRST_BIT > select GENERIC_IRQ_PROBE > select GENERIC_IRQ_SHOW > + select EARLY_PRINTK > select GENERIC_PENDING_IRQ if SMP > select GENERIC_STRNCPY_FROM_USER > select GENERIC_STRNLEN_USER Seems plausible; thanks. Acked-by: Chris Metcalf -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org