From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9571DCA9EB9 for ; Tue, 29 Oct 2019 05:07:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65BD020679 for ; Tue, 29 Oct 2019 05:07:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731452AbfJ2FHQ (ORCPT ); Tue, 29 Oct 2019 01:07:16 -0400 Received: from mga02.intel.com ([134.134.136.20]:12419 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729216AbfJ2FHP (ORCPT ); Tue, 29 Oct 2019 01:07:15 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2019 22:07:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,242,1569308400"; d="scan'208";a="224855033" Received: from allen-box.sh.intel.com (HELO [10.239.159.136]) ([10.239.159.136]) by fmsmga004.fm.intel.com with ESMTP; 28 Oct 2019 22:07:12 -0700 Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org, LKML , Joerg Roedel , David Woodhouse , Alex Williamson , Jean-Philippe Brucker , Yi Liu , "Tian, Kevin" , Raj Ashok , Christoph Hellwig , Jonathan Cameron , Eric Auger Subject: Re: [PATCH v7 09/11] iommu/vt-d: Add bind guest PASID support To: Jacob Pan References: <1571946904-86776-1-git-send-email-jacob.jun.pan@linux.intel.com> <1571946904-86776-10-git-send-email-jacob.jun.pan@linux.intel.com> <20191028152945.13bc22fa@jacob-builder> <20191028211121.4ba2f332@jacob-builder> From: Lu Baolu Message-ID: <0907d1ef-e36d-4bc5-8715-bc0c50a78a5c@linux.intel.com> Date: Tue, 29 Oct 2019 13:04:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191028211121.4ba2f332@jacob-builder> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/29/19 12:11 PM, Jacob Pan wrote: > On Tue, 29 Oct 2019 10:54:48 +0800 > Lu Baolu wrote: > >> Hi, >> >> On 10/29/19 6:29 AM, Jacob Pan wrote: >>> Hi Baolu, >>> >>> Appreciate the thorough review, comments inline. >> You are welcome. >> >>> On Sat, 26 Oct 2019 10:01:19 +0800 >>> Lu Baolu wrote: >>> >>>> Hi, >>>> >> [...] >> >>>>> + * allow multiple bind calls with the >>>>> same PASID and pdev. >>>>> + */ >>>>> + sdev->users++; >>>>> + goto out; >>>>> + } >>>> I remember I ever pointed this out before. But I forgot how we >>>> addressed it. So forgive me if this has been addressed. >>>> >>>> What if we have a valid bound svm but @dev doesn't belong to it >>>> (a.k.a. @dev not in svm->devs list)? >>>> >>> If we are binding a new device to an existing/active PASID, the code >>> will allocate a new sdev and add that to the svm->devs list. >> But allocating a new sdev and adding device is in below else branch, >> so it will never reach there, right? >> > No, allocating sdev is outside else branch. Oh, yes! Please ignore it. Best regards, baolu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74BF9CA9EB9 for ; Tue, 29 Oct 2019 05:07:21 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 483F920679 for ; Tue, 29 Oct 2019 05:07:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 483F920679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 02511D67; Tue, 29 Oct 2019 05:07:21 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 4B199CCE for ; Tue, 29 Oct 2019 05:07:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9E58914D for ; Tue, 29 Oct 2019 05:07:17 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2019 22:07:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,242,1569308400"; d="scan'208";a="224855033" Received: from allen-box.sh.intel.com (HELO [10.239.159.136]) ([10.239.159.136]) by fmsmga004.fm.intel.com with ESMTP; 28 Oct 2019 22:07:12 -0700 Subject: Re: [PATCH v7 09/11] iommu/vt-d: Add bind guest PASID support To: Jacob Pan References: <1571946904-86776-1-git-send-email-jacob.jun.pan@linux.intel.com> <1571946904-86776-10-git-send-email-jacob.jun.pan@linux.intel.com> <20191028152945.13bc22fa@jacob-builder> <20191028211121.4ba2f332@jacob-builder> From: Lu Baolu Message-ID: <0907d1ef-e36d-4bc5-8715-bc0c50a78a5c@linux.intel.com> Date: Tue, 29 Oct 2019 13:04:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191028211121.4ba2f332@jacob-builder> Content-Language: en-US Cc: "Tian, Kevin" , Raj Ashok , Jean-Philippe Brucker , iommu@lists.linux-foundation.org, LKML , Alex Williamson , David Woodhouse , Jonathan Cameron X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Hi, On 10/29/19 12:11 PM, Jacob Pan wrote: > On Tue, 29 Oct 2019 10:54:48 +0800 > Lu Baolu wrote: > >> Hi, >> >> On 10/29/19 6:29 AM, Jacob Pan wrote: >>> Hi Baolu, >>> >>> Appreciate the thorough review, comments inline. >> You are welcome. >> >>> On Sat, 26 Oct 2019 10:01:19 +0800 >>> Lu Baolu wrote: >>> >>>> Hi, >>>> >> [...] >> >>>>> + * allow multiple bind calls with the >>>>> same PASID and pdev. >>>>> + */ >>>>> + sdev->users++; >>>>> + goto out; >>>>> + } >>>> I remember I ever pointed this out before. But I forgot how we >>>> addressed it. So forgive me if this has been addressed. >>>> >>>> What if we have a valid bound svm but @dev doesn't belong to it >>>> (a.k.a. @dev not in svm->devs list)? >>>> >>> If we are binding a new device to an existing/active PASID, the code >>> will allocate a new sdev and add that to the svm->devs list. >> But allocating a new sdev and adding device is in below else branch, >> so it will never reach there, right? >> > No, allocating sdev is outside else branch. Oh, yes! Please ignore it. Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu