From: Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>
To: Martin Wilck <mwilck@suse.de>
Cc: "ptesarik@suse.cz" <ptesarik@suse.cz>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: RE: [PATCH v3 1/3] open_dump_bitmap: open bitmap file in non-cyclic case
Date: Wed, 21 Sep 2016 06:29:34 +0000 [thread overview]
Message-ID: <0910DD04CBD6DE4193FCF86B9C00BE9701E6A9FB@BPXM01GP.gisp.nec.co.jp> (raw)
In-Reply-To: <20160920103329.3023-1-mwilck@suse.de>
Hello Martin,
>The logic of set_bitmap() requires that a bitmap fd exists in the
>non-cyclic case.
>
>Signed-off-by: Martin Wilck <mwilck@suse.de>
I'll merge this version into v1.6.1, thanks for your work.
Regards,
Atsushi Kumagai
>---
> makedumpfile.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/makedumpfile.c b/makedumpfile.c
>index d168dfd..6164468 100644
>--- a/makedumpfile.c
>+++ b/makedumpfile.c
>@@ -1365,7 +1365,7 @@ open_dump_bitmap(void)
>
> /* Unnecessary to open */
> if (!info->working_dir && !info->flag_reassemble && !info->flag_refiltering
>- && !info->flag_sadump && !info->flag_mem_usage)
>+ && !info->flag_sadump && !info->flag_mem_usage && info->flag_cyclic)
> return TRUE;
>
> tmpname = getenv("TMPDIR");
>--
>2.9.3
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2016-09-21 6:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 12:56 [PATCH 0/3] makedumpfile: fix segfault with -X in XEN environment Martin Wilck
2016-08-10 12:56 ` [PATCH 1/3] open_dump_bitmap: open bitmap file in non-cyclic case Martin Wilck
2016-08-10 12:56 ` [PATCH 2/3] move call to open_dump_bitmap() to after call to initial() Martin Wilck
2016-08-10 12:56 ` [PATCH 3/3] close_dump_bitmap: simplify logic Martin Wilck
2016-08-10 13:08 ` Petr Tesarik
2016-08-10 13:35 ` Martin Wilck
2016-08-16 0:37 ` Atsushi Kumagai
2016-08-16 5:59 ` Petr Tesarik
2016-08-17 7:37 ` Martin Wilck
2016-09-06 8:22 ` [PATCH] Cleanup: Use a negative number for uninitialized file descriptors Petr Tesarik
2016-09-09 6:27 ` Atsushi Kumagai
2016-09-09 7:31 ` Petr Tesarik
2016-09-09 8:11 ` [PATCH v2] " Petr Tesarik
2016-09-12 8:17 ` Atsushi Kumagai
2016-09-14 10:17 ` [PATCH v2 1/3] open_dump_bitmap: open bitmap file in non-cyclic case Martin Wilck
2016-09-14 10:17 ` [PATCH v2 2/3] move call to open_dump_bitmap() to after call to initial() Martin Wilck
2016-09-14 10:17 ` [PATCH v2 3/3] close_dump_bitmap: simplify logic Martin Wilck
2016-09-14 11:50 ` [PATCH v3 " Martin Wilck
2016-09-20 9:43 ` Atsushi Kumagai
2016-09-20 10:31 ` Martin Wilck
2016-09-20 10:33 ` [PATCH v3 1/3] open_dump_bitmap: open bitmap file in non-cyclic case Martin Wilck
2016-09-20 10:33 ` [PATCH v3 2/3] move call to open_dump_bitmap() to after call to initial() Martin Wilck
2016-09-20 10:33 ` [PATCH v3 3/3] close_dump_bitmap: simplify logic Martin Wilck
2016-09-21 6:29 ` Atsushi Kumagai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0910DD04CBD6DE4193FCF86B9C00BE9701E6A9FB@BPXM01GP.gisp.nec.co.jp \
--to=ats-kumagai@wm.jp.nec.com \
--cc=kexec@lists.infradead.org \
--cc=mwilck@suse.de \
--cc=ptesarik@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.