From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88D4BC432BE for ; Thu, 26 Aug 2021 20:03:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C10260FDC for ; Thu, 26 Aug 2021 20:03:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243497AbhHZUEL (ORCPT ); Thu, 26 Aug 2021 16:04:11 -0400 Received: from mxout01.lancloud.ru ([45.84.86.81]:58510 "EHLO mxout01.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243492AbhHZUEI (ORCPT ); Thu, 26 Aug 2021 16:04:08 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout01.lancloud.ru 58A41209AFD4 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info To: Biju Das , Andrew Lunn CC: "David S. Miller" , Jakub Kicinski , Prabhakar Mahadev Lad , "Geert Uytterhoeven" , Adam Ford , Yoshihiro Shimoda , "netdev@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Chris Paterson , Biju Das References: <20210825070154.14336-5-biju.das.jz@bp.renesas.com> <777c30b1-e94e-e241-b10c-ecd4d557bc06@omp.ru> <78ff279d-03f1-6932-88d8-1eac83d087ec@omp.ru> <9b0d5bab-e9a2-d9f6-69f7-049bfb072eba@omp.ru> <93dab08c-4b0b-091d-bd47-6e55bce96f8a@gmail.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <0916b09c-e656-fa2a-54d9-ca0c1301a278@omp.ru> Date: Thu, 26 Aug 2021 23:03:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/26/21 10:37 PM, Biju Das wrote: [...] >>>>>> Do you agree GAC register(gPTP active in Config) bit in AVB-DMAC >> mode register(CCC) present only in R-Car Gen3? >>>>> >>>>> Yes. >>>>> But you feature naming is totally misguiding, nevertheless... >>>> >>>> It can still be changed. >>> >>> Thank goodness, yea! >> >> We have to live with the first version of this in the git history, but we >> can add more patches fixing up whatever is broken in the unreviewed code >> which got merged. >> >>>> Just suggest a new name. >>> >>> I'd prolly go with 'gptp' for the gPTP support and 'ccc_gac' for >>> the gPTP working also in CONFIG mode (CCC.GAC controls this feature). >> >> Biju, please could you work on a couple of patches to change the names. > > Yes. Will work on the patches to change the names as suggested. TIA! After some more thinking, 'no_gptp' seems to suit better for the 1st case Might need to invert the checks tho... [...] > Cheers, > Biju MBR, Sergey