From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Armstrong Date: Thu, 26 Oct 2017 15:39:17 +0200 Subject: [U-Boot] [PATCH u-boot 1/3] net: phy: Add Amlogic Meson GXL Internal PHY support In-Reply-To: References: <1508313732-19282-1-git-send-email-narmstrong@baylibre.com> <1508313732-19282-2-git-send-email-narmstrong@baylibre.com> Message-ID: <0921db70-a4bb-ea2e-d273-44280a2acc3c@baylibre.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 22/10/2017 16:36, Simon Glass wrote: > On 18 October 2017 at 10:02, Neil Armstrong wrote: >> The Amlogic Meson GXL/GXM families embeds an internal RMII Ethernet PHY. >> >> The PHY acts as a generic PHY but needs a slight configuration right >> before it's configuration. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/net/phy/Kconfig | 3 +++ >> drivers/net/phy/Makefile | 1 + >> drivers/net/phy/meson-gxl.c | 57 +++++++++++++++++++++++++++++++++++++++++++++ >> drivers/net/phy/phy.c | 3 +++ >> include/phy.h | 1 + >> 5 files changed, 65 insertions(+) >> create mode 100644 drivers/net/phy/meson-gxl.c > > We really should create a uclass for PHY drivers before adding any > more of these. > > Regards, > Simon > Hi Simon, Sure, this would indeed be necessary, but is it necessary to wait for the uclass to merge mode PHYs ? Neil From mboxrd@z Thu Jan 1 00:00:00 1970 From: narmstrong@baylibre.com (Neil Armstrong) Date: Thu, 26 Oct 2017 15:39:17 +0200 Subject: [PATCH u-boot 1/3] net: phy: Add Amlogic Meson GXL Internal PHY support In-Reply-To: References: <1508313732-19282-1-git-send-email-narmstrong@baylibre.com> <1508313732-19282-2-git-send-email-narmstrong@baylibre.com> Message-ID: <0921db70-a4bb-ea2e-d273-44280a2acc3c@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On 22/10/2017 16:36, Simon Glass wrote: > On 18 October 2017 at 10:02, Neil Armstrong wrote: >> The Amlogic Meson GXL/GXM families embeds an internal RMII Ethernet PHY. >> >> The PHY acts as a generic PHY but needs a slight configuration right >> before it's configuration. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/net/phy/Kconfig | 3 +++ >> drivers/net/phy/Makefile | 1 + >> drivers/net/phy/meson-gxl.c | 57 +++++++++++++++++++++++++++++++++++++++++++++ >> drivers/net/phy/phy.c | 3 +++ >> include/phy.h | 1 + >> 5 files changed, 65 insertions(+) >> create mode 100644 drivers/net/phy/meson-gxl.c > > We really should create a uclass for PHY drivers before adding any > more of these. > > Regards, > Simon > Hi Simon, Sure, this would indeed be necessary, but is it necessary to wait for the uclass to merge mode PHYs ? Neil