From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753242AbeDCTS2 (ORCPT ); Tue, 3 Apr 2018 15:18:28 -0400 Received: from mga09.intel.com ([134.134.136.24]:53419 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752924AbeDCTS0 (ORCPT ); Tue, 3 Apr 2018 15:18:26 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,402,1517904000"; d="asc'?scan'208";a="31253898" From: "Rustad, Mark D" To: "Michael S. Tsirkin" CC: Alexander Duyck , "Daly, Dan" , Bjorn Helgaas , "Duyck, Alexander H" , "linux-pci@vger.kernel.org" , "virtio-dev@lists.oasis-open.org" , kvm-devel , Netdev , LKML , "linux-nvme@lists.infradead.org" , "Busch, Keith" , "netanel@amazon.com" , Don Dutile , Maximilian Heyne , "Wang, Liang-min" , David Woodhouse , Christoph Hellwig , "dwmw@amazon.co.uk" Subject: Re: [virtio-dev] [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices Thread-Topic: [virtio-dev] [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices Thread-Index: AQHTvI1siq32SjdMxU+NwObgk2U5/6PThamAgAABlwCAHA/fgIAASHYAgAAPkYCAAA4nAA== Date: Tue, 3 Apr 2018 19:18:23 +0000 Message-ID: <0927465E-0B56-4903-9F5E-288A7D9C46E6@intel.com> References: <20180315183449.3102.64791.stgit@localhost.localdomain> <20180315184132.3102.90947.stgit@localhost.localdomain> <20180316183042-mutt-send-email-mst@kernel.org> <20180403161151-mutt-send-email-mst@kernel.org> <20180403212503-mutt-send-email-mst@kernel.org> In-Reply-To: <20180403212503-mutt-send-email-mst@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.233.81.62] Content-Type: multipart/signed; boundary="Apple-Mail=_C63078D8-EFD9-47F7-B81E-F2320701BA1F"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Apple-Mail=_C63078D8-EFD9-47F7-B81E-F2320701BA1F Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii; delsp=yes; format=flowed On Apr 3, 2018, at 11:27 AM, Michael S. Tsirkin wrote: >> I'm not sure why you would need a feature bit. The capability is >> controlled via PCI configuration space. If it is present the device >> has the capability. If it is not then it does not. >> >> Basically if the PCI configuration space is not present then the sysfs >> entries will not be spawned and nothing will attempt to use this >> function. >> >> - ALex > > It's about compability with older guests which ignore the > capability. > > The feature is thus helpful so host knows whether guest supports VFs. This is not about a guest creating its own VFs. This is about a host PF that happens to have a virtio interface to be able to create virtio VFs that can be assigned to guests. Nothing changes at all from a guest perspective. Or maybe I am not understanding what you mean by "whether guest supports VFs". -- Mark Rustad, Networking Division, Intel Corporation --Apple-Mail=_C63078D8-EFD9-47F7-B81E-F2320701BA1F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iQIzBAEBCAAdFiEE6ug8b0Wg+ULmnksNPA7/547j7m4FAlrD034ACgkQPA7/547j 7m5NWBAAwS8hSMcLsTqh7qp59nFGFZgOM91t49d2Hh4eZI2XOtGG/4uKk7oiQx6/ S6p8c3FnA2IFPKSc3HpGk4lha6JL45LE6emSeYmGoyOTaUR+u48HrB65IIPbLjJA 8B8X+do+vtLyp31t61UH1BcO6oYwgRnAIojrKFjM7ga8fnbn0YprCDuGxIeDF/QY iXZ373KYf8rbPDIDt9I9USntO6Id47/usTVeTAiyn6Fvjp0AxWm0/JRdOZvoNn2D ZEpugdAm3oPG59IZSk9zQzh61VxAL7qOIsGBON60tYQZsHpJKLmsiwwksW3hhmCB cE6bcSKmHA5KkA230UtHVizVnja7zJ4TC5luJmctQ1uNzxUL5kMqDuGpCxpGaBml 7JlF6mhyTGuz3ZgkOkUaH+flpU2AXJ91kxAw1yB9cjZQ17S7ZHO0ke5/lyhzBV1Y oz+02LIpgN6KkSuKWS8M1jSDzWpTt7XXJII5ZdcOn8DYrguW2541vltoZlTh1B71 rCZgT1RfUjktaEaUlGJ7yZ6f4hPtI5cAdfLXw7BHOZNZgkJNxjCKO3Vvi/HRiyQJ KdE4pmd4cwOey0NKwcDR3wdYG1/dKrlQCGzb2siaOiCrdIK46FHA3Ubg8PmA1qNk 3xdRPPTgy3c8iGGWFnUyOTgLPMgPavz+fsZmtQrzBg4L3QV/CS4= =0tdq -----END PGP SIGNATURE----- --Apple-Mail=_C63078D8-EFD9-47F7-B81E-F2320701BA1F-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rustad, Mark D" Subject: Re: [virtio-dev] [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices Date: Tue, 3 Apr 2018 19:18:23 +0000 Message-ID: <0927465E-0B56-4903-9F5E-288A7D9C46E6@intel.com> References: <20180315183449.3102.64791.stgit@localhost.localdomain> <20180315184132.3102.90947.stgit@localhost.localdomain> <20180316183042-mutt-send-email-mst@kernel.org> <20180403161151-mutt-send-email-mst@kernel.org> <20180403212503-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Apple-Mail=_C63078D8-EFD9-47F7-B81E-F2320701BA1F"; protocol="application/pgp-signature"; micalg=pgp-sha256 Cc: Alexander Duyck , "Daly, Dan" , Bjorn Helgaas , "Duyck, Alexander H" , "linux-pci@vger.kernel.org" , "virtio-dev@lists.oasis-open.org" , kvm-devel , Netdev , LKML , "linux-nvme@lists.infradead.org" , "Busch, Keith" , "netanel@amazon.com" , Don Dutile , Maximilian Heyne , "Wang, Liang-min" , David Woodhouse , Christoph Hellwig , "dwmw@amazon.co.uk" Return-path: In-Reply-To: <20180403212503-mutt-send-email-mst@kernel.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org --Apple-Mail=_C63078D8-EFD9-47F7-B81E-F2320701BA1F Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii; delsp=yes; format=flowed On Apr 3, 2018, at 11:27 AM, Michael S. Tsirkin wrote: >> I'm not sure why you would need a feature bit. The capability is >> controlled via PCI configuration space. If it is present the device >> has the capability. If it is not then it does not. >> >> Basically if the PCI configuration space is not present then the sysfs >> entries will not be spawned and nothing will attempt to use this >> function. >> >> - ALex > > It's about compability with older guests which ignore the > capability. > > The feature is thus helpful so host knows whether guest supports VFs. This is not about a guest creating its own VFs. This is about a host PF that happens to have a virtio interface to be able to create virtio VFs that can be assigned to guests. Nothing changes at all from a guest perspective. Or maybe I am not understanding what you mean by "whether guest supports VFs". -- Mark Rustad, Networking Division, Intel Corporation --Apple-Mail=_C63078D8-EFD9-47F7-B81E-F2320701BA1F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iQIzBAEBCAAdFiEE6ug8b0Wg+ULmnksNPA7/547j7m4FAlrD034ACgkQPA7/547j 7m5NWBAAwS8hSMcLsTqh7qp59nFGFZgOM91t49d2Hh4eZI2XOtGG/4uKk7oiQx6/ S6p8c3FnA2IFPKSc3HpGk4lha6JL45LE6emSeYmGoyOTaUR+u48HrB65IIPbLjJA 8B8X+do+vtLyp31t61UH1BcO6oYwgRnAIojrKFjM7ga8fnbn0YprCDuGxIeDF/QY iXZ373KYf8rbPDIDt9I9USntO6Id47/usTVeTAiyn6Fvjp0AxWm0/JRdOZvoNn2D ZEpugdAm3oPG59IZSk9zQzh61VxAL7qOIsGBON60tYQZsHpJKLmsiwwksW3hhmCB cE6bcSKmHA5KkA230UtHVizVnja7zJ4TC5luJmctQ1uNzxUL5kMqDuGpCxpGaBml 7JlF6mhyTGuz3ZgkOkUaH+flpU2AXJ91kxAw1yB9cjZQ17S7ZHO0ke5/lyhzBV1Y oz+02LIpgN6KkSuKWS8M1jSDzWpTt7XXJII5ZdcOn8DYrguW2541vltoZlTh1B71 rCZgT1RfUjktaEaUlGJ7yZ6f4hPtI5cAdfLXw7BHOZNZgkJNxjCKO3Vvi/HRiyQJ KdE4pmd4cwOey0NKwcDR3wdYG1/dKrlQCGzb2siaOiCrdIK46FHA3Ubg8PmA1qNk 3xdRPPTgy3c8iGGWFnUyOTgLPMgPavz+fsZmtQrzBg4L3QV/CS4= =0tdq -----END PGP SIGNATURE----- --Apple-Mail=_C63078D8-EFD9-47F7-B81E-F2320701BA1F-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.d.rustad@intel.com (Rustad, Mark D) Date: Tue, 3 Apr 2018 19:18:23 +0000 Subject: [virtio-dev] [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices In-Reply-To: <20180403212503-mutt-send-email-mst@kernel.org> References: <20180315183449.3102.64791.stgit@localhost.localdomain> <20180315184132.3102.90947.stgit@localhost.localdomain> <20180316183042-mutt-send-email-mst@kernel.org> <20180403161151-mutt-send-email-mst@kernel.org> <20180403212503-mutt-send-email-mst@kernel.org> Message-ID: <0927465E-0B56-4903-9F5E-288A7D9C46E6@intel.com> On Apr 3, 2018,@11:27 AM, Michael S. Tsirkin wrote: >> I'm not sure why you would need a feature bit. The capability is >> controlled via PCI configuration space. If it is present the device >> has the capability. If it is not then it does not. >> >> Basically if the PCI configuration space is not present then the sysfs >> entries will not be spawned and nothing will attempt to use this >> function. >> >> - ALex > > It's about compability with older guests which ignore the > capability. > > The feature is thus helpful so host knows whether guest supports VFs. This is not about a guest creating its own VFs. This is about a host PF that happens to have a virtio interface to be able to create virtio VFs that can be assigned to guests. Nothing changes at all from a guest perspective. Or maybe I am not understanding what you mean by "whether guest supports VFs". -- Mark Rustad, Networking Division, Intel Corporation -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 873 bytes Desc: Message signed with OpenPGP URL: