From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from coyote.holtmann.net ([212.227.132.17]:56694 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065AbdDIMLv (ORCPT ); Sun, 9 Apr 2017 08:11:51 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH] net: rfkill: gpio: Add OBDA8723 ACPI HID From: Marcel Holtmann In-Reply-To: Date: Sun, 9 Apr 2017 14:11:48 +0200 Cc: Johannes Berg , "David S. Miller" , linux-wireless , Network Development , russianneuromancer@ya.ru, Greg Kroah-Hartman Message-Id: <0939E68A-DBF5-40BF-B83B-73AF234EB60B@holtmann.org> (sfid-20170409_141157_724719_E5C46936) References: <20170408210520.2799-1-hdegoede@redhat.com> To: Hans de Goede Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Hans, >>> The OBDA8723 ACPI HID is used on quite a few Bay Trail based tablets >>> for bluetooth rfkill functionality. >>> >>> Tested-by: russianneuromancer@ya.ru >>> Signed-off-by: Hans de Goede >>> --- >>> net/rfkill/rfkill-gpio.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c >>> index 76c01cb..50ca65e 100644 >>> --- a/net/rfkill/rfkill-gpio.c >>> +++ b/net/rfkill/rfkill-gpio.c >>> @@ -163,6 +163,7 @@ static int rfkill_gpio_remove(struct platform_device *pdev) >>> static const struct acpi_device_id rfkill_acpi_match[] = { >>> { "BCM4752", RFKILL_TYPE_GPS }, >>> { "LNV4752", RFKILL_TYPE_GPS }, >>> + { "OBDA8723", RFKILL_TYPE_BLUETOOTH }, >>> { }, >>> }; >> >> NAK. We are integrating these with hci_bcm.c or hci_intel.c drivers. > > This is for the bluetooth side of the rtl8723bs driver which recently > (yesterday) got merged in into drivers/staging. Which still needs > hciattach from userspace. I completely agree that eventually we should > fix that. In the mean time it would be nice if we could carry this > one line patch to give people using the staging driver working bluetooth. why are Bluetooth drivers in staging? I objected to them before. The only reason to have them in staging would be people being to lazy to clean things up. Regards Marcel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Holtmann Subject: Re: [PATCH] net: rfkill: gpio: Add OBDA8723 ACPI HID Date: Sun, 9 Apr 2017 14:11:48 +0200 Message-ID: <0939E68A-DBF5-40BF-B83B-73AF234EB60B@holtmann.org> References: <20170408210520.2799-1-hdegoede@redhat.com> Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Cc: Johannes Berg , "David S. Miller" , linux-wireless , Network Development , russianneuromancer-k+OT61UuxXo@public.gmane.org, Greg Kroah-Hartman To: Hans de Goede Return-path: In-Reply-To: Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi Hans, >>> The OBDA8723 ACPI HID is used on quite a few Bay Trail based tablets >>> for bluetooth rfkill functionality. >>> >>> Tested-by: russianneuromancer-k+OT61UuxXo@public.gmane.org >>> Signed-off-by: Hans de Goede >>> --- >>> net/rfkill/rfkill-gpio.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c >>> index 76c01cb..50ca65e 100644 >>> --- a/net/rfkill/rfkill-gpio.c >>> +++ b/net/rfkill/rfkill-gpio.c >>> @@ -163,6 +163,7 @@ static int rfkill_gpio_remove(struct platform_device *pdev) >>> static const struct acpi_device_id rfkill_acpi_match[] = { >>> { "BCM4752", RFKILL_TYPE_GPS }, >>> { "LNV4752", RFKILL_TYPE_GPS }, >>> + { "OBDA8723", RFKILL_TYPE_BLUETOOTH }, >>> { }, >>> }; >> >> NAK. We are integrating these with hci_bcm.c or hci_intel.c drivers. > > This is for the bluetooth side of the rtl8723bs driver which recently > (yesterday) got merged in into drivers/staging. Which still needs > hciattach from userspace. I completely agree that eventually we should > fix that. In the mean time it would be nice if we could carry this > one line patch to give people using the staging driver working bluetooth. why are Bluetooth drivers in staging? I objected to them before. The only reason to have them in staging would be people being to lazy to clean things up. Regards Marcel