From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 488D6C10F13 for ; Tue, 16 Apr 2019 15:01:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C36620652 for ; Tue, 16 Apr 2019 15:01:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hszp8Rei" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729804AbfDPPBD (ORCPT ); Tue, 16 Apr 2019 11:01:03 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:32825 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726860AbfDPPBC (ORCPT ); Tue, 16 Apr 2019 11:01:02 -0400 Received: by mail-pf1-f193.google.com with SMTP id h5so10567666pfo.0 for ; Tue, 16 Apr 2019 08:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RBVkHzff2QHpWsULkbjmeYsG8UxofYyUUt2m2wDBECg=; b=Hszp8ReidWAoBpx2Zzue2y5eIsRRx1ROQUg5lyAv/G+QVEaujfh/ahyuxbAOdkM0Fb qWs9LdzlIj7OAIUMGxR6cbGi9iddeXEs3+lRr/miKHK7Ab/UfwASACHxOObc7J2AaPVS qfFtVjqp38qR+MwlxY9yvboRkomlltefBNuSrTWx/KVgHcxg8Odx7crgkl9FIvmgk8dO zg4db5J8uxIuS/3F3SlIsFwjFLDBrAvl8/EwPYVzJvwbYlblPkk/bb/blgtowf+n8+pp xBPEatTjqbMtVrqoMZQ6F5Bx9E6VRIV78K8pwDwnhQWOo286jQ7YAZ+76WFviRLZwdnQ Gi2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RBVkHzff2QHpWsULkbjmeYsG8UxofYyUUt2m2wDBECg=; b=MjqLim7cO7itOZo9wnHKRBtxrTQe/BT/dO5KvlQrnCH4/11HFJ3XBCtz3EvSJ8NUJD s9QgZJc38ktTud2COjnJ63RJmDEaAqZeuU/bXb1w1eYRlGTf6ztuyzz0COBUaU1aItKo 9XlMQR+UtOxfmIgt6oZEvIwFbt/jCxLjEtAFMxmODP3U20polsciJuj9xI1JwQ8xd/t2 32XndrbzPpIS0Id2ZdzjQAcK60M1OvIOjfQER73Hvy73nUoaieTpl+7bzifEHyg5bnFD gP96H0QusgF2DGHeHSMswaCY7iDlUAHURgSkxUwkQQ9xtXRqA3/voGh5cH0pJ/zuzUzA ocZg== X-Gm-Message-State: APjAAAVVJOvXBNyBTutXZKaqqO5WegwpRm0Jcg5p2y3R/WSa1YaFhZTi OF9ZS8dkeJLZNtr/o6wOVso= X-Google-Smtp-Source: APXvYqx6S3zK8fm2RyBOHDh2v77TWdbRBVQESUiUT4FBrKf9X2T1aLyhNYqh2s9iJ8BOiHbTIWdwWw== X-Received: by 2002:a62:61c2:: with SMTP id v185mr83678292pfb.117.1555426861496; Tue, 16 Apr 2019 08:01:01 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:14a8:cdd5:560c:a7cd? ([2601:282:800:fd80:14a8:cdd5:560c:a7cd]) by smtp.googlemail.com with ESMTPSA id f87sm114726207pff.56.2019.04.16.08.00.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Apr 2019 08:01:00 -0700 (PDT) Subject: Re: [PATCH net-next 12/13] ipv6: Pass fib6_result to fib lookups To: David Ahern , davem@davemloft.net, netdev@vger.kernel.org Cc: idosch@mellanox.com References: <20190416005652.29286-1-dsahern@kernel.org> <20190416005652.29286-13-dsahern@kernel.org> From: David Ahern Message-ID: <093ba6d7-dd65-0270-2eea-5760f7c7b013@gmail.com> Date: Tue, 16 Apr 2019 09:00:58 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190416005652.29286-13-dsahern@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/15/19 6:56 PM, David Ahern wrote: > @@ -182,14 +178,10 @@ static int fib6_rule_action_alt(struct fib_rule *rule, struct flowi *flp, > return -EAGAIN; > > oif = (int *)arg->lookup_data; > - f6i = fib6_table_lookup(net, table, *oif, flp6, flags); > - if (f6i != net->ipv6.fib6_null_entry) { > + err = fib6_table_lookup(net, table, *oif, flp6, res, flags); > + if (!err && res->f6i != net->ipv6.fib6_null_entry) > err = fib6_rule_saddr(net, rule, flags, flp6, > - fib6_info_nh_dev(f6i)); > - > - if (likely(!err)) > - arg->result = f6i; > - } > + fib6_info_nh_dev(res->f6i)); that is supposed to be res->nh, not fib6_info_nh_dev(res->f6i). Will fix and send a v2.