All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Dan Murphy <dmurphy@ti.com>, mkl@pengutronix.de, davem@davemloft.net
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/4] can: m_can: Rename m_can_priv to m_can_classdev
Date: Mon, 4 Mar 2019 18:31:51 +0100	[thread overview]
Message-ID: <093eb838-ab28-0bc0-8855-a8b22f3392b4@grandegger.com> (raw)
In-Reply-To: <20190301185043.9037-2-dmurphy@ti.com>

Hello,

there are still "LTL" after renaming m_can_priv to m_can_classdev.

Am 01.03.19 um 19:50 schrieb Dan Murphy:
> Rename the common m_can_priv class structure to
> m_can_classdev as this is more descriptive.

If you change the struct name, I think you should also change the
variable name to something more meaning full e.g.:

  struct m_can_classdev *cdev

instead of

  struct m_can_classdev *priv


... snip ...

Wolfgang.

  reply	other threads:[~2019-03-04 17:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-01 18:50 [PATCH v6 1/4] can: m_can: Create a m_can platform framework Dan Murphy
2019-03-01 18:50 ` Dan Murphy
2019-03-01 18:50 ` [PATCH v6 2/4] can: m_can: Rename m_can_priv to m_can_classdev Dan Murphy
2019-03-01 18:50   ` Dan Murphy
2019-03-04 17:31   ` Wolfgang Grandegger [this message]
2019-03-04 18:14     ` Dan Murphy
2019-03-04 18:14       ` Dan Murphy
2019-03-04 18:26       ` Wolfgang Grandegger
2019-03-01 18:50 ` [PATCH v6 3/4] dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver Dan Murphy
2019-03-01 18:50   ` Dan Murphy
2019-03-01 18:50 ` [PATCH v6 4/4] can: tcan4x5x: Add tcan4x5x driver to the kernel Dan Murphy
2019-03-01 18:50   ` Dan Murphy
2019-03-04 18:29   ` Wolfgang Grandegger
2019-03-04 19:07     ` Dan Murphy
2019-03-04 19:07       ` Dan Murphy
2019-03-04 19:33       ` Wolfgang Grandegger
2019-03-04 16:56 ` [PATCH v6 1/4] can: m_can: Create a m_can platform framework Wolfgang Grandegger
2019-03-04 17:22   ` Dan Murphy
2019-03-04 17:22     ` Dan Murphy
2019-03-04 18:13     ` Wolfgang Grandegger
2019-03-04 19:12       ` Dan Murphy
2019-03-04 19:12         ` Dan Murphy
2019-03-05  2:48         ` Joe Perches
2019-03-04 19:43   ` Dan Murphy
2019-03-04 19:43     ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=093eb838-ab28-0bc0-8855-a8b22f3392b4@grandegger.com \
    --to=wg@grandegger.com \
    --cc=davem@davemloft.net \
    --cc=dmurphy@ti.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.