From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D9A1C04AB6 for ; Fri, 31 May 2019 14:09:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 053D1269F8 for ; Fri, 31 May 2019 14:09:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k8RbPaR4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 053D1269F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:44167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWiE7-0001q6-69 for qemu-devel@archiver.kernel.org; Fri, 31 May 2019 10:09:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWhve-0004nq-Nz for qemu-devel@nongnu.org; Fri, 31 May 2019 09:50:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWhvc-0006h9-4L for qemu-devel@nongnu.org; Fri, 31 May 2019 09:50:41 -0400 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]:41624) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWhvb-0006fB-Ca for qemu-devel@nongnu.org; Fri, 31 May 2019 09:50:39 -0400 Received: by mail-ot1-x343.google.com with SMTP id 107so3413056otj.8 for ; Fri, 31 May 2019 06:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oz02ZVyW2AoAavGwCrFDgT1IRZ+x59RdqkMNwQemKik=; b=k8RbPaR4mGKywMQXlunQ7y45oKSGDKUVMPtH7HgkdlojWvhCZKNIfwy2h6b6OAKWMS uplSrP76dIC3auRiLMlqm9DGl3McG97p5TsKrpQYkQLQQBFJVqEi4xd+fBr41L1iv09d qAazWoE/ykZoSI5y6aXGFuF9bjYspeyLXuJEeMIubgb1j03a2Q1sBKxam0S+Kw1TIG+i B1wtXMLJSFD83ZjsAcTo1jlMKYcyFqDcIEyOD9ovK7vg6rPoCT6wN1ICMQrhWKDfxcVn JF1d82C71UeeQBiq5Tn0Mwq9V+KFP55o3+Ja5qm0EezStrPXlFsrnyd6FzudEQaGy2ki glZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oz02ZVyW2AoAavGwCrFDgT1IRZ+x59RdqkMNwQemKik=; b=j/TV8OUmV2t0s+aR+wdVyOYzOyYzUEkWCqoVM9NFrFOIVKLoBrAjsjoQK66NHx5TKd CI31Ou5BhYRoChJWq3+0skoWqkvyr7PYM+FMVlGIo+ex0em9mXhn61eIopsfOn4C6hlC HpjqFUzTLkt4M6UqogFRf3smgc6/7YfVEnEIuUVuHUEqMF5DgeffM8kx2Ye/WEfDAmUF PoRCn6dKs6+39c40rtXNReOmL5oXl069xLoc9ebNixmhJYj61I5Kz9XKEAkxFrsAL3vj wvy0DWMahrmkuF2kuefN+nrqj7GOTZbTCDzzAPw+Z6BJ48STUmcp5qGDmwqBTEty4bv5 4JEg== X-Gm-Message-State: APjAAAUMRD908fyvD3XnS1pimD0OmpONLxxTvvETU4M2+9q+qmSoMjET LZc580RaXlnmviAcyapnrmAUWg== X-Google-Smtp-Source: APXvYqynmD6HLFEiri0u7L5MpXrQtUAV9AVw/KKX2aIK4KBQ9mFhrwt4vie9H3dZNtoAi0B6nq0rQw== X-Received: by 2002:a9d:6481:: with SMTP id g1mr1861744otl.138.1559310637493; Fri, 31 May 2019 06:50:37 -0700 (PDT) Received: from [172.24.12.210] (168.189-204-159.bestelclientes.com.mx. [189.204.159.168]) by smtp.gmail.com with ESMTPSA id a31sm2207087otc.60.2019.05.31.06.50.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 May 2019 06:50:36 -0700 (PDT) To: Michael Rolnik , qemu-devel@nongnu.org References: <20190530190738.22713-1-mrolnik@gmail.com> <20190530190738.22713-3-mrolnik@gmail.com> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: <093ebd94-048a-4860-6917-60f78ecaefa1@linaro.org> Date: Fri, 31 May 2019 08:50:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190530190738.22713-3-mrolnik@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::343 Subject: Re: [Qemu-devel] [PATCH RFC v20 2/8] target/avr: Add instruction helpers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Harris , rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/30/19 2:07 PM, Michael Rolnik wrote: > From: Sarah Harris > > Stubs for unimplemented instructions and helpers for instructions that need to interact with QEMU. > SPM and WDR are unimplemented because they require emulation of complex peripherals. > The implementation of SLEEP is very limited due to the lack of peripherals to generate wake interrupts. > Memory access instructions are implemented here because some address ranges actually refer to CPU registers. > > Signed-off-by: Sarah Harris > Signed-off-by: Michael Rolnik > --- > target/avr/helper.c | 346 ++++++++++++++++++++++++++++++++++++++++++++ > target/avr/helper.h | 28 ++++ > 2 files changed, 374 insertions(+) > create mode 100644 target/avr/helper.c > create mode 100644 target/avr/helper.h Reviewed-by: Richard Henderson r~