All of lore.kernel.org
 help / color / mirror / Atom feed
* [linux-next:master 11067/14048] fs/io-wq.c:668:20: warning: unused function 'io_wqe_need_worker'
@ 2021-04-20 17:15 ` kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-04-20 17:15 UTC (permalink / raw)
  To: Jens Axboe; +Cc: kbuild-all, clang-built-linux, Linux Memory Management List

[-- Attachment #1: Type: text/plain, Size: 3889 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   593ef1658ecf61d3619885bdbbcfffa3d1417891
commit: 685fe7feedb96771683437107ba72131410e2350 [11067/14048] io-wq: eliminate the need for a manager thread
config: mips-randconfig-r023-20210420 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project ca8eef7e3da8f750d7c7aa004fe426d1d34787ea)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=685fe7feedb96771683437107ba72131410e2350
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 685fe7feedb96771683437107ba72131410e2350
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/io-wq.c:668:20: warning: unused function 'io_wqe_need_worker'
   static inline bool io_wqe_need_worker(struct io_wqe int index)
   ^
   fatal error: error in backend: Nested variants found in inline asm string: ' .set push
   .set mips64r2
   .if ( 0x00 ) != -1)) 0x00 ) != -1)) : ($( static struct ftrace_branch_data __attribute__((__aligned__(4))) __attribute__((__section__("_ftrace_branch"))) __if_trace = $( .func = __func__, .file = "arch/mips/include/asm/atomic.h", .line = 153, $); 0x00 ) != -1)) : $))) ) && ( 0 ); .set push; .set mips64r2; .rept 1; sync 0x00; .endr; .set pop; .else; ; .endif
   1: ll $0, $1 # atomic_add
   addu $0, $2
   sc $0, $1
   beqz $0, 1b
   .set pop
   '
   clang-13: error: clang frontend command failed with exit code 70 (use -v to see invocation)
   clang version 13.0.0 (git://gitmirror/llvm_project ca8eef7e3da8f750d7c7aa004fe426d1d34787ea)
   Target: mipsel-unknown-linux-gnu
   Thread model: posix
   InstalledDir: /opt/cross/clang-ca8eef7e3d/bin
   clang-13: note: diagnostic msg:
   Makefile arch block certs crypto drivers fs include init ipc kernel lib mm scripts security sound source usr virt


vim +/io_wqe_need_worker +668 fs/io-wq.c

771b53d033e866 Jens Axboe 2019-10-22  667  
c5def4ab849494 Jens Axboe 2019-11-07 @668  static inline bool io_wqe_need_worker(struct io_wqe *wqe, int index)
771b53d033e866 Jens Axboe 2019-10-22  669  	__must_hold(wqe->lock)
771b53d033e866 Jens Axboe 2019-10-22  670  {
c5def4ab849494 Jens Axboe 2019-11-07  671  	struct io_wqe_acct *acct = &wqe->acct[index];
771b53d033e866 Jens Axboe 2019-10-22  672  
613eeb600e3e63 Jens Axboe 2021-02-26  673  	if (acct->nr_workers && test_bit(IO_WQ_BIT_EXIT, &wqe->wq->state))
613eeb600e3e63 Jens Axboe 2021-02-26  674  		return false;
c5def4ab849494 Jens Axboe 2019-11-07  675  	/* if we have available workers or no work, no need */
021d1cdda3875b Jens Axboe 2019-11-14  676  	if (!hlist_nulls_empty(&wqe->free_list) || !io_wqe_run_queue(wqe))
771b53d033e866 Jens Axboe 2019-10-22  677  		return false;
c5def4ab849494 Jens Axboe 2019-11-07  678  	return acct->nr_workers < acct->max_workers;
771b53d033e866 Jens Axboe 2019-10-22  679  }
771b53d033e866 Jens Axboe 2019-10-22  680  

:::::: The code at line 668 was first introduced by commit
:::::: c5def4ab849494d3c97f6c9fc84b2ddb868fe78c io-wq: add support for bounded vs unbunded work

:::::: TO: Jens Axboe <axboe@kernel.dk>
:::::: CC: Jens Axboe <axboe@kernel.dk>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 18939 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [linux-next:master 11067/14048] fs/io-wq.c:668:20: warning: unused function 'io_wqe_need_worker'
@ 2021-04-20 17:15 ` kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-04-20 17:15 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3960 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   593ef1658ecf61d3619885bdbbcfffa3d1417891
commit: 685fe7feedb96771683437107ba72131410e2350 [11067/14048] io-wq: eliminate the need for a manager thread
config: mips-randconfig-r023-20210420 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project ca8eef7e3da8f750d7c7aa004fe426d1d34787ea)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=685fe7feedb96771683437107ba72131410e2350
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 685fe7feedb96771683437107ba72131410e2350
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/io-wq.c:668:20: warning: unused function 'io_wqe_need_worker'
   static inline bool io_wqe_need_worker(struct io_wqe int index)
   ^
   fatal error: error in backend: Nested variants found in inline asm string: ' .set push
   .set mips64r2
   .if ( 0x00 ) != -1)) 0x00 ) != -1)) : ($( static struct ftrace_branch_data __attribute__((__aligned__(4))) __attribute__((__section__("_ftrace_branch"))) __if_trace = $( .func = __func__, .file = "arch/mips/include/asm/atomic.h", .line = 153, $); 0x00 ) != -1)) : $))) ) && ( 0 ); .set push; .set mips64r2; .rept 1; sync 0x00; .endr; .set pop; .else; ; .endif
   1: ll $0, $1 # atomic_add
   addu $0, $2
   sc $0, $1
   beqz $0, 1b
   .set pop
   '
   clang-13: error: clang frontend command failed with exit code 70 (use -v to see invocation)
   clang version 13.0.0 (git://gitmirror/llvm_project ca8eef7e3da8f750d7c7aa004fe426d1d34787ea)
   Target: mipsel-unknown-linux-gnu
   Thread model: posix
   InstalledDir: /opt/cross/clang-ca8eef7e3d/bin
   clang-13: note: diagnostic msg:
   Makefile arch block certs crypto drivers fs include init ipc kernel lib mm scripts security sound source usr virt


vim +/io_wqe_need_worker +668 fs/io-wq.c

771b53d033e866 Jens Axboe 2019-10-22  667  
c5def4ab849494 Jens Axboe 2019-11-07 @668  static inline bool io_wqe_need_worker(struct io_wqe *wqe, int index)
771b53d033e866 Jens Axboe 2019-10-22  669  	__must_hold(wqe->lock)
771b53d033e866 Jens Axboe 2019-10-22  670  {
c5def4ab849494 Jens Axboe 2019-11-07  671  	struct io_wqe_acct *acct = &wqe->acct[index];
771b53d033e866 Jens Axboe 2019-10-22  672  
613eeb600e3e63 Jens Axboe 2021-02-26  673  	if (acct->nr_workers && test_bit(IO_WQ_BIT_EXIT, &wqe->wq->state))
613eeb600e3e63 Jens Axboe 2021-02-26  674  		return false;
c5def4ab849494 Jens Axboe 2019-11-07  675  	/* if we have available workers or no work, no need */
021d1cdda3875b Jens Axboe 2019-11-14  676  	if (!hlist_nulls_empty(&wqe->free_list) || !io_wqe_run_queue(wqe))
771b53d033e866 Jens Axboe 2019-10-22  677  		return false;
c5def4ab849494 Jens Axboe 2019-11-07  678  	return acct->nr_workers < acct->max_workers;
771b53d033e866 Jens Axboe 2019-10-22  679  }
771b53d033e866 Jens Axboe 2019-10-22  680  

:::::: The code at line 668 was first introduced by commit
:::::: c5def4ab849494d3c97f6c9fc84b2ddb868fe78c io-wq: add support for bounded vs unbunded work

:::::: TO: Jens Axboe <axboe@kernel.dk>
:::::: CC: Jens Axboe <axboe@kernel.dk>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 18939 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [linux-next:master 11067/14048] fs/io-wq.c:668:20: warning: unused function 'io_wqe_need_worker'
  2021-04-20 17:15 ` kernel test robot
@ 2021-04-20 17:25   ` Jens Axboe
  -1 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2021-04-20 17:25 UTC (permalink / raw)
  To: kernel test robot
  Cc: kbuild-all, clang-built-linux, Linux Memory Management List

On 4/20/21 11:15 AM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   593ef1658ecf61d3619885bdbbcfffa3d1417891
> commit: 685fe7feedb96771683437107ba72131410e2350 [11067/14048] io-wq: eliminate the need for a manager thread
> config: mips-randconfig-r023-20210420 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project ca8eef7e3da8f750d7c7aa004fe426d1d34787ea)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install mips cross compiling tool for clang build
>         # apt-get install binutils-mips-linux-gnu
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=685fe7feedb96771683437107ba72131410e2350
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 685fe7feedb96771683437107ba72131410e2350
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=mips 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>>> fs/io-wq.c:668:20: warning: unused function 'io_wqe_need_worker'
>    static inline bool io_wqe_need_worker(struct io_wqe int index)

Thanks, I queued up a patch to kill it.

-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [linux-next:master 11067/14048] fs/io-wq.c:668:20: warning: unused function 'io_wqe_need_worker'
@ 2021-04-20 17:25   ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2021-04-20 17:25 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1640 bytes --]

On 4/20/21 11:15 AM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   593ef1658ecf61d3619885bdbbcfffa3d1417891
> commit: 685fe7feedb96771683437107ba72131410e2350 [11067/14048] io-wq: eliminate the need for a manager thread
> config: mips-randconfig-r023-20210420 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project ca8eef7e3da8f750d7c7aa004fe426d1d34787ea)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install mips cross compiling tool for clang build
>         # apt-get install binutils-mips-linux-gnu
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=685fe7feedb96771683437107ba72131410e2350
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 685fe7feedb96771683437107ba72131410e2350
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=mips 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>>> fs/io-wq.c:668:20: warning: unused function 'io_wqe_need_worker'
>    static inline bool io_wqe_need_worker(struct io_wqe int index)

Thanks, I queued up a patch to kill it.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-04-20 17:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 17:15 [linux-next:master 11067/14048] fs/io-wq.c:668:20: warning: unused function 'io_wqe_need_worker' kernel test robot
2021-04-20 17:15 ` kernel test robot
2021-04-20 17:25 ` Jens Axboe
2021-04-20 17:25   ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.