From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAABBC2D0EA for ; Wed, 8 Apr 2020 12:16:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90F332074F for ; Wed, 8 Apr 2020 12:16:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y8pZsFsT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90F332074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jM9d0-00016f-Pr for qemu-devel@archiver.kernel.org; Wed, 08 Apr 2020 08:16:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34431) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jM9cM-0000be-Fg for qemu-devel@nongnu.org; Wed, 08 Apr 2020 08:15:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jM9cL-0006oH-H6 for qemu-devel@nongnu.org; Wed, 08 Apr 2020 08:15:42 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:41391 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jM9cL-0006o9-DU for qemu-devel@nongnu.org; Wed, 08 Apr 2020 08:15:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586348141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zStXtYSghfEOpZrS6kFfF+ee241g9iFj46McMoQq3S0=; b=Y8pZsFsTDqI2N+JDvYoXtM9l8s35nyUrJ8Gh+DleRZlROJUSQv/ivz/pOsQi/xGVrcMK06 wfK0XTF4qhFO8xLbzXFPiTieykyH09dETDvnpDYw0b5TXd0UECAIp32EIX6dAyGVY6QOmT Dd8SOAukAmRUNNY2VetgkNsdHO5l8GA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-20-TkHqgWB6MWmZNbgdMWx5DA-1; Wed, 08 Apr 2020 08:15:36 -0400 X-MC-Unique: TkHqgWB6MWmZNbgdMWx5DA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 36387800D4E; Wed, 8 Apr 2020 12:15:35 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-113-144.ams2.redhat.com [10.36.113.144]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AD1106EF88; Wed, 8 Apr 2020 12:15:31 +0000 (UTC) Subject: Re: [PATCH v4 14/30] qcow2: Add cluster type parameter to qcow2_get_host_offset() To: Alberto Garcia , qemu-devel@nongnu.org References: <348c0b057802b5b35eefe3dc7cc8ef2964024ed5.1584468723.git.berto@igalia.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <09421e90-1a43-7a13-bb01-5e6d3fa90c41@redhat.com> Date: Wed, 8 Apr 2020 14:15:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <348c0b057802b5b35eefe3dc7cc8ef2964024ed5.1584468723.git.berto@igalia.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HdW3bbfoiRgFU5pHAhtsFLzX778sirmgN" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Anton Nefedov , qemu-block@nongnu.org, Vladimir Sementsov-Ogievskiy , "Denis V . Lunev" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HdW3bbfoiRgFU5pHAhtsFLzX778sirmgN Content-Type: multipart/mixed; boundary="eFSjIG2qXPhEOlzZD8kGz8XdNVYkYDwrc" --eFSjIG2qXPhEOlzZD8kGz8XdNVYkYDwrc Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 17.03.20 19:16, Alberto Garcia wrote: > This function returns an integer that can be either an error code or a > cluster type (a value from the QCow2ClusterType enum). >=20 > We are going to start using subcluster types instead of cluster types > in some functions so it's better to use the exact data types instead > of integers for clarity and in order to detect errors more easily. >=20 > This patch makes qcow2_get_host_offset() return 0 on success and > puts the returned cluster type in a separate parameter. There are no > semantic changes. >=20 > Signed-off-by: Alberto Garcia > --- > block/qcow2.h | 3 ++- > block/qcow2-cluster.c | 11 +++++++---- > block/qcow2.c | 37 ++++++++++++++++++++++--------------- > 3 files changed, 31 insertions(+), 20 deletions(-) Reviewed-by: Max Reitz --eFSjIG2qXPhEOlzZD8kGz8XdNVYkYDwrc-- --HdW3bbfoiRgFU5pHAhtsFLzX778sirmgN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl6NwGEACgkQ9AfbAGHV z0A/DQf+J9wxZIgjdsp4Kd774PlvARqG9tR6bCTrC7fwq4E0dN4rBzpYwuil7dp0 tWkgXXjMDsVt+p+Go0xsvd28AF+yvqNityrMA9XHzQ9fMoo10DnQsLvIZIGNDqmd N1rTBYBdP7Ur8qLeJTOp+440NJUgzi401FWERwUWESyxwWYNXDl3FT7vuLQlAPnS KAewnadT/nU/L5GMso83f+AcD+q3aJGB46sQhr9cTws9sMvViQsx0pC3uO4jRn2J aeSZA+SYD/T+LILv8PW8nRrjRlef1loru3FlbfwbfWrOqhHiZ6W+4O7i4hTkwqMJ jN6urVnZ+NPfS4AX0h2nrWZToSXtoA== =RFeA -----END PGP SIGNATURE----- --HdW3bbfoiRgFU5pHAhtsFLzX778sirmgN--