All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Marat Khalili <mkh@rqc.ru>, Nikolay Borisov <nborisov@suse.com>,
	"Misono, Tomohiro" <misono.tomohiro@jp.fujitsu.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds
Date: Mon, 25 Sep 2017 15:46:15 +0800	[thread overview]
Message-ID: <095397b6-4865-1ea3-ae0d-6725b84c447c@gmx.com> (raw)
In-Reply-To: <b1b5a231-ffc3-700b-b59d-e82accf2f2e7@rqc.ru>



On 2017年09月25日 15:42, Marat Khalili wrote:
> On 25/09/17 10:30, Nikolay Borisov wrote:
>> On 19.09.2017 10:41, Misono, Tomohiro wrote:
>>> "btrfs subvolume create/delete" outputs the message of "Create/Delete
>>> subvolume ..." even when an operation fails.
>>> Since it is confusing, let's outputs the message only when an 
>>> operation succeeds.
>> Please change the verb to past tense, more strongly signaling success -
>> i.e. "Created subvolume"
> What about recalling some UNIX standards and returning to NOT outputting 
> any message when operation succeeds? My scripts are full of grep -v 
> calls after each btrfs command, and this sucks (and I don't think I'm 
> alone in this situation).

Isn't the correct way to catch the return value instead of grepping the 
output?

If it's some command not returning value properly, would you please 
report it as a bug so we can fix it.

Thanks,
Qu

> If you change the message a lot of scripts 
> will have to be changed, at least make it worth it.
> 
>   --
> 
> With Best Regards,
> Marat Khaliili
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-09-25  7:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19  7:41 [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds Misono, Tomohiro
2017-09-20  2:32 ` Satoru Takeuchi
2017-09-25  7:30 ` Nikolay Borisov
2017-09-25  7:42   ` Marat Khalili
2017-09-25  7:43     ` Hugo Mills
2017-09-25  7:46     ` Qu Wenruo [this message]
2017-09-25  7:52       ` Hugo Mills
2017-09-25  8:04         ` Qu Wenruo
2017-09-25  8:08           ` Qu Wenruo
2017-09-25  9:27             ` Marat Khalili
2017-09-25 14:19           ` Hugo Mills
2017-09-25 14:33             ` Qu Wenruo
2017-09-25 15:17               ` Marat Khalili
2017-09-25 16:11                 ` Wrong device? linux-btrfs
2017-09-26  7:31                   ` Lukas Pirl
2017-09-27 14:06                     ` Andrei Borzenkov
2017-09-26  8:06                   ` Duncan
2017-09-27  8:26                     ` Ari Saastamoinen
2017-09-25  9:11         ` [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds Marat Khalili

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=095397b6-4865-1ea3-ae0d-6725b84c447c@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=misono.tomohiro@jp.fujitsu.com \
    --cc=mkh@rqc.ru \
    --cc=nborisov@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.