From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: "Michel Dänzer" <michel@daenzer.net>,
"Christian König" <christian.koenig@amd.com>,
"Nayan Deshmukh" <nayan26deshmukh@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/scheduler: remove timeout work_struct from drm_sched_job
Date: Thu, 20 Sep 2018 08:41:03 +0200 [thread overview]
Message-ID: <09645cbc-2ca4-73f3-d80f-b5ca3bef2a97@gmail.com> (raw)
In-Reply-To: <5717830f-2464-b7d5-f673-a46bc80613e6@daenzer.net>
Am 19.09.2018 um 17:39 schrieb Michel Dänzer:
> On 2018-09-19 2:30 p.m., Christian König wrote:
>> Am 18.09.2018 um 18:17 schrieb Nayan Deshmukh:
>>> having a delayed work item per job is redundant as we only need one
>>> per scheduler to track the time out the currently executing job.
>> Well that looks simpler than I thought it would be.
>>
>> But it shows the next problem that the timeout and the completion could
>> race.
>>
>> As far as I can see that can be fixed by moving the
>> dma_fence_remove_callback()/dma_fence_add_callback() dance from
>> drm_sched_hw_job_reset() to drm_sched_job_timedout().
> BTW, while you guys are looking into this code, please keep an eye open
> for things that could explain https://bugs.freedesktop.org/107762 .
Yeah, since we now have only one timer that should be fixed by this as well.
Christian.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-09-20 6:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 16:17 [PATCH 1/2] drm/scheduler: add a current job field to scheduler Nayan Deshmukh
2018-09-18 16:17 ` [PATCH 2/2] drm/scheduler: remove timeout work_struct from drm_sched_job Nayan Deshmukh
2018-09-19 12:30 ` Christian König
2018-09-19 15:39 ` Michel Dänzer
2018-09-20 6:41 ` Christian König [this message]
2018-09-20 11:25 ` Nayan Deshmukh
2018-09-20 11:30 ` Christian König
2018-09-18 17:09 ` [PATCH 1/2] drm/scheduler: add a current job field to scheduler Koenig, Christian
2018-09-18 23:13 ` Nayan Deshmukh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09645cbc-2ca4-73f3-d80f-b5ca3bef2a97@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=michel@daenzer.net \
--cc=nayan26deshmukh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.