From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs: fixes for subpage which also affect read-only mount
Date: Tue, 16 Mar 2021 08:29:35 +0800 [thread overview]
Message-ID: <09680ea1-12c1-eb0e-b3fb-08caff760b04@gmx.com> (raw)
In-Reply-To: <20210315154205.GX7604@twin.jikos.cz>
On 2021/3/15 下午11:42, David Sterba wrote:
> On Mon, Mar 15, 2021 at 01:39:13PM +0800, Qu Wenruo wrote:
>> During the fstests run for btrfs subpage read-write support, generic/475
>> crashes the system with a very high chance.
>>
>> It turns out the cause is also affecting btrfs subpage read-only mount
>> so it's worthy a quick fix.
>>
>> Also the crash call site shows a new rabbit hole of hard coded
>> PAGE_SHIFT in readahead.
>
> There's still a lot of PAGE_SHIFT use, not all of them are wrong but I
> think we'll need to do an audit and categorize the valid uses, otherwise
> it'll be a whack-a-mole.
>
Already did that.
The current valid use case for PAGE_SHIFT are:
- Grab page
Including:
* compression
* raid56
* relocation
* buffered write in file.c
* sb cross page check in volumes.c
* send
* zoned
* sb rw in disk-io.c
* tree csum in disk-io.c
* free space cache v1
- Some legacy code still runs in full page mode
Including:
* defrag
- Verification code
That part has way more hardcoded part to be addressed.
Will be addressed in the final part, along with selftest enhancement.
Although there can be something missing, I believe it shouldn't be that
hard to hit during fstests then.
Thanks,
Qu
next prev parent reply other threads:[~2021-03-16 0:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 5:39 [PATCH 0/2] btrfs: fixes for subpage which also affect read-only mount Qu Wenruo
2021-03-15 5:39 ` [PATCH 1/2] btrfs: fix wild pointer access during metadata read failure for subpage Qu Wenruo
2021-03-15 7:55 ` Johannes Thumshirn
2021-03-15 8:25 ` Qu Wenruo
2021-03-15 18:51 ` David Sterba
2021-03-16 0:03 ` Qu Wenruo
2021-03-15 5:39 ` [PATCH 2/2] btrfs: make reada to be subpage compatible Qu Wenruo
2021-03-15 9:39 ` Johannes Thumshirn
2021-03-15 15:42 ` [PATCH 0/2] btrfs: fixes for subpage which also affect read-only mount David Sterba
2021-03-16 0:29 ` Qu Wenruo [this message]
2021-03-16 10:08 ` David Sterba
2021-03-16 10:15 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09680ea1-12c1-eb0e-b3fb-08caff760b04@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.