From: Arnout Vandecappelle <arnout@mind.be>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/jpeg: SIMD needs VSX with little endian
Date: Tue, 23 Aug 2022 22:58:46 +0200 [thread overview]
Message-ID: <09686b20-b8ca-d698-7416-f24a8c01a376@mind.be> (raw)
In-Reply-To: <20220607202828.1130778-1-fontaine.fabrice@gmail.com>
On 07/06/2022 22:28, Fabrice Fontaine wrote:
> SIMD needs VSX with little endian to avoid the following build failure:
>
> In file included from /nvmedata/autobuild/instance-12/output-1/build/jpeg-turbo-2.1.3/simd/powerpc/jccolor-altivec.c:25:
> /nvmedata/autobuild/instance-12/output-1/build/jpeg-turbo-2.1.3/simd/powerpc/jccolext-altivec.c: In function 'jsimd_rgb_ycc_convert_altivec':
> /nvmedata/autobuild/instance-12/output-1/build/jpeg-turbo-2.1.3/simd/powerpc/jsimd_altivec.h:93:26: warning: implicit declaration of function 'vec_vsx_ld'; did you mean 'vec_vsl'? [-Wimplicit-function-declaration]
> 93 | #define VEC_LD(a, b) vec_vsx_ld(a, b)
> | ^~~~~~~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/be6d5ad0cee4ee19eb25e595d44555a1af6e073b
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Arnout
> ---
> package/jpeg/Config.in | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/jpeg/Config.in b/package/jpeg/Config.in
> index 0a786060d7..371f89aa49 100644
> --- a/package/jpeg/Config.in
> +++ b/package/jpeg/Config.in
> @@ -3,7 +3,8 @@ config BR2_PACKAGE_JPEG_SIMD_SUPPORT
> bool
> default y if BR2_X86_CPU_HAS_MMX
> default y if BR2_ARM_CPU_HAS_NEON
> - default y if BR2_POWERPC_CPU_HAS_ALTIVEC
> + default y if BR2_POWERPC_CPU_HAS_ALTIVEC && !BR2_powerpc64le
> + default y if BR2_POWERPC_CPU_HAS_VSX && BR2_powerpc64le
> default y if BR2_aarch64 || BR2_aarch64_be
>
> config BR2_PACKAGE_JPEG
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-23 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 20:28 [Buildroot] [PATCH 1/1] package/jpeg: SIMD needs VSX with little endian Fabrice Fontaine
2022-08-23 20:58 ` Arnout Vandecappelle [this message]
2022-09-17 12:25 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09686b20-b8ca-d698-7416-f24a8c01a376@mind.be \
--to=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.