From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F35C282C3 for ; Tue, 22 Jan 2019 10:06:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAB7C20844 for ; Tue, 22 Jan 2019 10:06:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="03VFQG8r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727684AbfAVKGC (ORCPT ); Tue, 22 Jan 2019 05:06:02 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:47063 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727502AbfAVKGC (ORCPT ); Tue, 22 Jan 2019 05:06:02 -0500 Received: by mail-lf1-f67.google.com with SMTP id y14so17583415lfg.13 for ; Tue, 22 Jan 2019 02:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uH5ZHmN8JiyEactOZiT1ZYL3x44vrMcAK6LcTxgAKMQ=; b=03VFQG8raukx5sSnlL6Q4iBFUnSiIAyhESFb30xf2z5Wwsdef9mXGGualVrQy4djDk RK/L6NGLER/B94ZTxUY4Op5XShknqM+jnWM6lYpF+8ZM8jvaB9Qu5ir9q3QHJvpKzUBe froPTbVeUbN3e9nouRkLRFkH38XXsSFE60PYhXMV85dedkWuTo7G2Fs5BK5FjIY2U8RU A2nfxA7ZpaBUPfxdqtwkF44SHEG/6ntYlfm+JhI/P8vFXKwhMVTK06i/zvhhB6xJQMcQ exuuEBgLxPUc3TOKk/TtH2/318lTlCtg+DNiMw2V2m5I0OLfiHjxG9PBvrW7dCTQiqyH 9nzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=uH5ZHmN8JiyEactOZiT1ZYL3x44vrMcAK6LcTxgAKMQ=; b=KVAmvS1j0A8ejMe0Ag6YXBAEpgl0uLo2OUUbhudXxm1Bg3BegMyoq+5En0qZoaqsio 82L7IrAy+17naErPYd8LETSJDCe2f757A0dVOw+RaVV1jDmjoG3cb8OItjBo+3Qwwq1e mCRJC6oPyHBsJdaqceQAfYdIXcpB14gOQ68X+m9GX3yA+punPCV6keVG7FrR+vWSfAHR bJLdsY6nM+NZRCXBh7szwIf/VIeZHhEEoNTJh0vMTqYmnQPdeVc6qUy3KKz7HTn8tN7i 3jeQoY77pHf+kLS7ajY101D4Sb/7lpMPbMtqyDqzn6vbwE+AaXBvMJ8UVZb0g5jy22Xt uCYQ== X-Gm-Message-State: AJcUuke1nju5NyMRT3tYlUPhZcrBZKvPvsvjRHwj1Qog2Alp/w6Rb/fv dMthZ8MWCYPj//X0G4+i+9OKKFVBKbI= X-Google-Smtp-Source: ALg8bN4Lly3FCyaReMfTRS/2eMGLrALCszR/39rTkUUZnRzVxQvQ/ZyzZDBlMUsJBj3e3XaUq00AFw== X-Received: by 2002:a19:910d:: with SMTP id t13mr19406650lfd.98.1548151559941; Tue, 22 Jan 2019 02:05:59 -0800 (PST) Received: from wasted.cogentembedded.com ([31.173.82.69]) by smtp.gmail.com with ESMTPSA id q2sm2881482lfa.63.2019.01.22.02.05.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jan 2019 02:05:59 -0800 (PST) Subject: Re: [PATCH net-next 3/4] ip_tunnel: Fix route fl4 init in ip_md_tunnel_xmit To: wenxu@ucloud.cn, davem@davemloft.net Cc: netdev@vger.kernel.org References: <1548149964-21299-1-git-send-email-wenxu@ucloud.cn> <1548149964-21299-4-git-send-email-wenxu@ucloud.cn> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <097141b6-3a3c-c05a-1e3e-6556f255d83d@cogentembedded.com> Date: Tue, 22 Jan 2019 13:05:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1548149964-21299-4-git-send-email-wenxu@ucloud.cn> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello! On 01/22/2019 12:39 PM, wenxu@ucloud.cn wrote: > From: wenxu > > Init the gre_key from tuninfo->key.tun_id and init the mark > from the skb->mark, set the oif zero in the collect metadata mode > > Fixes: cfc7381 ("ip_tunnel: add collect_md mode to IPIP tunnel'") Need 12 digits for the commit ID. And why that apostrophe at the end of summary? > Signed-off-by: wenxu [...] MBR, Sergei