All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Lorenzo Bianconi" <lorenzo.bianconi@redhat.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	kyan@google.com
Subject: Re: [PATCH mac80211-next] mac80211: introduce aql_enable node in debugfs
Date: Mon, 04 Jan 2021 14:54:17 +0100	[thread overview]
Message-ID: <097b8ea0c643c8372f1a57499969d7a96b1542bd.camel@sipsolutions.net> (raw)
In-Reply-To: <87pn2k4xw1.fsf@toke.dk>

On Mon, 2021-01-04 at 14:47 +0100, Toke Høiland-Jørgensen wrote:
> Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes:
> 
> > > Lorenzo Bianconi <lorenzo@kernel.org> writes:
> > > 
> > > > Introduce aql_enable node in debugfs in order to enable/disable aql.
> > > > This is useful for debugging purpose.
> > > 
> > > Don't mind having a switch, although I wonder if it would be better to
> > > overload the existing debugfs file (e.g., a threshold of 0 could disable
> > > everything?) so as not to clutter up debugfs too much?
> > > 
> > > -Toke
> > > 
> > 
> > You mean to consider 0 as a special value to disable aql, right? I
> > would prefer to have a dedicated switch for it since I guess it is
> > clearer for users (but I can live with it :) )
> 
> Yeah, maybe a bit clearer but at the cost of clutter. I dunno, not a
> strong preference either way; I guess Johannes can make the call :)

I'm not sure I care about an extra debugfs file - but I do wonder about
the extra check at runtime that would basically never be true since the
default is enable ...

Maybe that should use a static_branch() or something?

johannes


      reply	other threads:[~2021-01-04 13:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-26  9:49 [PATCH mac80211-next] mac80211: introduce aql_enable node in debugfs Lorenzo Bianconi
2021-01-04 12:15 ` Toke Høiland-Jørgensen
2021-01-04 13:20   ` Lorenzo Bianconi
2021-01-04 13:47     ` Toke Høiland-Jørgensen
2021-01-04 13:54       ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=097b8ea0c643c8372f1a57499969d7a96b1542bd.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=kyan@google.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=lorenzo@kernel.org \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.