From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDE28C64E7C for ; Wed, 2 Dec 2020 14:38:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 810BB21D7F for ; Wed, 2 Dec 2020 14:38:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728942AbgLBOiX (ORCPT ); Wed, 2 Dec 2020 09:38:23 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.52]:12148 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727975AbgLBOiX (ORCPT ); Wed, 2 Dec 2020 09:38:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1606919731; s=strato-dkim-0002; d=hartkopp.net; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=AVuvWDbV/9+ouZdVUaYVWFIK1W5CysnFx9kN3a4DlG4=; b=WVMfpVMDnHz3in9gx0erNCg9nGzRmfq3jbIKhthbVaDTwXmz353UGVD2vCXStPZTuG VUrgWgOjnuIrkFDA2+PzPRefNiCkhXUb+JX0n8QimDnrOu9Tjx99L1OUgazZZ3I/ikCc rJ5gkIHnJj2yKE1LKvywgUqMXWpmhJ33umAWiObyc8TuMpTGIZDQcGLzzAQM8pD+saxV PyG50Zu6o1bGI6HGKanLLiXaBOI5ZmcjLDhR3EZuBgiojlKOaNxGxEOcVEuvCleEcjKg Iw5eZoS5sUf1wr2Mafan/KiteAC5Yl383fFUOfRR2LG5Y6nNRT2DyRt7CBc9clJDYh5u BC8g== X-RZG-AUTH: ":P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrDxb8mjG14FZxedJy6qgO1o3TMaFqTGV1iO89vpw==" X-RZG-CLASS-ID: mo00 Received: from [192.168.10.177] by smtp.strato.de (RZmta 47.3.4 DYNA|AUTH) with ESMTPSA id n07f3bwB2EZMC8u (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 2 Dec 2020 15:35:22 +0100 (CET) Subject: Re: [PATCH] can: don't count arbitration lose as an error To: Jeroen Hofstee , Marc Kleine-Budde , linux-can@vger.kernel.org Cc: Chen-Yu Tsai , Jernej Skrabec , "open list:NETWORKING DRIVERS" , "moderated list:ARM/Allwinner sunXi SoC support" References: <20201127095941.21609-1-jhofstee@victronenergy.com> <434167b4-c2df-02bf-8a9c-2d4716c5435f@pengutronix.de> From: Oliver Hartkopp Message-ID: <0988dd09-70d9-3ee8-9945-10c4dea49407@hartkopp.net> Date: Wed, 2 Dec 2020 15:35:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org Hi Jeroen, On 27.11.20 12:09, Jeroen Hofstee wrote: > On 11/27/20 11:30 AM, Marc Kleine-Budde wrote: >> On 11/27/20 10:59 AM, Jeroen Hofstee wrote: >>> Losing arbitration is normal in a CAN-bus network, it means that a >>> higher priority frame is being send and the pending message will be >>> retried later. Hence most driver only increment arbitration_lost, but >>> the sja1000 and sun4i driver also incremeant tx_error, causing errors >>> to be reported on a normal functioning CAN-bus. So stop counting them >>> as errors. >> Sounds plausible. >> >>> For completeness, the Kvaser USB hybra also increments the tx_error >>> on arbitration lose, but it does so in single shot. Since in that >>> case the message is not retried, that behaviour is kept. >> You mean only in one shot mode? > > Yes, well at least the function is called kvaser_usb_hydra_one_shot_fail. > > >>   What about one shot mode on the sja1000 cores? > > > That is a good question. I guess it will be counted as error by: > >         if (isrc & IRQ_TI) { >             /* transmission buffer released */ >             if (priv->can.ctrlmode & CAN_CTRLMODE_ONE_SHOT && >                 !(status & SR_TCS)) { >                 stats->tx_errors++; I can confirm with CAN_CTRLMODE_ONE_SHOT active and the patch ("can: sja1000: sja1000_err(): don't count arbitration lose as an error") https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/commit/?h=testing&id=bd0ccb92efb09c7da5b55162b283b42a93539ed7 I now get ONE(!) increment for tx_errors and ONE increment in the arbitration-lost counter. Before the above patch I had TWO tx_errors for each arbitration lost case. >                 can_free_echo_skb(dev, 0); >             } else { >                 /* transmission complete */ >                 stats->tx_bytes += >                     priv->read_reg(priv, SJA1000_FI) & 0xf; >                 stats->tx_packets++; >                 can_get_echo_skb(dev, 0); >             } >             netif_wake_queue(dev); >             can_led_event(dev, CAN_LED_EVENT_TX); >         } > > From the datasheet, Transmit Interrupt: > > "set; this bit is set whenever the transmit bufferstatus > changes from ‘0-to-1’ (released) and the TIE bit is set > within the interrupt enable register". > > I cannot test it though, since I don't have a sja1000. Do we agree that in one-shot mode both the tx_errors and the arbitration_lost counters are increased in the arbitration-lost case? At least this would fit to the Kvaser USB behaviour. And btw. I wondered if we should remove the check for CAN_CTRLMODE_ONE_SHOT here, as we ALWAYS should count a tx_error and drop the echo_skb when we have a TX-interrupt and TX-complete flag is zero. So replace: if (priv->can.ctrlmode & CAN_CTRLMODE_ONE_SHOT && !(status & SR_TCS)) { with: if (!(status & SR_TCS)) { Any suggestions? Best regards, Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60F2DC64E7C for ; Wed, 2 Dec 2020 14:39:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3AE621D7F for ; Wed, 2 Dec 2020 14:39:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3AE621D7F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hartkopp.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Oep/mgHlG+cLixW0hGPUF8qeHBwtRg2S/TYTLIumRiY=; b=wDrVnGkwRCuNAddoQ0qc7gpT6 yRwUTE00rVapfHdfO76s8b0RsxC37pd2GibeHSYXIBIDrY/JXZ+NmGEze1MR0gQW47LP2uhshNKBZ FxDeH1Fd0wa2chbWXSyJc1SAcci+UF510nsgBosG9T6F7D2t4n86FELybCvwk2T4Z4rhdMg+YAKIL +45G90NAQyDf2kFRLUlSFq1ikbXrwRCBkO2CVLzosg/Gng4/DzJJo/WgquaJ0mcF6Ag8iijHCfv31 Zy9UDVt+iwChT/l5EIMysRILO3eUBKvkrmkdyUNzQ9AWuG+LBfNTP5GoxuF/VZTbpFP1NtercXJmi tqKmszTRA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkTH3-0000nu-Mv; Wed, 02 Dec 2020 14:38:29 +0000 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.167]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkTH1-0000mZ-3B for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 14:38:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1606919903; s=strato-dkim-0002; d=hartkopp.net; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=AVuvWDbV/9+ouZdVUaYVWFIK1W5CysnFx9kN3a4DlG4=; b=tx1VOp1GCZmq/W3f+GtU4+mHJgMx6k6WN68BPT4qxGFfexn7lp28nZ2AR4ZwtoScJS 9z3c3SSrVkCtiXYp40jnnf0jwCQjMGo+6IQWyTLXChnfb/hpen8ofmqXAeZpvvgicm6D 59mBoCcQbjlYpsWOjT6c3p81PCNIRFMvrN/XYMyl0TETQr2R71JLicn6hJI7XAAN9Qn/ eH6iBeCJojNJdSTwTKeozQk4HdwlBwHWAsmeucSf1WXKA7LvXbfvGSIOn7+nQfeQXfBF 0FHhqN+EDXmxTj16aHL3WPfnN82Kg/uz9WG63eEbxzAqWuG/rjsxEtSr2P0ZQRUZSXew FLSQ== X-RZG-AUTH: ":P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrDxb8mjG14FZxedJy6qgO1o3TMaFqTGV1iO89vpw==" X-RZG-CLASS-ID: mo00 Received: from [192.168.10.177] by smtp.strato.de (RZmta 47.3.4 DYNA|AUTH) with ESMTPSA id n07f3bwB2EZMC8u (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 2 Dec 2020 15:35:22 +0100 (CET) Subject: Re: [PATCH] can: don't count arbitration lose as an error To: Jeroen Hofstee , Marc Kleine-Budde , linux-can@vger.kernel.org References: <20201127095941.21609-1-jhofstee@victronenergy.com> <434167b4-c2df-02bf-8a9c-2d4716c5435f@pengutronix.de> From: Oliver Hartkopp Message-ID: <0988dd09-70d9-3ee8-9945-10c4dea49407@hartkopp.net> Date: Wed, 2 Dec 2020 15:35:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_093827_274370_A7F708D1 X-CRM114-Status: GOOD ( 20.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:NETWORKING DRIVERS" , Chen-Yu Tsai , Jernej Skrabec , "moderated list:ARM/Allwinner sunXi SoC support" Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmVyb2VuLAoKT24gMjcuMTEuMjAgMTI6MDksIEplcm9lbiBIb2ZzdGVlIHdyb3RlOgo+IE9u IDExLzI3LzIwIDExOjMwIEFNLCBNYXJjIEtsZWluZS1CdWRkZSB3cm90ZToKPj4gT24gMTEvMjcv MjAgMTA6NTkgQU0sIEplcm9lbiBIb2ZzdGVlIHdyb3RlOgo+Pj4gTG9zaW5nIGFyYml0cmF0aW9u IGlzIG5vcm1hbCBpbiBhIENBTi1idXMgbmV0d29yaywgaXQgbWVhbnMgdGhhdCBhCj4+PiBoaWdo ZXIgcHJpb3JpdHkgZnJhbWUgaXMgYmVpbmcgc2VuZCBhbmQgdGhlIHBlbmRpbmcgbWVzc2FnZSB3 aWxsIGJlCj4+PiByZXRyaWVkIGxhdGVyLiBIZW5jZSBtb3N0IGRyaXZlciBvbmx5IGluY3JlbWVu dCBhcmJpdHJhdGlvbl9sb3N0LCBidXQKPj4+IHRoZSBzamExMDAwIGFuZCBzdW40aSBkcml2ZXIg YWxzbyBpbmNyZW1lYW50IHR4X2Vycm9yLCBjYXVzaW5nIGVycm9ycwo+Pj4gdG8gYmUgcmVwb3J0 ZWQgb24gYSBub3JtYWwgZnVuY3Rpb25pbmcgQ0FOLWJ1cy4gU28gc3RvcCBjb3VudGluZyB0aGVt Cj4+PiBhcyBlcnJvcnMuCj4+IFNvdW5kcyBwbGF1c2libGUuCj4+Cj4+PiBGb3IgY29tcGxldGVu ZXNzLCB0aGUgS3Zhc2VyIFVTQiBoeWJyYSBhbHNvIGluY3JlbWVudHMgdGhlIHR4X2Vycm9yCj4+ PiBvbiBhcmJpdHJhdGlvbiBsb3NlLCBidXQgaXQgZG9lcyBzbyBpbiBzaW5nbGUgc2hvdC4gU2lu Y2UgaW4gdGhhdAo+Pj4gY2FzZSB0aGUgbWVzc2FnZSBpcyBub3QgcmV0cmllZCwgdGhhdCBiZWhh dmlvdXIgaXMga2VwdC4KPj4gWW91IG1lYW4gb25seSBpbiBvbmUgc2hvdCBtb2RlPwo+IAo+IFll cywgd2VsbCBhdCBsZWFzdCB0aGUgZnVuY3Rpb24gaXMgY2FsbGVkIGt2YXNlcl91c2JfaHlkcmFf b25lX3Nob3RfZmFpbC4KPiAKPiAKPj4gwqAgV2hhdCBhYm91dCBvbmUgc2hvdCBtb2RlIG9uIHRo ZSBzamExMDAwIGNvcmVzPwo+IAo+IAo+IFRoYXQgaXMgYSBnb29kIHF1ZXN0aW9uLiBJIGd1ZXNz IGl0IHdpbGwgYmUgY291bnRlZCBhcyBlcnJvciBieToKPiAKPiAgwqDCoMKgIMKgwqDCoCBpZiAo aXNyYyAmIElSUV9USSkgewo+ICDCoMKgwqAgwqDCoMKgIMKgwqDCoCAvKiB0cmFuc21pc3Npb24g YnVmZmVyIHJlbGVhc2VkICovCj4gIMKgwqDCoCDCoMKgwqAgwqDCoMKgIGlmIChwcml2LT5jYW4u Y3RybG1vZGUgJiBDQU5fQ1RSTE1PREVfT05FX1NIT1QgJiYKPiAgwqDCoMKgIMKgwqDCoCDCoMKg wqAgwqDCoMKgICEoc3RhdHVzICYgU1JfVENTKSkgewo+ICDCoMKgwqAgwqDCoMKgIMKgwqDCoCDC oMKgwqAgc3RhdHMtPnR4X2Vycm9ycysrOwoKSSBjYW4gY29uZmlybSB3aXRoIENBTl9DVFJMTU9E RV9PTkVfU0hPVCBhY3RpdmUgYW5kIHRoZSBwYXRjaCAoImNhbjogCnNqYTEwMDA6IHNqYTEwMDBf ZXJyKCk6IGRvbid0IGNvdW50IGFyYml0cmF0aW9uIGxvc2UgYXMgYW4gZXJyb3IiKQoKaHR0cHM6 Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvbWtsL2xpbnV4LWNhbi5n aXQvY29tbWl0Lz9oPXRlc3RpbmcmaWQ9YmQwY2NiOTJlZmIwOWM3ZGE1YjU1MTYyYjI4M2I0MmE5 MzUzOWVkNwoKSSBub3cgZ2V0IE9ORSghKSBpbmNyZW1lbnQgZm9yIHR4X2Vycm9ycyBhbmQgT05F IGluY3JlbWVudCBpbiB0aGUgCmFyYml0cmF0aW9uLWxvc3QgY291bnRlci4KCkJlZm9yZSB0aGUg YWJvdmUgcGF0Y2ggSSBoYWQgVFdPIHR4X2Vycm9ycyBmb3IgZWFjaCBhcmJpdHJhdGlvbiBsb3N0 IGNhc2UuCgo+ICDCoMKgwqAgwqDCoMKgIMKgwqDCoCDCoMKgwqAgY2FuX2ZyZWVfZWNob19za2Io ZGV2LCAwKTsKPiAgwqDCoMKgIMKgwqDCoCDCoMKgwqAgfSBlbHNlIHsKPiAgwqDCoMKgIMKgwqDC oCDCoMKgwqAgwqDCoMKgIC8qIHRyYW5zbWlzc2lvbiBjb21wbGV0ZSAqLwo+ICDCoMKgwqAgwqDC oMKgIMKgwqDCoCDCoMKgwqAgc3RhdHMtPnR4X2J5dGVzICs9Cj4gIMKgwqDCoCDCoMKgwqAgwqDC oMKgIMKgwqDCoCDCoMKgwqAgcHJpdi0+cmVhZF9yZWcocHJpdiwgU0pBMTAwMF9GSSkgJiAweGY7 Cj4gIMKgwqDCoCDCoMKgwqAgwqDCoMKgIMKgwqDCoCBzdGF0cy0+dHhfcGFja2V0cysrOwo+ICDC oMKgwqAgwqDCoMKgIMKgwqDCoCDCoMKgwqAgY2FuX2dldF9lY2hvX3NrYihkZXYsIDApOwo+ICDC oMKgwqAgwqDCoMKgIMKgwqDCoCB9Cj4gIMKgwqDCoCDCoMKgwqAgwqDCoMKgIG5ldGlmX3dha2Vf cXVldWUoZGV2KTsKPiAgwqDCoMKgIMKgwqDCoCDCoMKgwqAgY2FuX2xlZF9ldmVudChkZXYsIENB Tl9MRURfRVZFTlRfVFgpOwo+ICDCoMKgwqAgwqDCoMKgIH0KPiAKPiAgRnJvbSB0aGUgZGF0YXNo ZWV0LCBUcmFuc21pdCBJbnRlcnJ1cHQ6Cj4gCj4gInNldDsgdGhpcyBiaXQgaXMgc2V0IHdoZW5l dmVyIHRoZSB0cmFuc21pdCBidWZmZXJzdGF0dXMKPiBjaGFuZ2VzIGZyb20g4oCYMC10by0x4oCZ IChyZWxlYXNlZCkgYW5kIHRoZSBUSUUgYml0IGlzIHNldAo+IHdpdGhpbiB0aGUgaW50ZXJydXB0 IGVuYWJsZSByZWdpc3RlciIuCj4gCj4gSSBjYW5ub3QgdGVzdCBpdCB0aG91Z2gsIHNpbmNlIEkg ZG9uJ3QgaGF2ZSBhIHNqYTEwMDAuCgpEbyB3ZSBhZ3JlZSB0aGF0IGluIG9uZS1zaG90IG1vZGUg Ym90aCB0aGUgdHhfZXJyb3JzIGFuZCB0aGUgCmFyYml0cmF0aW9uX2xvc3QgY291bnRlcnMgYXJl IGluY3JlYXNlZCBpbiB0aGUgYXJiaXRyYXRpb24tbG9zdCBjYXNlPwoKQXQgbGVhc3QgdGhpcyB3 b3VsZCBmaXQgdG8gdGhlIEt2YXNlciBVU0IgYmVoYXZpb3VyLgoKQW5kIGJ0dy4gSSB3b25kZXJl ZCBpZiB3ZSBzaG91bGQgcmVtb3ZlIHRoZSBjaGVjayBmb3IgCkNBTl9DVFJMTU9ERV9PTkVfU0hP VCBoZXJlLCBhcyB3ZSBBTFdBWVMgc2hvdWxkIGNvdW50IGEgdHhfZXJyb3IgYW5kIApkcm9wIHRo ZSBlY2hvX3NrYiB3aGVuIHdlIGhhdmUgYSBUWC1pbnRlcnJ1cHQgYW5kIFRYLWNvbXBsZXRlIGZs YWcgaXMgemVyby4KClNvIHJlcGxhY2U6CgppZiAocHJpdi0+Y2FuLmN0cmxtb2RlICYgQ0FOX0NU UkxNT0RFX09ORV9TSE9UICYmCiAgICAgICAgICAgICAgICAgICAhKHN0YXR1cyAmIFNSX1RDUykp IHsKCndpdGg6CgppZiAoIShzdGF0dXMgJiBTUl9UQ1MpKSB7CgpBbnkgc3VnZ2VzdGlvbnM/CgpC ZXN0IHJlZ2FyZHMsCk9saXZlcgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=