From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9B2C433E0 for ; Fri, 19 Mar 2021 10:57:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DEA064F59 for ; Fri, 19 Mar 2021 10:57:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DEA064F59 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNCp5-0003WJ-Gu for qemu-devel@archiver.kernel.org; Fri, 19 Mar 2021 06:57:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNCn8-0002Bz-17 for qemu-devel@nongnu.org; Fri, 19 Mar 2021 06:55:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:53070) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lNCmz-0000a2-IZ for qemu-devel@nongnu.org; Fri, 19 Mar 2021 06:55:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616151332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bPXmGdHSFz5ZDoXl+7iNWzVTif/o3CBXG1G7BH0HGUY=; b=eJ1hmnkHYSYa+3g/skORrCYgf+x3CdFzAEHdFApDA1JPkUAZaM4aC2tsQBcrXlTZzvWGsh mHU4cuQdmzSXC3k8GJziKDta9AoPjds4AtQRB+GEYAoY3KwldjpyGft85zflA0hvlS5Zgt D4aT2NxrQnIJX6CmF06n80rWyIHOot4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-524-QjlriryDP6G4wcsyUbMopA-1; Fri, 19 Mar 2021 06:55:30 -0400 X-MC-Unique: QjlriryDP6G4wcsyUbMopA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 74E761007476; Fri, 19 Mar 2021 10:55:29 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-49.ams2.redhat.com [10.36.112.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id BC32810013D6; Fri, 19 Mar 2021 10:55:27 +0000 (UTC) Subject: Re: [PULL 5/5] m68k: add Virtual M68k Machine To: Laurent Vivier , Max Reitz , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Qemu-block References: <20210315204226.3481044-1-laurent@vivier.eu> <20210315204226.3481044-6-laurent@vivier.eu> <2730eee0-6f1b-2139-f93c-6a0a64727e29@redhat.com> <905c797a-25c3-bb43-5946-54b28d9530c0@vivier.eu> <27c791b2-dcc0-6c98-d765-ac1b60b7af3d@vivier.eu> <0d55cabf-0fa0-f9fd-6436-de2e03422329@vivier.eu> <0b3cedb8-f40a-18fd-5030-a596afb9298d@redhat.com> <82f6dc3e-18bf-f90a-7e43-5568b319767c@redhat.com> <3bcc22b2-eb25-b0a0-f47b-72c747ca6f0a@redhat.com> <1a2a91a4-0425-0da9-482b-f46a6e17b6b0@redhat.com> <9743c786-e620-8e50-be7d-f0c38984e29e@vivier.eu> From: Thomas Huth Message-ID: <098e4379-2092-1858-941f-a1fd54eaa038@redhat.com> Date: Fri, 19 Mar 2021 11:55:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <9743c786-e620-8e50-be7d-f0c38984e29e@vivier.eu> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.249, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 19/03/2021 11.50, Laurent Vivier wrote: > Le 19/03/2021 à 10:20, Max Reitz a écrit : >> On 19.03.21 07:32, Thomas Huth wrote: >>> On 18/03/2021 18.28, Max Reitz wrote: >>> [...] >>>>  From that it follows that I don’t see much use in testing specific devices either.  Say there’s >>>> a platform that provides both virtio-pci and virtio-mmio, the default (say virtio-pci) is fine >>>> for the iotests. I see little value in testing virtio-mmio as well.  (Perhaps I’m short-sighted, >>>> though.) >>> >>> That's a fair point. But still, if someone compiled QEMU only with a target that only provided >>> virtio-mmio, the iotests should not fail when running "make check". >>> To avoid that we continue playing whack-a-mole here in the future, maybe it would be better to >>> restrict the iotests to the "main" targets only, e.g. modify check-block.sh so that the tests only >>> run with x86, aarch64, s390x and ppc64 ? >> >> Right, that would certainly be the simplest solution. >> > > The problem with that is we can't run the tests if target-list doesn't contain one of these targets. The iotests are skipped in quite a bunch of cases already anyway, e.g. when GNU sed or bash are not available in the right version. So I think it would be also ok to skip them in builds without one of the major architectures. Anyway, since your patches are already ready, I think we also could simply go with those this time, and reconsider tweaking tests/check-block.sh the next time we run into this issue. Thomas