From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 30 Apr 2020 16:39:22 -0600 Subject: [PATCH 4/8] net: dwc_eth_qos: Move interface() to eqos_ops struct In-Reply-To: <20200430103656.29728-5-david.wu@rock-chips.com> References: <20200430103656.29728-1-david.wu@rock-chips.com> <20200430103656.29728-5-david.wu@rock-chips.com> Message-ID: <09934110-9e9c-e2b3-8288-60950e290ad9@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 4/30/20 4:36 AM, David Wu wrote: > After moving to eqos_ops, if eqos_config is defined > outside, can not export interface() definition. Looking at the patch itself, I think this patch just moves a function pointer from the config to the ops structure which makes sense. However, I can't understand the patch description at all, so I worry there's intended to be some other justification/implication for this patch, and that may not be correct... In particular, defined outside of what, and what does this have to do with exporting things?