All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: Tony Dinh <mibodhi@gmail.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>,
	Jason Cooper <u-boot@lakedaemon.net>
Cc: Chris Packham <judge.packham@gmail.com>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 3/3] arm: kirkwood: Dreamplug: Add DM SATA and remove IDE configs
Date: Sat, 31 Jul 2021 09:43:02 +0200	[thread overview]
Message-ID: <0994dfbe-3200-c78c-a97e-c5567a252255@denx.de> (raw)
In-Reply-To: <20210726060121.7253-4-mibodhi@gmail.com>

On 26.07.21 08:01, Tony Dinh wrote:
> - Enable DM SATA, removed IDE driver, and add SATA MV driver.
> - Use ethernet PHY names from device tree in default boot command
> 
> Signed-off-by: Tony Dinh <mibodhi@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> 
>   include/configs/dreamplug.h | 12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/dreamplug.h b/include/configs/dreamplug.h
> index 9106203ebc..65962ee733 100644
> --- a/include/configs/dreamplug.h
> +++ b/include/configs/dreamplug.h
> @@ -31,8 +31,8 @@
>   /*
>    * Default environment variables
>    */
> -#define CONFIG_BOOTCOMMAND		"setenv ethact egiga0; " \
> -	"${x_bootcmd_ethernet}; setenv ethact egiga1; " \
> +#define CONFIG_BOOTCOMMAND		"setenv ethact ethernet-controller@72000; " \
> +	"${x_bootcmd_ethernet}; setenv ethact ethernet-controller@76000; " \
>   	"${x_bootcmd_ethernet}; ${x_bootcmd_usb}; ${x_bootcmd_kernel}; "\
>   	"setenv bootargs ${x_bootargs} ${x_bootargs_root}; "	\
>   	"bootm 0x6400000;"
> @@ -52,4 +52,12 @@
>   #define CONFIG_PHY_BASE_ADR	0
>   #endif /* CONFIG_CMD_NET */
>   
> +/*
> + * SATA Driver configuration
> + */
> +#ifdef CONFIG_SATA
> +#define CONFIG_SYS_SATA_MAX_DEVICE	1
> +#define CONFIG_LBA48
> +#endif /* CONFIG_SATA */
> +
>   #endif /* _CONFIG_DREAMPLUG_H */
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

  reply	other threads:[~2021-07-31  7:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26  6:01 [PATCH 0/3] Convert the Dreamplug Ethernet and SATA to Driver Model Tony Dinh
2021-07-26  6:01 ` [PATCH 1/3] arm: kirkwood: Dreamplug: Add DM Ethernet and DM SATA configs Tony Dinh
2021-07-31  7:42   ` Stefan Roese
2021-07-26  6:01 ` [PATCH 2/3] arm: kirkwood: Dreamplug: Use Ethernet PHY name and address from device tree Tony Dinh
2021-07-31  7:41   ` Stefan Roese
2021-07-31  9:55     ` Tony Dinh
2021-07-31 10:27       ` Stefan Roese
2021-07-31 11:50         ` Stefan Roese
2021-07-31 22:37           ` Tony Dinh
2021-08-02  6:39             ` Stefan Roese
2021-08-02  7:54               ` Tony Dinh
2021-07-26  6:01 ` [PATCH 3/3] arm: kirkwood: Dreamplug: Add DM SATA and remove IDE configs Tony Dinh
2021-07-31  7:43   ` Stefan Roese [this message]
2021-07-31 10:00 ` [PATCH 0/3] Convert the Dreamplug Ethernet and SATA to Driver Model Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0994dfbe-3200-c78c-a97e-c5567a252255@denx.de \
    --to=sr@denx.de \
    --cc=judge.packham@gmail.com \
    --cc=mibodhi@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lakedaemon.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.