From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4132C433E6 for ; Fri, 26 Feb 2021 08:52:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79DBA64ECE for ; Fri, 26 Feb 2021 08:52:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230029AbhBZIwo (ORCPT ); Fri, 26 Feb 2021 03:52:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229915AbhBZIwm (ORCPT ); Fri, 26 Feb 2021 03:52:42 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 931A2C06174A for ; Fri, 26 Feb 2021 00:52:01 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id m1so7076513wml.2 for ; Fri, 26 Feb 2021 00:52:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4I/9T27v5fuw5VieFV0ytWcSNAk1Bbl6fxq7D/9O4Aw=; b=Jfw6tP2FVDpP7xS8MbqMlicPR0GZnIVCgiPOcK/MiszbWN4L4KBSdO2/h25VIMSeG+ 7SAwS2q8Z7P7hrGER2mdTBRT+q3vSFnUVkeBj0HKYrJXd4mYDNLP2/ale6YrMg77bPz0 cYNXpUSSVzBgaTjGEEnvD3AM5sC0dr0P4pJs0MKmJ6VJrXscOFoCFmXm67XVlGZkroIf TaP6BORXDmqVcynMjwc/tOSyFlPPV86DiB3empT8quFbYyXauzuVEM5kbtqChu5KNtvY 465h+fe4lpEQPLCTH3jrcXW9iHfbdBl9PyMrmL6Jr6pVxOt8ZneYJOpwGsa8EOXudSNN vDJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4I/9T27v5fuw5VieFV0ytWcSNAk1Bbl6fxq7D/9O4Aw=; b=ryvD8f1P6DrTgSzXycvbmKSSfCIdVEPpCJCwuaeAOBz49c4a2pBkkZZitD4KSGscbL iAzk7qaHRjmYTUGIRIBOw6ylhq5bHML3Sp5e7uwFnuoT6QBS70KIU+ax29g9MFV2D3PC DKoJaA/RHuyN7JlVUv0NyHCJRpoRRE5WSH3buK7QXYOKiyZqpoJciOWRyRqQHL+LTSri XpHx13B8BUM+z+jGCR24x1FggIQWSkpjC2VljERrQf1hJk/YqCkV1QuSADK31dGecXLa 2kP8YzjObVZLH5gHD8n8KMfHV7/8bvJmNr8TP+zmLJb6zIiZ+i9Aq7W25nknuxzKFv0d ai4A== X-Gm-Message-State: AOAM530hF/OWNmqMYPh6pi9ho3g3lyd9U89QzJmcOwUA0tMyfyZD9hsB miDFe5rg/m15Elw+A8AlJj6lZw== X-Google-Smtp-Source: ABdhPJxHPYGVqRr09nDy1S17EJWwgU6sW5Cb/LJlPKbA3dZHEnjVzSLya6Tdt5HY+7+SnowqHW6fVw== X-Received: by 2002:a7b:cc0c:: with SMTP id f12mr1706548wmh.137.1614329520071; Fri, 26 Feb 2021 00:52:00 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:f137:d18c:50a6:cc6a? ([2a01:e34:ed2f:f020:f137:d18c:50a6:cc6a]) by smtp.googlemail.com with ESMTPSA id j16sm12393890wra.17.2021.02.26.00.51.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Feb 2021 00:51:59 -0800 (PST) Subject: Re: [PATCH v2 3/9] devfreq: Use HZ macros To: Chanwoo Choi , rafael@kernel.org, andriy.shevchenko@linux.intel.com Cc: linux-kernel@vger.kernel.org, Chanwoo Choi , MyungJoo Ham , Kyungmin Park , "open list:DEVICE FREQUENCY (DEVFREQ)" References: <20210224144222.23762-1-daniel.lezcano@linaro.org> <20210224144222.23762-3-daniel.lezcano@linaro.org> <0db79cd7-f062-b31b-2a6c-ecf8dadaf572@gmail.com> From: Daniel Lezcano Message-ID: <09954745-5b39-8718-ca79-3e92a85e5ace@linaro.org> Date: Fri, 26 Feb 2021 09:51:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0db79cd7-f062-b31b-2a6c-ecf8dadaf572@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/02/2021 07:08, Chanwoo Choi wrote: > > > On 21. 2. 24. 오후 11:42, Daniel Lezcano wrote: >> HZ unit conversion macros are available in units.h, use them and >> remove the duplicate definition. >> >> Signed-off-by: Daniel Lezcano >> Reviewed-by: Christian Eggers >> Acked-by: Chanwoo Choi >> --- >>   drivers/devfreq/devfreq.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c >> index bf3047896e41..b6d63f02d293 100644 >> --- a/drivers/devfreq/devfreq.c >> +++ b/drivers/devfreq/devfreq.c >> @@ -26,6 +26,7 @@ >>   #include >>   #include >>   #include >> +#include >>   #include "governor.h" >>     #define CREATE_TRACE_POINTS >> @@ -33,7 +34,6 @@ >>     #define IS_SUPPORTED_FLAG(f, name) ((f & DEVFREQ_GOV_FLAG_##name) >> ? true : false) >>   #define IS_SUPPORTED_ATTR(f, name) ((f & DEVFREQ_GOV_ATTR_##name) ? >> true : false) >> -#define HZ_PER_KHZ    1000 >>     static struct class *devfreq_class; >>   static struct dentry *devfreq_debugfs; >> > > I changed the patch title with 'PM /' prefix as following > in order to keep the consistent patch style if there are no any special > objection. > - PM / devfreq: Use HZ macros > > Applied it. It should not compile. This patch and others depend on 1/9. It would make sense to merge all of them through linux-pm. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog