From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 427DCC64E8A for ; Mon, 30 Nov 2020 13:24:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5F51206F9 for ; Mon, 30 Nov 2020 13:24:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5F51206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 178C989C7F; Mon, 30 Nov 2020 13:24:43 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B04289C05 for ; Mon, 30 Nov 2020 13:24:41 +0000 (UTC) IronPort-SDR: iMuPRKankDfSQnUA+j/2wVLmutAnC/LcZGFxJb9XcplcGlMhqomyoLqcskNi6BCxxtJ+3o73y8 hKA5EQOtk+EA== X-IronPort-AV: E=McAfee;i="6000,8403,9820"; a="160403907" X-IronPort-AV: E=Sophos;i="5.78,381,1599548400"; d="scan'208";a="160403907" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 05:24:39 -0800 IronPort-SDR: qc5hfKEJ9+ASNA+8MZXJebAcNis5kw2bhaz3hO05x0dfywpgz+y9+cGYWvzVgxUn+Qzs7zSUM8 kY39t4536CAw== X-IronPort-AV: E=Sophos;i="5.78,381,1599548400"; d="scan'208";a="538593788" Received: from ekiperwa-mobl.ger.corp.intel.com (HELO [10.252.22.113]) ([10.252.22.113]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 05:24:38 -0800 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20201127195334.13134-1-chris@chris-wilson.co.uk> From: Matthew Auld Message-ID: <099bfb02-f13e-4bab-659f-c3e847aeeed3@intel.com> Date: Mon, 30 Nov 2020 13:24:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201127195334.13134-1-chris@chris-wilson.co.uk> Content-Language: en-GB Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Differentiate oom failures from invalid map types X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 27/11/2020 19:53, Chris Wilson wrote: > After a cursory check on the parameters to i915_gem_object_pin_map(), > where we return a precise error, if the backend rejects the mapping we > always return PTR_ERR(-ENOMEM). Let us also return a more precise error > here so we can differentiate between running out of memory and > programming errors (or situations where we may be trying different paths > and looking for an error from an unsupported map). > > Signed-off-by: Chris Wilson > Cc: Matthew Auld Reviewed-by: Matthew Auld _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx