From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54365 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONmCF-0005iP-BA for qemu-devel@nongnu.org; Sun, 13 Jun 2010 08:21:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ONmCD-0003rX-My for qemu-devel@nongnu.org; Sun, 13 Jun 2010 08:21:50 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:34946) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONmCD-0003rA-Fb for qemu-devel@nongnu.org; Sun, 13 Jun 2010 08:21:49 -0400 Message-Id: <09BCAF38-E530-4C3F-A83C-67C09D94CA02@web.de> From: =?ISO-8859-1?Q?Andreas_F=E4rber?= In-Reply-To: <20100613051634.26633.8826.malone@palladium.canonical.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: [Qemu-devel] [Bug 581737] Re: Can't read e1000 NIC EEPROM on NetBSD guest Date: Sun, 13 Jun 2010 14:21:21 +0200 References: <20100517132539.15293.52060.malonedeb@gandwana.canonical.com> <20100613051634.26633.8826.malone@palladium.canonical.com> Sender: andreas.faerber@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bug 581737 <581737@bugs.launchpad.net> Cc: qemu-devel@nongnu.org Am 13.06.2010 um 07:16 schrieb Izumi Tsutsui: >> Please email the patch to qemu-devel@nongnu.org via git-send-email. > Isn't the following post enough? What's incomplete on this? > http://lists.nongnu.org/archive/html/qemu-devel/2010-06/msg00449.html That is still not a proper git-format-patch patch, it is missing among others the From: and Subject: lines and, likely, a more detailled description of what it does and why, for maintainers to be able to apply it with the git-am tool. But first it needs to be reviewed and ack'ed by people knowing that part of the code, and such review is done by inline patches on qemu- devel mailing list, not by HTTP links to bugtrackers (there are simply too many patches). The git-send-email tool assures that the format is not damaged by your favorite mail agent. Hope that explains, Andreas