From mboxrd@z Thu Jan  1 00:00:00 1970
From: "H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver
Date: Fri, 22 Jul 2016 08:42:06 +0200
Message-ID: <09C8D3C3-0CA9-48EB-B7B1-FCADAB2BA23A@goldelico.com>
References: <cover.1468928850.git.hns@goldelico.com> <403335d22f6a8e131bc44077f97e499970e61245.1468928850.git.hns@goldelico.com> <20160720012457.GA10971@rob-hp-laptop> <5791BEF3.5060404@samsung.com>
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <5791BEF3.5060404@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Rob Herring <robh@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Richard Purdie <rpurdie@rpsys.net>, drivshin.allworx@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, kernel@pyra-handheld.com, marek@goldelico.com, letux-kernel@openphoenux.org, Andrey Utkin <andrey_utkin@fastmail.com>
List-Id: linux-leds@vger.kernel.org

Hi,

> Am 22.07.2016 um 08:36 schrieb Jacek Anaszewski <j.anaszewski@samsung.com>:
> 
> On 07/20/2016 03:24 AM, Rob Herring wrote:
>> On Tue, Jul 19, 2016 at 01:47:31PM +0200, H. Nikolaus Schaller wrote:
>>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>>> ---
>>>  .../devicetree/bindings/leds/is31fl319x.txt        | 59 ++++++++++++++++++++++
>>>  1 file changed, 59 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/leds/is31fl319x.txt
>>> 
>>> diff --git a/Documentation/devicetree/bindings/leds/is31fl319x.txt b/Documentation/devicetree/bindings/leds/is31fl319x.txt
>>> new file mode 100644
>>> index 0000000..03287c0
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/leds/is31fl319x.txt
>>> @@ -0,0 +1,59 @@
>>> +LEDs connected to is31fl319x LED controller chip
>>> +
>>> +Required properties:
>>> +- compatible : Should be any of
>>> +	"issi,is31fl3190"
>>> +	"issi,is31fl3191"
>>> +	"issi,is31fl3193"
>>> +	"issi,is31fl3196"
>>> +	"issi,is31fl3199"
>>> +	"si-en,sn3199".
>>> +- #address-cells: Must be 1.
>>> +- #size-cells: Must be 0.
>>> +- reg: 0x64, 0x65, 0x66, 0x67.
>> 
>> This is an OR or AND? OR it seems. With that,
> 
> Nikolaus, could you please make it explicit?

Yes, Rob's intuition is right. An AND does
obviously not make sense for a reg property.

It is an OR.

So if you perfer, please substitute 

- reg: 0x64, 0x65, 0x66, or 0x67.

BR,
Nikolaus