From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2362DC433FE for ; Mon, 18 Oct 2021 22:04:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D01E61186 for ; Mon, 18 Oct 2021 22:04:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233783AbhJRWGV (ORCPT ); Mon, 18 Oct 2021 18:06:21 -0400 Received: from mga05.intel.com ([192.55.52.43]:45414 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233633AbhJRWGR (ORCPT ); Mon, 18 Oct 2021 18:06:17 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="314573181" X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="314573181" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2021 15:04:05 -0700 X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="443623890" Received: from jkpeteho-mobl.amr.corp.intel.com (HELO skuppusw-desk1.amr.corp.intel.com) ([10.254.7.230]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2021 15:04:03 -0700 Subject: Re: [PATCH v10 03/11] x86/cpufeatures: Add TDX Guest CPU feature To: Borislav Petkov Cc: Josh Poimboeuf , Thomas Gleixner , Ingo Molnar , x86@kernel.org, Paolo Bonzini , David Hildenbrand , Andrea Arcangeli , Juergen Gross , Deep Shah , VMware Inc , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , linux-kernel@vger.kernel.org References: <20211009053747.1694419-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20211009053747.1694419-4-sathyanarayanan.kuppuswamy@linux.intel.com> <20211013194251.ndbyj45egz6msl63@treble> <1a6220a5-3abd-dea1-4b2f-2acade311236@linux.intel.com> From: Sathyanarayanan Kuppuswamy Message-ID: <09a099b2-ef7a-0aba-c9dd-4f115d754b4f@linux.intel.com> Date: Mon, 18 Oct 2021 15:04:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/18/21 2:59 PM, Borislav Petkov wrote: > On Mon, Oct 18, 2021 at 02:05:10PM -0700, Sathyanarayanan Kuppuswamy wrote: >> Any consensus on this? > Well, you can simply not put any comment there now because this patchset > doesn't add those debug options. > > The patch which adds them, should add that comment explaining why that > order needs to be the way it is. For now I will remove the comment as you have suggested. > > In general, I get the impression from review that you add stuff for > future patchsets which only confuses reviewers and instead, you should > simply not do that but do only the required changes, only for the > current aspect of functionality being added. I will check the patch list again and re-organize the patch set, If I find any such changes. > >> I think SME code also talks about future use case in its comment. > No, this has nothing to do with a future use case: you should look at > what that function does and then read that comment again. Sorry, I will check the details correctly. > -- Sathyanarayanan Kuppuswamy Linux Kernel Developer