From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68D39C48BE5 for ; Tue, 15 Jun 2021 03:19:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EBD1B61405 for ; Tue, 15 Jun 2021 03:19:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBD1B61405 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 430666B0036; Mon, 14 Jun 2021 23:19:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E04E6B006E; Mon, 14 Jun 2021 23:19:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25AEE6B0070; Mon, 14 Jun 2021 23:19:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id E64086B0036 for ; Mon, 14 Jun 2021 23:19:54 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7C47ABA1D for ; Tue, 15 Jun 2021 03:19:54 +0000 (UTC) X-FDA: 78254503908.34.E49AD17 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf01.hostedemail.com (Postfix) with ESMTP id 75CE55001533 for ; Tue, 15 Jun 2021 03:19:42 +0000 (UTC) IronPort-SDR: O9AINlxJTEYJIVNZvD1GCH1UwtF/E2E5va0t42XuskLknKFIr6UP+K6dLR7wwxQQqgfD66+u/v nuJLmzcFjJXA== X-IronPort-AV: E=McAfee;i="6200,9189,10015"; a="291547706" X-IronPort-AV: E=Sophos;i="5.83,275,1616482800"; d="scan'208";a="291547706" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2021 20:19:50 -0700 IronPort-SDR: ri4P/H+XUswIbWAc9hVv3si7t688QdvlLEeTmogJr8vCfAWVYiaXKElgKkA6kTrQtWx9WyXZnZ J5Sxp6TIABFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,275,1616482800"; d="scan'208";a="554308038" Received: from unknown (HELO [10.239.159.118]) ([10.239.159.118]) by fmsmga001.fm.intel.com with ESMTP; 14 Jun 2021 20:19:48 -0700 Cc: baolu.lu@linux.intel.com, kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Joerg Roedel , Fenghua Yu Subject: Re: [linux-next:master 8472/9209] drivers/iommu/intel/perf.c:16: warning: expecting prototype for perf.c(). Prototype was for DEFINE_SPINLOCK() instead To: kernel test robot References: <202106121952.9eBLxaDd-lkp@intel.com> From: Lu Baolu Message-ID: <09a11577-5c2d-808d-ac70-8d546ef43199@linux.intel.com> Date: Tue, 15 Jun 2021 11:18:24 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <202106121952.9eBLxaDd-lkp@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf01.hostedemail.com; dkim=none; spf=none (imf01.hostedemail.com: domain of baolu.lu@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=baolu.lu@linux.intel.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none) X-Stat-Signature: sxnbjqtgehkednxwa3gjm7hfdj3nwo44 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 75CE55001533 X-HE-Tag: 1623727182-804968 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/12/21 7:47 PM, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 25fe90f43fa312213b653dc1f12fd2d80f855883 > commit: 456bb0b97f00fe8defba155c0a4c48d951635395 [8472/9209] iommu/vt-d: Expose latency monitor data through debugfs > config: x86_64-randconfig-a006-20210612 (attached as .config) > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project d2012d965d60c3258b3a69d024491698f8aec386) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install x86_64 cross compiling tool for clang build > # apt-get install binutils-x86-64-linux-gnu > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=456bb0b97f00fe8defba155c0a4c48d951635395 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 456bb0b97f00fe8defba155c0a4c48d951635395 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > drivers/iommu/intel/perf.c:16: warning: Function parameter or member 'latency_lock' not described in 'DEFINE_SPINLOCK' >>> drivers/iommu/intel/perf.c:16: warning: expecting prototype for perf.c(). Prototype was for DEFINE_SPINLOCK() instead This seems to be a kernel doc warning and should be fixed in the header file for DEFINE_SPINLOCK. Did I miss anything? DEFINE_SPINLOCK is used everywhere, perhaps we need to add some comments around it? Best regards, baolu > > > vim +16 drivers/iommu/intel/perf.c > > 55ee5e67a59a1b Lu Baolu 2021-06-10 15 > 55ee5e67a59a1b Lu Baolu 2021-06-10 @16 static DEFINE_SPINLOCK(latency_lock); > 55ee5e67a59a1b Lu Baolu 2021-06-10 17 > > :::::: The code at line 16 was first introduced by commit > :::::: 55ee5e67a59a1b6f388d7a1c7b24022145f47a3e iommu/vt-d: Add common code for dmar latency performance monitors > > :::::: TO: Lu Baolu > :::::: CC: Joerg Roedel > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7937051480539500548==" MIME-Version: 1.0 From: Lu Baolu To: kbuild-all@lists.01.org Subject: Re: [linux-next:master 8472/9209] drivers/iommu/intel/perf.c:16: warning: expecting prototype for perf.c(). Prototype was for DEFINE_SPINLOCK() instead Date: Tue, 15 Jun 2021 11:18:24 +0800 Message-ID: <09a11577-5c2d-808d-ac70-8d546ef43199@linux.intel.com> In-Reply-To: <202106121952.9eBLxaDd-lkp@intel.com> List-Id: --===============7937051480539500548== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 6/12/21 7:47 PM, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: 25fe90f43fa312213b653dc1f12fd2d80f855883 > commit: 456bb0b97f00fe8defba155c0a4c48d951635395 [8472/9209] iommu/vt-d: = Expose latency monitor data through debugfs > config: x86_64-randconfig-a006-20210612 (attached as .config) > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project d201= 2d965d60c3258b3a69d024491698f8aec386) > reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sb= in/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install x86_64 cross compiling tool for clang build > # apt-get install binutils-x86-64-linux-gnu > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-nex= t.git/commit/?id=3D456bb0b97f00fe8defba155c0a4c48d951635395 > git remote add linux-next https://git.kernel.org/pub/scm/linux/k= ernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 456bb0b97f00fe8defba155c0a4c48d951635395 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross A= RCH=3Dx86_64 > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All warnings (new ones prefixed by >>): > = > drivers/iommu/intel/perf.c:16: warning: Function parameter or member = 'latency_lock' not described in 'DEFINE_SPINLOCK' >>> drivers/iommu/intel/perf.c:16: warning: expecting prototype for perf.c(= ). Prototype was for DEFINE_SPINLOCK() instead This seems to be a kernel doc warning and should be fixed in the header file for DEFINE_SPINLOCK. Did I miss anything? DEFINE_SPINLOCK is used everywhere, perhaps we need to add some comments around it? Best regards, baolu > = > = > vim +16 drivers/iommu/intel/perf.c > = > 55ee5e67a59a1b Lu Baolu 2021-06-10 15 > 55ee5e67a59a1b Lu Baolu 2021-06-10 @16 static DEFINE_SPINLOCK(latency_lo= ck); > 55ee5e67a59a1b Lu Baolu 2021-06-10 17 > = > :::::: The code at line 16 was first introduced by commit > :::::: 55ee5e67a59a1b6f388d7a1c7b24022145f47a3e iommu/vt-d: Add common co= de for dmar latency performance monitors > = > :::::: TO: Lu Baolu > :::::: CC: Joerg Roedel > = > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org >=20 --===============7937051480539500548==--