All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Niedermayr, BENEDIKT" <benedikt.niedermayr@siemens.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Cc: "rogerq@kernel.org" <rogerq@kernel.org>,
	"tony@atomide.com" <tony@atomide.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH v9 0/2] gpmc wait pin additions
Date: Thu, 3 Nov 2022 08:37:11 -0400	[thread overview]
Message-ID: <09a7de3e-6431-1815-5ea0-072cbda81875@linaro.org> (raw)
In-Reply-To: <3d067d7ce32abd6a78ee9a914e81393f48f46a37.camel@siemens.com>

On 03/11/2022 04:13, Niedermayr, BENEDIKT wrote:
> On Wed, 2022-11-02 at 10:02 -0400, Krzysztof Kozlowski wrote:
>> On 02/11/2022 09:30, B. Niedermayr wrote:
>>> From: Benedikt Niedermayr <benedikt.niedermayr@siemens.com>
>>>
>>> Currently it is not possible to configure the WAIT0PINPOLARITY and
>>> WAIT1PINPOLARITY bits of the GPMC_CONFIG register directly via
>>> device tree properties.
>>>
>>> It is also not possible to use the same wait-pin for different
>>> cs-regions.
>>>
>>> While the current implementation may fullfill most usecases, it may not
>>> be sufficient for more complex setups (e.g. FPGA/ASIC interfaces), where
>>> more complex interfacing options where possible.
>>>
>>> For example interfacing an ASIC which offers multiple cs-regions but
>>> only one waitpin the current driver and dt-bindings are not sufficient.
>>>
>>> While using the same waitpin for different cs-regions worked for older
>>> kernels (4.14) the omap-gpmc.c driver refused to probe (-EBUSY) with
>>> newer kernels (>5.10).
>>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
> 
> Thanks for the hint.
> 
> Was everything OK with v9 (except that I resendet the tagged patch)? Until v8 I wasn't aware of that. I thought I added the tag for v9. 

You did not add the tag you received.

Best regards,
Krzysztof


  reply	other threads:[~2022-11-03 12:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 13:30 [PATCH v9 0/2] gpmc wait pin additions B. Niedermayr
2022-11-02 13:30 ` [PATCH v9 1/2] memory: omap-gpmc: " B. Niedermayr
2022-12-07 13:51   ` Tony Lindgren
2022-12-07 14:52     ` Niedermayr, BENEDIKT
2022-12-07 15:06       ` Tony Lindgren
2022-12-07 17:28         ` Niedermayr, BENEDIKT
2022-12-08  5:49           ` Tony Lindgren
2022-12-08 15:55             ` Niedermayr, BENEDIKT
2022-12-12  7:16               ` Tony Lindgren
2022-11-02 13:30 ` [PATCH v9 2/2] dt-bindings: memory-controllers: gpmc-child: add wait-pin polarity B. Niedermayr
2022-11-02 14:02 ` [PATCH v9 0/2] gpmc wait pin additions Krzysztof Kozlowski
2022-11-03  8:13   ` Niedermayr, BENEDIKT
2022-11-03 12:37     ` Krzysztof Kozlowski [this message]
2022-11-02 14:03 ` Krzysztof Kozlowski
2022-11-03  8:07   ` Niedermayr, BENEDIKT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09a7de3e-6431-1815-5ea0-072cbda81875@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=benedikt.niedermayr@siemens.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.