From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C5E6C433F5 for ; Mon, 16 May 2022 23:44:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E9B068425D; Tue, 17 May 2022 01:44:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="RtfHzMR5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 543F684264; Tue, 17 May 2022 01:44:33 +0200 (CEST) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E65738418D for ; Tue, 17 May 2022 01:44:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20220516234426epoutp02264ab38f4e7c5705e205e761ac5a98ab~vuoRohe--0739507395epoutp02d for ; Mon, 16 May 2022 23:44:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20220516234426epoutp02264ab38f4e7c5705e205e761ac5a98ab~vuoRohe--0739507395epoutp02d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1652744666; bh=jN049qxqY72L89PJ3ClMev4fKFMWbOicbYJsxfAQLpc=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=RtfHzMR5TEDsNg06/evB9KfydF4T23rSznBDy/6twlzcpzYIHPsqT3621wpFCvpUS IgGaHH2cKCN+bHR0YcfpVg8h40+i9SPFg6wNkrOSO7xrE7M+Qp1r+0BwVnmqhkChPR 3hreadSwsnewv/osLVM79F5xmE3GtFS9Nv4T6u6s= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20220516234425epcas1p258fb7d4f95b3cb8bec1d1b10f5bf3825~vuoRadHVF0338503385epcas1p2J; Mon, 16 May 2022 23:44:25 +0000 (GMT) Received: from epsmges1p3.samsung.com (unknown [182.195.36.133]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4L2G7D36mMz4x9QJ; Mon, 16 May 2022 23:44:24 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p3.samsung.com (Symantec Messaging Gateway) with SMTP id 29.BF.10038.6D1E2826; Tue, 17 May 2022 08:44:22 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20220516234422epcas1p4b4c7ade83f05412f967549a114106172~vuoN-bdbe1048210482epcas1p40; Mon, 16 May 2022 23:44:22 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220516234422epsmtrp195b410e8974c8b218d27a229285e9b31~vuoN_cK8-1752717527epsmtrp1c; Mon, 16 May 2022 23:44:22 +0000 (GMT) X-AuditID: b6c32a37-93a90a8000002736-d6-6282e1d6f9ac Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 97.8A.11276.6D1E2826; Tue, 17 May 2022 08:44:22 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20220516234421epsmtip27f1131a57f3ba482eed6c49d742f68bb~vuoNmWQba2475824758epsmtip2L; Mon, 16 May 2022 23:44:21 +0000 (GMT) Message-ID: <09b4214c-c869-8de2-73b8-cf19c7eae3a7@samsung.com> Date: Tue, 17 May 2022 08:44:21 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] pmic: pca9450: drop pointless .data entries Content-Language: en-US To: Rasmus Villemoes , u-boot@lists.denx.de Cc: Marek Vasut , Fabio Estevam , Peng Fan From: Jaehoon Chung In-Reply-To: <20220503085807.904742-2-rasmus.villemoes@prevas.dk> Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkk+LIzCtJLcpLzFFi42LZdlhTT/faw6Ykg3VfZC3mL1jMZvGmrZHR 4seqL6wWN187WLzd28nuwOoxb9YJFo+zd3Ywemx8t4PJY8bsN4wBLFHZNhmpiSmpRQqpecn5 KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAe5UUyhJzSoFCAYnFxUr6djZF +aUlqQoZ+cUltkqpBSk5BaYFesWJucWleel6eaklVoYGBkamQIUJ2Rn7329nLVjPUXG08xVr A+NDti5GTg4JAROJU023WbsYuTiEBHYwSry6OoUZwvnEKHH94XJGkCohgW+MEvfeB8B0XN9/ EqpoL6PE/dYlUO3vGSUWL3vPDFLFK2An8fnkW7BuFgFViR/fz7NAxAUlTs58AmaLCkRITJt1 BuwOYQEXiVMnrjCB2MwC4hK3nswHs0UE3CVeH77AChFPkDjUu4kdxGYT0JHY/u04WA2ngKPE 7e9noHrlJba/ncMMcelPdomJr/MhbBeJKbNmskPYwhKvjm+BsqUkXva3sYM8ICHQzCixdMlB Vginh1HiX8N1aCgZS+xfOhloAwfQBk2J9bv0IcKKEjt/z2WEWMwn8e5rDytIiYQAr0RHmxBE iYrEpdcvmWB23X3ynxXC9pDoPn6UfQKj4iykYJmF5P1ZSN6ZhbB4ASPLKkax1ILi3PTUYsMC Y3hsJ+fnbmIEp0kt8x2M095+0DvEyMTBeIhRgoNZSYTXoKIhSYg3JbGyKrUoP76oNCe1+BCj KTByJjJLiSbnAxN1Xkm8oYmlgYmZkbGJhaGZoZI476pppxOFBNITS1KzU1MLUotg+pg4OKUa mBSmvlW8uVar+eQ29Vl977wtd0z4uehl36Hp23kWFOqlrjiSz7tpo99tS8Xn3feNzF677FHN TM31zjN6sXGJxTaBOG2XjksC59c2pW+eviY/iyWIu1L1jK4t+8c1XMFrqzc1L/ocHtyoeljz V4R53nRLtrndVYLLxdj63rA901Rf8+JQXfgJrefV8zUuHPG23st1c/H9pdfSn/nEPVJ61yua JRmj1eAx2WeZfYrKGYNYtTnN1yfKGK38+Ni54w3zXeNrXSsqD1lHFhWu3esmXqi20MXy/zmp qzbq6XXpSl4vQz9I9kaGnzet2FJX4ppxQzwgcanJ5+mOVdv3fy839i7Yffx+ucRh+9jSzwIS SizFGYmGWsxFxYkAQjrXExwEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsWy7bCSvO61h01JBufa2C3mL1jMZvGmrZHR 4seqL6wWN187WLzd28nuwOoxb9YJFo+zd3Ywemx8t4PJY8bsN4wBLFFcNimpOZllqUX6dglc Gfvfb2ctWM9RcbTzFWsD40O2LkZODgkBE4nr+08ydzFycQgJ7GaU+NP0lhkiISXx+elUoCIO IFtY4vDhYoiat4wSax9dZwGp4RWwk/h88i0jiM0ioCrx4/t5qLigxMmZT8BsUYEIiQe7z7KC 2MICLhKnTlxhArGZBcQlbj2ZD2aLCLhLvD58gRUiniDxbFEbI8Sy04wS5xbcBEuwCehIbP92 HKyBU8BR4vb3M0wgxzELqEusnycE0Ssvsf3tHOYJjEKzkJwxC8m6WQgds5B0LGBkWcUomVpQ nJueW2xYYJiXWq5XnJhbXJqXrpecn7uJERwVWpo7GLev+qB3iJGJg/EQowQHs5IIr0FFQ5IQ b0piZVVqUX58UWlOavEhRmkOFiVx3gtdJ+OFBNITS1KzU1MLUotgskwcnFINTPr3byz1zlm4 Ij30+bTWjcF2aaxH4zhDxbNOf75aI/RHue+exLSLmfqPTzy9+2rVuyJT49LXB48/Vzr9unNj 8oz6urt+BUYFNwqXKXw6bLlptWPMbCX7a2EHFh2Zt/au4dOE+qbLicl5GtU8orO+LL3/XqZY c0P3Fn+feKmjZ8SeN36XjRAr3/lKyM07aO9hJYtCtSf/d5yrXR6otcz0QUu2/vG3f77+Ppyh Xf9HgCnx4//9c3sTzH+FWvz/9vFwX/QB/lirpVLOPydVH/B3NNj7d3nhvXV3FbnzVhffTDwz 8xOPwt0sZekIEcu9q6LOWVVvMsmQOTJhRt3y5M+a4jkZsdIHLwq9KzablLDFUFWJpTgj0VCL uag4EQCiuKOj+QIAAA== X-CMS-MailID: 20220516234422epcas1p4b4c7ade83f05412f967549a114106172 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220503085823epcas1p1762ee209ae2cc01d759e2a54133fdc21 References: <20220503085807.904742-1-rasmus.villemoes@prevas.dk> <20220503085807.904742-2-rasmus.villemoes@prevas.dk> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 5/3/22 17:58, Rasmus Villemoes wrote: > These are the i2c addresses of the chips, but that comes from device > tree. Having that information duplicated here just adds confusion. > > Signed-off-by: Rasmus Villemoes Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/power/pmic/pca9450.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c > index 2394b196c5..34cee34dba 100644 > --- a/drivers/power/pmic/pca9450.c > +++ b/drivers/power/pmic/pca9450.c > @@ -81,9 +81,9 @@ static struct dm_pmic_ops pca9450_ops = { > }; > > static const struct udevice_id pca9450_ids[] = { > - { .compatible = "nxp,pca9450a", .data = 0x25, }, > - { .compatible = "nxp,pca9450b", .data = 0x25, }, > - { .compatible = "nxp,pca9450c", .data = 0x25, }, > + { .compatible = "nxp,pca9450a" }, > + { .compatible = "nxp,pca9450b" }, > + { .compatible = "nxp,pca9450c" }, > { } > }; >