From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7490C433DF for ; Thu, 28 May 2020 11:59:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99B07215A4 for ; Thu, 28 May 2020 11:59:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388602AbgE1L7i (ORCPT ); Thu, 28 May 2020 07:59:38 -0400 Received: from foss.arm.com ([217.140.110.172]:51512 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388854AbgE1L7g (ORCPT ); Thu, 28 May 2020 07:59:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A4602D6E; Thu, 28 May 2020 04:59:35 -0700 (PDT) Received: from [192.168.0.14] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D37283F6C4; Thu, 28 May 2020 04:59:34 -0700 (PDT) Subject: Re: [PATCH 1/3] KVM: arm64: Stop writing aarch32's CSSELR into ACTLR To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Julien Thierry , Suzuki K Poulose , stable@vger.kernel.org References: <20200526161834.29165-1-james.morse@arm.com> <20200526161834.29165-2-james.morse@arm.com> <4be0c0b654f7d7c1efe9f52efb856bd8@kernel.org> From: James Morse Message-ID: <09dca8e9-c548-43fd-a95b-747a77f19e02@arm.com> Date: Thu, 28 May 2020 12:59:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <4be0c0b654f7d7c1efe9f52efb856bd8@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Marc, On 28/05/2020 09:57, Marc Zyngier wrote: > On 2020-05-26 17:18, James Morse wrote: >> access_csselr() uses the 32bit r->reg value to access the 64bit array, >> so reads and write the wrong value. sys_regs[4], is ACTLR_EL1, which >> is subsequently save/restored when we enter the guest. >> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c >> index 51db934702b6..2eda539f3281 100644 >> --- a/arch/arm64/kvm/sys_regs.c >> +++ b/arch/arm64/kvm/sys_regs.c >> @@ -2060,7 +2060,7 @@ static const struct sys_reg_desc cp15_regs[] = { >> >>      { Op1(1), CRn( 0), CRm( 0), Op2(0), access_ccsidr }, >>      { Op1(1), CRn( 0), CRm( 0), Op2(1), access_clidr }, >> -    { Op1(2), CRn( 0), CRm( 0), Op2(0), access_csselr, NULL, c0_CSSELR }, >> +    { Op1(2), CRn( 0), CRm( 0), Op2(0), access_csselr_el1, NULL, CSSELR_EL1 }, >>  }; > This is a departure from the way we deal with 32bit CP15 registers. > We deal with this exact issue in a very different way for other > CP15 regs, by adjusting the index in the sys_regs array (see the > way we handle the VM regs). > > How about something like this (untested): [like access_vm_reg() does] Sure, I'll give that a test and re-post it. > Ideally, I'd like the core sys_reg code to deal with this sort > of funnies, but I'm trying to keep the change minimal... Roll this '/2' and upper/lower bits stuff into a vcpu_write_cp15_reg() that calls vcpu_write_sys_reg()? (/me hunts out the todo list) Thanks, James From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD9F0C433E0 for ; Thu, 28 May 2020 11:59:41 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 49028215A4 for ; Thu, 28 May 2020 11:59:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49028215A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A9DE44B23C; Thu, 28 May 2020 07:59:40 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jkZaEH9-uuYJ; Thu, 28 May 2020 07:59:39 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 710434B1B8; Thu, 28 May 2020 07:59:39 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A91A24B1BF for ; Thu, 28 May 2020 07:59:37 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mNsMBgqey3lq for ; Thu, 28 May 2020 07:59:36 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 69C4F4B1B8 for ; Thu, 28 May 2020 07:59:36 -0400 (EDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A4602D6E; Thu, 28 May 2020 04:59:35 -0700 (PDT) Received: from [192.168.0.14] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D37283F6C4; Thu, 28 May 2020 04:59:34 -0700 (PDT) Subject: Re: [PATCH 1/3] KVM: arm64: Stop writing aarch32's CSSELR into ACTLR To: Marc Zyngier References: <20200526161834.29165-1-james.morse@arm.com> <20200526161834.29165-2-james.morse@arm.com> <4be0c0b654f7d7c1efe9f52efb856bd8@kernel.org> From: James Morse Message-ID: <09dca8e9-c548-43fd-a95b-747a77f19e02@arm.com> Date: Thu, 28 May 2020 12:59:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <4be0c0b654f7d7c1efe9f52efb856bd8@kernel.org> Content-Language: en-GB Cc: stable@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu SGkgTWFyYywKCk9uIDI4LzA1LzIwMjAgMDk6NTcsIE1hcmMgWnluZ2llciB3cm90ZToKPiBPbiAy MDIwLTA1LTI2IDE3OjE4LCBKYW1lcyBNb3JzZSB3cm90ZToKPj4gYWNjZXNzX2Nzc2VscigpIHVz ZXMgdGhlIDMyYml0IHItPnJlZyB2YWx1ZSB0byBhY2Nlc3MgdGhlIDY0Yml0IGFycmF5LAo+PiBz byByZWFkcyBhbmQgd3JpdGUgdGhlIHdyb25nIHZhbHVlLiBzeXNfcmVnc1s0XSwgaXMgQUNUTFJf RUwxLCB3aGljaAo+PiBpcyBzdWJzZXF1ZW50bHkgc2F2ZS9yZXN0b3JlZCB3aGVuIHdlIGVudGVy IHRoZSBndWVzdC4KCj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jIGIv YXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYwo+PiBpbmRleCA1MWRiOTM0NzAyYjYuLjJlZGE1Mzlm MzI4MSAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYwo+PiArKysgYi9h cmNoL2FybTY0L2t2bS9zeXNfcmVncy5jCj4+IEBAIC0yMDYwLDcgKzIwNjAsNyBAQCBzdGF0aWMg Y29uc3Qgc3RydWN0IHN5c19yZWdfZGVzYyBjcDE1X3JlZ3NbXSA9IHsKPj4KPj4gwqDCoMKgwqAg eyBPcDEoMSksIENSbiggMCksIENSbSggMCksIE9wMigwKSwgYWNjZXNzX2Njc2lkciB9LAo+PiDC oMKgwqDCoCB7IE9wMSgxKSwgQ1JuKCAwKSwgQ1JtKCAwKSwgT3AyKDEpLCBhY2Nlc3NfY2xpZHIg fSwKPj4gLcKgwqDCoCB7IE9wMSgyKSwgQ1JuKCAwKSwgQ1JtKCAwKSwgT3AyKDApLCBhY2Nlc3Nf Y3NzZWxyLCBOVUxMLCBjMF9DU1NFTFIgfSwKPj4gK8KgwqDCoCB7IE9wMSgyKSwgQ1JuKCAwKSwg Q1JtKCAwKSwgT3AyKDApLCBhY2Nlc3NfY3NzZWxyX2VsMSwgTlVMTCwgQ1NTRUxSX0VMMSB9LAo+ PiDCoH07Cgo+IFRoaXMgaXMgYSBkZXBhcnR1cmUgZnJvbSB0aGUgd2F5IHdlIGRlYWwgd2l0aCAz MmJpdCBDUDE1IHJlZ2lzdGVycy4KPiBXZSBkZWFsIHdpdGggdGhpcyBleGFjdCBpc3N1ZSBpbiBh IHZlcnkgZGlmZmVyZW50IHdheSBmb3Igb3RoZXIKPiBDUDE1IHJlZ3MsIGJ5IGFkanVzdGluZyB0 aGUgaW5kZXggaW4gdGhlIHN5c19yZWdzIGFycmF5IChzZWUgdGhlCj4gd2F5IHdlIGhhbmRsZSB0 aGUgVk0gcmVncykuCj4gCj4gSG93IGFib3V0IHNvbWV0aGluZyBsaWtlIHRoaXMgKHVudGVzdGVk KToKCltsaWtlIGFjY2Vzc192bV9yZWcoKSBkb2VzXQoKU3VyZSwgSSdsbCBnaXZlIHRoYXQgYSB0 ZXN0IGFuZCByZS1wb3N0IGl0LgoKCj4gSWRlYWxseSwgSSdkIGxpa2UgdGhlIGNvcmUgc3lzX3Jl ZyBjb2RlIHRvIGRlYWwgd2l0aCB0aGlzIHNvcnQKPiBvZiBmdW5uaWVzLCBidXQgSSdtIHRyeWlu ZyB0byBrZWVwIHRoZSBjaGFuZ2UgbWluaW1hbC4uLgoKUm9sbCB0aGlzICcvMicgYW5kIHVwcGVy L2xvd2VyIGJpdHMgc3R1ZmYgaW50byBhIHZjcHVfd3JpdGVfY3AxNV9yZWcoKSB0aGF0IGNhbGxz CnZjcHVfd3JpdGVfc3lzX3JlZygpPyAoL21lIGh1bnRzIG91dCB0aGUgdG9kbyBsaXN0KQoKClRo YW5rcywKCkphbWVzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmt2bWFybSBtYWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRw czovL2xpc3RzLmNzLmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0B01C433E1 for ; Thu, 28 May 2020 11:59:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C47B215A4 for ; Thu, 28 May 2020 11:59:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aHKOM6/X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C47B215A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WiXHlXGPFZOE4Xd1ckd6BOESEJbR3OfrsXRD9vPPYCs=; b=aHKOM6/XcxaaZI 8dHyVkhtCmVlBa7AGoCFKBBsIxP/NkMguXeU7TZtacaXQqeTRMtkpwTdb2MIyICR4fA2hHMuBQyVf Alq5VuBErD6Z8dJUVEFbO00TYMrFcnXQ0ppDItUTAFhLbt7P7R0ITPbWtvLTaigRPYWruKcI4hPR9 6k8MWy4Yj03Simrq/QGbU2lRRbe1A4GGWFknfOygzKxfmcmB7Xd0d4aG1t3koaxgppM1NAx/m5agj 8BGYfkhxIPwXCVd2z+Sg3UERHBeMPa8ia/rQ2PMQDDTCqN+fpSXPvwTEgPCCxP+cnSragEIjmH0PD E+SJslWcK61D8rEWbxEQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeHCJ-000497-7U; Thu, 28 May 2020 11:59:43 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeHCE-00048G-W0 for linux-arm-kernel@lists.infradead.org; Thu, 28 May 2020 11:59:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A4602D6E; Thu, 28 May 2020 04:59:35 -0700 (PDT) Received: from [192.168.0.14] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D37283F6C4; Thu, 28 May 2020 04:59:34 -0700 (PDT) Subject: Re: [PATCH 1/3] KVM: arm64: Stop writing aarch32's CSSELR into ACTLR To: Marc Zyngier References: <20200526161834.29165-1-james.morse@arm.com> <20200526161834.29165-2-james.morse@arm.com> <4be0c0b654f7d7c1efe9f52efb856bd8@kernel.org> From: James Morse Message-ID: <09dca8e9-c548-43fd-a95b-747a77f19e02@arm.com> Date: Thu, 28 May 2020 12:59:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <4be0c0b654f7d7c1efe9f52efb856bd8@kernel.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_045939_069853_0958B3C8 X-CRM114-Status: GOOD ( 16.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Julien Thierry , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Suzuki K Poulose Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWFyYywKCk9uIDI4LzA1LzIwMjAgMDk6NTcsIE1hcmMgWnluZ2llciB3cm90ZToKPiBPbiAy MDIwLTA1LTI2IDE3OjE4LCBKYW1lcyBNb3JzZSB3cm90ZToKPj4gYWNjZXNzX2Nzc2VscigpIHVz ZXMgdGhlIDMyYml0IHItPnJlZyB2YWx1ZSB0byBhY2Nlc3MgdGhlIDY0Yml0IGFycmF5LAo+PiBz byByZWFkcyBhbmQgd3JpdGUgdGhlIHdyb25nIHZhbHVlLiBzeXNfcmVnc1s0XSwgaXMgQUNUTFJf RUwxLCB3aGljaAo+PiBpcyBzdWJzZXF1ZW50bHkgc2F2ZS9yZXN0b3JlZCB3aGVuIHdlIGVudGVy IHRoZSBndWVzdC4KCj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jIGIv YXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYwo+PiBpbmRleCA1MWRiOTM0NzAyYjYuLjJlZGE1Mzlm MzI4MSAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYwo+PiArKysgYi9h cmNoL2FybTY0L2t2bS9zeXNfcmVncy5jCj4+IEBAIC0yMDYwLDcgKzIwNjAsNyBAQCBzdGF0aWMg Y29uc3Qgc3RydWN0IHN5c19yZWdfZGVzYyBjcDE1X3JlZ3NbXSA9IHsKPj4KPj4gwqDCoMKgwqAg eyBPcDEoMSksIENSbiggMCksIENSbSggMCksIE9wMigwKSwgYWNjZXNzX2Njc2lkciB9LAo+PiDC oMKgwqDCoCB7IE9wMSgxKSwgQ1JuKCAwKSwgQ1JtKCAwKSwgT3AyKDEpLCBhY2Nlc3NfY2xpZHIg fSwKPj4gLcKgwqDCoCB7IE9wMSgyKSwgQ1JuKCAwKSwgQ1JtKCAwKSwgT3AyKDApLCBhY2Nlc3Nf Y3NzZWxyLCBOVUxMLCBjMF9DU1NFTFIgfSwKPj4gK8KgwqDCoCB7IE9wMSgyKSwgQ1JuKCAwKSwg Q1JtKCAwKSwgT3AyKDApLCBhY2Nlc3NfY3NzZWxyX2VsMSwgTlVMTCwgQ1NTRUxSX0VMMSB9LAo+ PiDCoH07Cgo+IFRoaXMgaXMgYSBkZXBhcnR1cmUgZnJvbSB0aGUgd2F5IHdlIGRlYWwgd2l0aCAz MmJpdCBDUDE1IHJlZ2lzdGVycy4KPiBXZSBkZWFsIHdpdGggdGhpcyBleGFjdCBpc3N1ZSBpbiBh IHZlcnkgZGlmZmVyZW50IHdheSBmb3Igb3RoZXIKPiBDUDE1IHJlZ3MsIGJ5IGFkanVzdGluZyB0 aGUgaW5kZXggaW4gdGhlIHN5c19yZWdzIGFycmF5IChzZWUgdGhlCj4gd2F5IHdlIGhhbmRsZSB0 aGUgVk0gcmVncykuCj4gCj4gSG93IGFib3V0IHNvbWV0aGluZyBsaWtlIHRoaXMgKHVudGVzdGVk KToKCltsaWtlIGFjY2Vzc192bV9yZWcoKSBkb2VzXQoKU3VyZSwgSSdsbCBnaXZlIHRoYXQgYSB0 ZXN0IGFuZCByZS1wb3N0IGl0LgoKCj4gSWRlYWxseSwgSSdkIGxpa2UgdGhlIGNvcmUgc3lzX3Jl ZyBjb2RlIHRvIGRlYWwgd2l0aCB0aGlzIHNvcnQKPiBvZiBmdW5uaWVzLCBidXQgSSdtIHRyeWlu ZyB0byBrZWVwIHRoZSBjaGFuZ2UgbWluaW1hbC4uLgoKUm9sbCB0aGlzICcvMicgYW5kIHVwcGVy L2xvd2VyIGJpdHMgc3R1ZmYgaW50byBhIHZjcHVfd3JpdGVfY3AxNV9yZWcoKSB0aGF0IGNhbGxz CnZjcHVfd3JpdGVfc3lzX3JlZygpPyAoL21lIGh1bnRzIG91dCB0aGUgdG9kbyBsaXN0KQoKClRo YW5rcywKCkphbWVzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==