From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80836C00A5A for ; Tue, 17 Jan 2023 23:49:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.480014.744162 (Exim 4.92) (envelope-from ) id 1pHvhg-0003nL-9M; Tue, 17 Jan 2023 23:49:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 480014.744162; Tue, 17 Jan 2023 23:49:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pHvhg-0003nE-6Q; Tue, 17 Jan 2023 23:49:20 +0000 Received: by outflank-mailman (input) for mailman id 480014; Tue, 17 Jan 2023 23:49:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pHvhf-0003n8-7d for xen-devel@lists.xenproject.org; Tue, 17 Jan 2023 23:49:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pHvhf-0007Tn-0P; Tue, 17 Jan 2023 23:49:19 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pHvhe-0004C2-Rn; Tue, 17 Jan 2023 23:49:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=GmKGGz/kAkBzBcQfubJ9rBng+6oHr9IVOCK8rMVVnTs=; b=6tzmBDNsjaCju8v4G7kX1fzjVQ 5NiXqQle5to/o6HGdvax8IlcM5fzkE18YFHEXKgJzAonmOgSrdrepnjE+662Tw7u11D2GaquSylpW lP6fNWeV+YULLfRdbQ7EuKQSpcW4AmxzvUb8KDMAaPr+QWfgJKMuPsSoafoTUylOvkN0=; Message-ID: <09e4c2ef-eddf-e798-573b-68744a061d68@xen.org> Date: Tue, 17 Jan 2023 23:49:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 08/40] xen/arm: use PA == VA for EARLY_UART_VIRTUAL_ADDRESS on Armv-8R To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-9-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20230113052914.3845596-9-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 13/01/2023 05:28, Penny Zheng wrote: > From: Wei Chen > > There is no VMSA support on Armv8-R AArch64, so we can not map early > UART to FIXMAP_CONSOLE. Instead, we use PA == VA to define > EARLY_UART_VIRTUAL_ADDRESS on Armv8-R AArch64. > > Signed-off-by: Wei Chen Your signed-off-by is missing. > --- > 1. New patch > --- > xen/arch/arm/include/asm/early_printk.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/xen/arch/arm/include/asm/early_printk.h b/xen/arch/arm/include/asm/early_printk.h > index c5149b2976..44a230853f 100644 > --- a/xen/arch/arm/include/asm/early_printk.h > +++ b/xen/arch/arm/include/asm/early_printk.h > @@ -15,10 +15,22 @@ > > #ifdef CONFIG_EARLY_PRINTK > > +#ifdef CONFIG_ARM_V8R Shouldn't this be CONFIG_HAS_MPU? > + > +/* > + * For Armv-8r, there is not VMSA support in EL2, so we use VA == PA s/not/no/ > + * for EARLY_UART_VIRTUAL_ADDRESS. > + */ > +#define EARLY_UART_VIRTUAL_ADDRESS CONFIG_EARLY_UART_BASE_ADDRESS > + > +#else > + > /* need to add the uart address offset in page to the fixmap address */ > #define EARLY_UART_VIRTUAL_ADDRESS \ > (FIXMAP_ADDR(FIXMAP_CONSOLE) + (CONFIG_EARLY_UART_BASE_ADDRESS & ~PAGE_MASK)) > > +#endif /* CONFIG_ARM_V8R */ > + > #endif /* !CONFIG_EARLY_PRINTK */ > > #endif Cheers, -- Julien Grall