From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C541C433F5 for ; Tue, 15 Feb 2022 19:47:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234916AbiBOTrz (ORCPT ); Tue, 15 Feb 2022 14:47:55 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:33828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232560AbiBOTry (ORCPT ); Tue, 15 Feb 2022 14:47:54 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C57CDEAD for ; Tue, 15 Feb 2022 11:47:44 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 3ABF71F449B2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644954463; bh=+wF39v+i9uxNDfcWDhypRIJ638tyJz2rqw6HQGEMdlQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=d3zn21eufiv2dWW4/zfxwV3et55Zy0Hdl5er4draQrp9tYcMKEmp7DJwOUM524+48 mBWMq1rflGWirNr/0VaAEkK1rWaaxQWAo6plZcUOdk0527vp9Xus39ypxCTCMV3TFu YEMLg33T4FTWV0+RvlQiWq4W3ywruzN+9dpGOPjLCffuICXcjjZUopehbyhdYhwKdl UPPHWlpcoWwaKFHdAOFCP3IWD+ylbYl7TugczKA8EpPWeP4zWJfbmQAZV27UM1w6uG fXbS6U2JrEbQ2tvFk3zQDwcT2nKZcphvCGUmU3iZDySC4Gjk43oZn6IKmzc35EppMK BCAedlwL6vjFg== Message-ID: <09ed17be-5780-011b-6801-87a5afd4e907@collabora.com> Date: Tue, 15 Feb 2022 22:47:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 22/23] drm: rockchip: Add VOP2 driver Content-Language: en-US To: Sascha Hauer , dri-devel@lists.freedesktop.org Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Andy Yan , linux-arm-kernel@lists.infradead.org References: <20220209095350.2104049-1-s.hauer@pengutronix.de> <20220209095350.2104049-23-s.hauer@pengutronix.de> From: Dmitry Osipenko In-Reply-To: <20220209095350.2104049-23-s.hauer@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 09.02.2022 12:53, Sascha Hauer пишет: > +static irqreturn_t vop2_isr(int irq, void *data) > +{ > + struct vop2 *vop2 = data; > + const struct vop2_data *vop2_data = vop2->data; > + uint32_t axi_irqs[VOP2_SYS_AXI_BUS_NUM]; > + int ret = IRQ_NONE; > + int i; > + > + /* > + * The irq is shared with the iommu. If the runtime-pm state of the > + * vop2-device is disabled the irq has to be targeted at the iommu. > + */ > + if (!pm_runtime_get_if_in_use(vop2->dev)) > + return IRQ_NONE; > + > + for (i = 0; i < vop2_data->nr_vps; i++) { > + struct vop2_video_port *vp = &vop2->vps[i]; > + struct drm_crtc *crtc = &vp->crtc; > + uint32_t irqs; > + > + irqs = vop2_readl(vop2, RK3568_VP_INT_STATUS(vp->id)); > + vop2_writel(vop2, RK3568_VP_INT_CLR(vp->id), irqs << 16 | irqs); > + > + if (irqs & VP_INT_DSP_HOLD_VALID) { > + complete(&vp->dsp_hold_completion); > + ret = IRQ_HANDLED; > + } > + > + if (irqs & VP_INT_FS_FIELD) { > + unsigned long flags; > + > + drm_crtc_handle_vblank(crtc); > + spin_lock_irqsave(&crtc->dev->event_lock, flags); IRQ is disabled inside of ISR(), no need to save/restore the flags. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 818FFC433EF for ; Tue, 15 Feb 2022 19:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s8bQDfilh0E6nsPXNOdvlR09Am08xUFK5RNNfjOE9FU=; b=l266NOqKxJYcBz ZfkueaRR9qx9SsjGaj/7fJ8unFEuEwJf1sL7cjRN+cy1a8KSVG4g6icKd4/X5rppMeYVWfxCT7N67 cD+GkO3vvWZqWh58Wt5qQsWPJoWINGBPkfjSUMURT0KyN3CF5mxtU7H+j9YsI+q7xmVWoIhdVJBrO 6rIIPhXQYg6Yp6IN88lhYLZ2aF7MHz5dDa1ZjoRHqB2c9wgQfXg9fGnLyrejqnY/x4I97kakonM9t Z38IvA8IADmB3hfKvZScjjGkb2jChJJbEi+vFNdAxqMqh+cPCnA5eZAbN5nkR/7Z8VoYvPZdGV72h TLjO+lixDQ3Sohgss03A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK3nx-004OlK-LW; Tue, 15 Feb 2022 19:48:05 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK3nc-004Obe-3y; Tue, 15 Feb 2022 19:47:45 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 3ABF71F449B2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644954463; bh=+wF39v+i9uxNDfcWDhypRIJ638tyJz2rqw6HQGEMdlQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=d3zn21eufiv2dWW4/zfxwV3et55Zy0Hdl5er4draQrp9tYcMKEmp7DJwOUM524+48 mBWMq1rflGWirNr/0VaAEkK1rWaaxQWAo6plZcUOdk0527vp9Xus39ypxCTCMV3TFu YEMLg33T4FTWV0+RvlQiWq4W3ywruzN+9dpGOPjLCffuICXcjjZUopehbyhdYhwKdl UPPHWlpcoWwaKFHdAOFCP3IWD+ylbYl7TugczKA8EpPWeP4zWJfbmQAZV27UM1w6uG fXbS6U2JrEbQ2tvFk3zQDwcT2nKZcphvCGUmU3iZDySC4Gjk43oZn6IKmzc35EppMK BCAedlwL6vjFg== Message-ID: <09ed17be-5780-011b-6801-87a5afd4e907@collabora.com> Date: Tue, 15 Feb 2022 22:47:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 22/23] drm: rockchip: Add VOP2 driver Content-Language: en-US To: Sascha Hauer , dri-devel@lists.freedesktop.org Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Andy Yan , linux-arm-kernel@lists.infradead.org References: <20220209095350.2104049-1-s.hauer@pengutronix.de> <20220209095350.2104049-23-s.hauer@pengutronix.de> From: Dmitry Osipenko In-Reply-To: <20220209095350.2104049-23-s.hauer@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_114744_331150_E5CE1722 X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org CjA5LjAyLjIwMjIgMTI6NTMsIFNhc2NoYSBIYXVlciDQv9C40YjQtdGCOgo+ICtzdGF0aWMgaXJx cmV0dXJuX3Qgdm9wMl9pc3IoaW50IGlycSwgdm9pZCAqZGF0YSkKPiArewo+ICsJc3RydWN0IHZv cDIgKnZvcDIgPSBkYXRhOwo+ICsJY29uc3Qgc3RydWN0IHZvcDJfZGF0YSAqdm9wMl9kYXRhID0g dm9wMi0+ZGF0YTsKPiArCXVpbnQzMl90IGF4aV9pcnFzW1ZPUDJfU1lTX0FYSV9CVVNfTlVNXTsK PiArCWludCByZXQgPSBJUlFfTk9ORTsKPiArCWludCBpOwo+ICsKPiArCS8qCj4gKwkgKiBUaGUg aXJxIGlzIHNoYXJlZCB3aXRoIHRoZSBpb21tdS4gSWYgdGhlIHJ1bnRpbWUtcG0gc3RhdGUgb2Yg dGhlCj4gKwkgKiB2b3AyLWRldmljZSBpcyBkaXNhYmxlZCB0aGUgaXJxIGhhcyB0byBiZSB0YXJn ZXRlZCBhdCB0aGUgaW9tbXUuCj4gKwkgKi8KPiArCWlmICghcG1fcnVudGltZV9nZXRfaWZfaW5f dXNlKHZvcDItPmRldikpCj4gKwkJcmV0dXJuIElSUV9OT05FOwo+ICsKPiArCWZvciAoaSA9IDA7 IGkgPCB2b3AyX2RhdGEtPm5yX3ZwczsgaSsrKSB7Cj4gKwkJc3RydWN0IHZvcDJfdmlkZW9fcG9y dCAqdnAgPSAmdm9wMi0+dnBzW2ldOwo+ICsJCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9ICZ2cC0+ Y3J0YzsKPiArCQl1aW50MzJfdCBpcnFzOwo+ICsKPiArCQlpcnFzID0gdm9wMl9yZWFkbCh2b3Ay LCBSSzM1NjhfVlBfSU5UX1NUQVRVUyh2cC0+aWQpKTsKPiArCQl2b3AyX3dyaXRlbCh2b3AyLCBS SzM1NjhfVlBfSU5UX0NMUih2cC0+aWQpLCBpcnFzIDw8IDE2IHwgaXJxcyk7Cj4gKwo+ICsJCWlm IChpcnFzICYgVlBfSU5UX0RTUF9IT0xEX1ZBTElEKSB7Cj4gKwkJCWNvbXBsZXRlKCZ2cC0+ZHNw X2hvbGRfY29tcGxldGlvbik7Cj4gKwkJCXJldCA9IElSUV9IQU5ETEVEOwo+ICsJCX0KPiArCj4g KwkJaWYgKGlycXMgJiBWUF9JTlRfRlNfRklFTEQpIHsKPiArCQkJdW5zaWduZWQgbG9uZyBmbGFn czsKPiArCj4gKwkJCWRybV9jcnRjX2hhbmRsZV92YmxhbmsoY3J0Yyk7Cj4gKwkJCXNwaW5fbG9j a19pcnFzYXZlKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2ssIGZsYWdzKTsKCklSUSBpcyBkaXNhYmxl ZCBpbnNpZGUgb2YgSVNSKCksIG5vIG5lZWQgdG8gc2F2ZS9yZXN0b3JlIHRoZSBmbGFncy4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tj aGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 522BFC433FE for ; Tue, 15 Feb 2022 19:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rzUdiEujUVExi2s9T4KC8Bya297evoEg3L7HVgE8SXI=; b=HExDvcTP7scoCv sDXA6H6DbF/pbatPweNUCiHgUeMOS8VcKdCR6HXZR33ckcmHH55UdnCn6fKEPnqI03PVT8pbZvley Ym6xaCTGIOfjHvbPTTvx3fvICCVTI4FUU5cK86/ucTi+AxiaGCQFyZflOcMneeaZNsfYZbrZ9lnMG GOSJz6bctduSH71QKLUqquYLLjjv3M++iHLMLEQbh2ONjGk0PVq2QySnSslxY1sQwCJfk0xTaQVww 1SepJzOuwFS5Tyw0jCbGIZ59SYpdZYSajYgqnyfuSG01S8Laq6My8vsxQwl93Wuq/bufi9WS6v8Mr fy31yoh3kilwLQissgAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK3ng-004Odk-D3; Tue, 15 Feb 2022 19:47:48 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK3nc-004Obe-3y; Tue, 15 Feb 2022 19:47:45 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 3ABF71F449B2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644954463; bh=+wF39v+i9uxNDfcWDhypRIJ638tyJz2rqw6HQGEMdlQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=d3zn21eufiv2dWW4/zfxwV3et55Zy0Hdl5er4draQrp9tYcMKEmp7DJwOUM524+48 mBWMq1rflGWirNr/0VaAEkK1rWaaxQWAo6plZcUOdk0527vp9Xus39ypxCTCMV3TFu YEMLg33T4FTWV0+RvlQiWq4W3ywruzN+9dpGOPjLCffuICXcjjZUopehbyhdYhwKdl UPPHWlpcoWwaKFHdAOFCP3IWD+ylbYl7TugczKA8EpPWeP4zWJfbmQAZV27UM1w6uG fXbS6U2JrEbQ2tvFk3zQDwcT2nKZcphvCGUmU3iZDySC4Gjk43oZn6IKmzc35EppMK BCAedlwL6vjFg== Message-ID: <09ed17be-5780-011b-6801-87a5afd4e907@collabora.com> Date: Tue, 15 Feb 2022 22:47:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 22/23] drm: rockchip: Add VOP2 driver Content-Language: en-US To: Sascha Hauer , dri-devel@lists.freedesktop.org Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Andy Yan , linux-arm-kernel@lists.infradead.org References: <20220209095350.2104049-1-s.hauer@pengutronix.de> <20220209095350.2104049-23-s.hauer@pengutronix.de> From: Dmitry Osipenko In-Reply-To: <20220209095350.2104049-23-s.hauer@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_114744_331150_E5CE1722 X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CjA5LjAyLjIwMjIgMTI6NTMsIFNhc2NoYSBIYXVlciDQv9C40YjQtdGCOgo+ICtzdGF0aWMgaXJx cmV0dXJuX3Qgdm9wMl9pc3IoaW50IGlycSwgdm9pZCAqZGF0YSkKPiArewo+ICsJc3RydWN0IHZv cDIgKnZvcDIgPSBkYXRhOwo+ICsJY29uc3Qgc3RydWN0IHZvcDJfZGF0YSAqdm9wMl9kYXRhID0g dm9wMi0+ZGF0YTsKPiArCXVpbnQzMl90IGF4aV9pcnFzW1ZPUDJfU1lTX0FYSV9CVVNfTlVNXTsK PiArCWludCByZXQgPSBJUlFfTk9ORTsKPiArCWludCBpOwo+ICsKPiArCS8qCj4gKwkgKiBUaGUg aXJxIGlzIHNoYXJlZCB3aXRoIHRoZSBpb21tdS4gSWYgdGhlIHJ1bnRpbWUtcG0gc3RhdGUgb2Yg dGhlCj4gKwkgKiB2b3AyLWRldmljZSBpcyBkaXNhYmxlZCB0aGUgaXJxIGhhcyB0byBiZSB0YXJn ZXRlZCBhdCB0aGUgaW9tbXUuCj4gKwkgKi8KPiArCWlmICghcG1fcnVudGltZV9nZXRfaWZfaW5f dXNlKHZvcDItPmRldikpCj4gKwkJcmV0dXJuIElSUV9OT05FOwo+ICsKPiArCWZvciAoaSA9IDA7 IGkgPCB2b3AyX2RhdGEtPm5yX3ZwczsgaSsrKSB7Cj4gKwkJc3RydWN0IHZvcDJfdmlkZW9fcG9y dCAqdnAgPSAmdm9wMi0+dnBzW2ldOwo+ICsJCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9ICZ2cC0+ Y3J0YzsKPiArCQl1aW50MzJfdCBpcnFzOwo+ICsKPiArCQlpcnFzID0gdm9wMl9yZWFkbCh2b3Ay LCBSSzM1NjhfVlBfSU5UX1NUQVRVUyh2cC0+aWQpKTsKPiArCQl2b3AyX3dyaXRlbCh2b3AyLCBS SzM1NjhfVlBfSU5UX0NMUih2cC0+aWQpLCBpcnFzIDw8IDE2IHwgaXJxcyk7Cj4gKwo+ICsJCWlm IChpcnFzICYgVlBfSU5UX0RTUF9IT0xEX1ZBTElEKSB7Cj4gKwkJCWNvbXBsZXRlKCZ2cC0+ZHNw X2hvbGRfY29tcGxldGlvbik7Cj4gKwkJCXJldCA9IElSUV9IQU5ETEVEOwo+ICsJCX0KPiArCj4g KwkJaWYgKGlycXMgJiBWUF9JTlRfRlNfRklFTEQpIHsKPiArCQkJdW5zaWduZWQgbG9uZyBmbGFn czsKPiArCj4gKwkJCWRybV9jcnRjX2hhbmRsZV92YmxhbmsoY3J0Yyk7Cj4gKwkJCXNwaW5fbG9j a19pcnFzYXZlKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2ssIGZsYWdzKTsKCklSUSBpcyBkaXNhYmxl ZCBpbnNpZGUgb2YgSVNSKCksIG5vIG5lZWQgdG8gc2F2ZS9yZXN0b3JlIHRoZSBmbGFncy4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 080AAC433EF for ; Wed, 16 Feb 2022 08:23:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5319810E8E1; Wed, 16 Feb 2022 08:23:46 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3DB9110E539 for ; Tue, 15 Feb 2022 19:47:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 3ABF71F449B2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644954463; bh=+wF39v+i9uxNDfcWDhypRIJ638tyJz2rqw6HQGEMdlQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=d3zn21eufiv2dWW4/zfxwV3et55Zy0Hdl5er4draQrp9tYcMKEmp7DJwOUM524+48 mBWMq1rflGWirNr/0VaAEkK1rWaaxQWAo6plZcUOdk0527vp9Xus39ypxCTCMV3TFu YEMLg33T4FTWV0+RvlQiWq4W3ywruzN+9dpGOPjLCffuICXcjjZUopehbyhdYhwKdl UPPHWlpcoWwaKFHdAOFCP3IWD+ylbYl7TugczKA8EpPWeP4zWJfbmQAZV27UM1w6uG fXbS6U2JrEbQ2tvFk3zQDwcT2nKZcphvCGUmU3iZDySC4Gjk43oZn6IKmzc35EppMK BCAedlwL6vjFg== Message-ID: <09ed17be-5780-011b-6801-87a5afd4e907@collabora.com> Date: Tue, 15 Feb 2022 22:47:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 22/23] drm: rockchip: Add VOP2 driver Content-Language: en-US To: Sascha Hauer , dri-devel@lists.freedesktop.org References: <20220209095350.2104049-1-s.hauer@pengutronix.de> <20220209095350.2104049-23-s.hauer@pengutronix.de> From: Dmitry Osipenko In-Reply-To: <20220209095350.2104049-23-s.hauer@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Wed, 16 Feb 2022 08:23:45 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , kernel@pengutronix.de, Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , Peter Geis , Andy Yan , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" 09.02.2022 12:53, Sascha Hauer пишет: > +static irqreturn_t vop2_isr(int irq, void *data) > +{ > + struct vop2 *vop2 = data; > + const struct vop2_data *vop2_data = vop2->data; > + uint32_t axi_irqs[VOP2_SYS_AXI_BUS_NUM]; > + int ret = IRQ_NONE; > + int i; > + > + /* > + * The irq is shared with the iommu. If the runtime-pm state of the > + * vop2-device is disabled the irq has to be targeted at the iommu. > + */ > + if (!pm_runtime_get_if_in_use(vop2->dev)) > + return IRQ_NONE; > + > + for (i = 0; i < vop2_data->nr_vps; i++) { > + struct vop2_video_port *vp = &vop2->vps[i]; > + struct drm_crtc *crtc = &vp->crtc; > + uint32_t irqs; > + > + irqs = vop2_readl(vop2, RK3568_VP_INT_STATUS(vp->id)); > + vop2_writel(vop2, RK3568_VP_INT_CLR(vp->id), irqs << 16 | irqs); > + > + if (irqs & VP_INT_DSP_HOLD_VALID) { > + complete(&vp->dsp_hold_completion); > + ret = IRQ_HANDLED; > + } > + > + if (irqs & VP_INT_FS_FIELD) { > + unsigned long flags; > + > + drm_crtc_handle_vblank(crtc); > + spin_lock_irqsave(&crtc->dev->event_lock, flags); IRQ is disabled inside of ISR(), no need to save/restore the flags.