From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFA7EC433EF for ; Mon, 28 Mar 2022 20:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232075AbiC1U6y (ORCPT ); Mon, 28 Mar 2022 16:58:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229649AbiC1U6t (ORCPT ); Mon, 28 Mar 2022 16:58:49 -0400 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 486B6689B2; Mon, 28 Mar 2022 13:57:08 -0700 (PDT) Received: by mail-oi1-x236.google.com with SMTP id e189so16980633oia.8; Mon, 28 Mar 2022 13:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:user-agent:in-reply-to:references :message-id:mime-version:content-transfer-encoding; bh=JcBVwR8XLDQBSP8SxdAoaozEKj20bLEdjh0fLBcT41c=; b=pdQ/Q1QGUGjzOJukBJjP4U5oOV6QzltQSsx0ywlFcFCxlHmErpakQ71Ntftr133p/8 FiUxg7uBYqulSwcKApicZjUwChuTc//+n5LXj0fDgjPJOQgU9TPkUxpjMFbVGtlg5CDM Xi0ug5YTneIlO2qI5h32eR0TqUbgrRcZLSF8VtxcWrpE1NVLGphOT31Ia4hKaege9aqD 0SKsvPhD/qQDbCjCZm2aT6XzhjbpxJZC7TE+umvo+Qv29z2Zp71EaiOQNMPIxeMayaQ/ E23mZCjnjnXRN/Nw377YmYdX7i74xgj5uxtYGqNUDtJ7qCI9VG+Rom988/z8VlI1XGy3 ObGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:user-agent:in-reply-to :references:message-id:mime-version:content-transfer-encoding; bh=JcBVwR8XLDQBSP8SxdAoaozEKj20bLEdjh0fLBcT41c=; b=UqghicebuQWKqCYsIFwuYhTB4oPR8fnlN1jxvk6NYIsCryHNL8IoC9g4pq4Pw6zDAZ fFG5dhcO/ClWPFlN904nDKMvDYUgP0fQq5vU037Xpvgth1yUUkJLgMgfc+vlPfzix4QV XaHGDFU51ewg7eQfh8coXRWb9jXH0AAjzdtQMWuXBcWrFMPlrghpDYYWviFKHTC2iyaN rCY+CJVwXvfaK7fNWVH4mG546YapXBia3SvFF4C+nuo8VgmEj0OoNzryZ3xH0oUC33Zq ZyWtNYzxSeQCy06VPwmXYnp0f8yEHSQrwYyZ0boOGSnAKy1autngh1eazKphdYDfIhD6 +mjA== X-Gm-Message-State: AOAM5332vlfkCiv5z0T0cOS+TdPbmX1/eSMQKfUqYmxn29Pr6yqPFSbL g7ObALAXdyLDW9XYFJR1xio= X-Google-Smtp-Source: ABdhPJx3MOEnr/6Eihy5bZZNDW1D7o+VpA7ydx7vu88ZTQ2eahIrFjmv3Vruk4sayEBSpk+UbOV7bQ== X-Received: by 2002:aca:aa55:0:b0:2ee:e8e8:cf80 with SMTP id t82-20020acaaa55000000b002eee8e8cf80mr581870oie.64.1648501027588; Mon, 28 Mar 2022 13:57:07 -0700 (PDT) Received: from [127.0.0.1] ([187.19.239.165]) by smtp.gmail.com with ESMTPSA id u14-20020a4ad0ce000000b0032174de7c2csm7414197oor.8.2022.03.28.13.57.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Mar 2022 13:57:06 -0700 (PDT) Date: Mon, 28 Mar 2022 17:56:07 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers , Arnaldo Carvalho de Melo CC: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , John Garry , Will Deacon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Kajol Jain , James Clark , German Gomez , Adrian Hunter , Riccardo Mancini , Andi Kleen , Alexey Bayduraev , Alexander Antonov , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH 2/5] perf cpumap: More cpu map reuse by merge. User-Agent: K-9 Mail for Android In-Reply-To: References: <20220328062414.1893550-1-irogers@google.com> <20220328062414.1893550-3-irogers@google.com> Message-ID: <0A053E2F-284B-4C1B-B09E-AC082916DD0E@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On March 28, 2022 5:50:21 PM GMT-03:00, Ian Rogers = wrote: >On Mon, Mar 28, 2022 at 1:26 PM Arnaldo Carvalho de Melo > wrote: >> >> Em Sun, Mar 27, 2022 at 11:24:11PM -0700, Ian Rogers escreveu: >> > perf_cpu_map__merge will reuse one of its arguments if they are equal= or >> > the other argument is NULL=2E The arguments could be reused if it is = known >> > one set of values is a subset of the other=2E For example, a map of 0= -1 >> > and a map of just 0 when merged yields the map of 0-1=2E Currently a = new >> > map is created rather than adding a reference count to the original 0= -1 >> > map=2E >> > >> > Signed-off-by: Ian Rogers >> > --- >> > tools/lib/perf/cpumap=2Ec | 38 ++++++++++++++++++++++++++++---------= - >> > 1 file changed, 28 insertions(+), 10 deletions(-) >> > >> > diff --git a/tools/lib/perf/cpumap=2Ec b/tools/lib/perf/cpumap=2Ec >> > index ee66760f1e63=2E=2E953bc50b0e41 100644 >> > --- a/tools/lib/perf/cpumap=2Ec >> > +++ b/tools/lib/perf/cpumap=2Ec >> > @@ -319,6 +319,29 @@ struct perf_cpu perf_cpu_map__max(struct perf_cp= u_map *map) >> > return map->nr > 0 ? map->map[map->nr - 1] : result; >> > } >> > >> > +/** Is 'b' a subset of 'a'=2E */ >> > +static bool perf_cpu_map__is_subset(const struct perf_cpu_map *a, >> > + const struct perf_cpu_map *b) >> > +{ >> > + int i, j; >> > + >> > + if (a =3D=3D b || !b) >> > + return true; >> > + if (!a || b->nr > a->nr) >> > + return false; >> > + j =3D 0; >> > + for (i =3D 0; i < a->nr; i++) { >> >> Since the kernel bumped the minimum gcc version to one that supports >> declaring loop variables locally and that perf has been using this sinc= e >> forever: >> >> =E2=AC=A2[acme@toolbox perf]$ grep -r '(int [[:alpha:]] =3D 0;' tools/p= erf >> tools/perf/util/block-info=2Ec: for (int i =3D 0; i < nr_hpps; i++) >> tools/perf/util/block-info=2Ec: for (int i =3D 0; i < nr_hpps; i++) { >> tools/perf/util/block-info=2Ec: for (int i =3D 0; i < nr_reps; i++) >> tools/perf/util/stream=2Ec: for (int i =3D 0; i < nr_evsel; i++) >> tools/perf/util/stream=2Ec: for (int i =3D 0; i < nr_evsel; i++) = { >> tools/perf/util/stream=2Ec: for (int i =3D 0; i < els->nr_evsel; = i++) { >> tools/perf/util/stream=2Ec: for (int i =3D 0; i < es_pair->nr_str= eams; i++) { >> tools/perf/util/stream=2Ec: for (int i =3D 0; i < es_base->nr_str= eams; i++) { >> tools/perf/util/cpumap=2Ec: for (int j =3D 0; j < c->nr; = j++) { >> tools/perf/util/mem-events=2Ec: for (int j =3D 0; j < PERF_MEM_EVENTS= __MAX; j++) { >> tools/perf/util/header=2Ec: for (int i =3D 0; i < ff->ph->env=2En= r_hybrid_cpc_nodes; i++) { >> tools/perf/builtin-diff=2Ec: for (int i =3D 0; i < num; i++) >> tools/perf/builtin-diff=2Ec: for (int i =3D 0; i < pair->b= lock_info->num; i++) { >> tools/perf/builtin-stat=2Ec: for (int i =3D 0; i < perf_cpu_map__n= r(a->core=2Ecpus); i++) { >> =E2=AC=A2[acme@toolbox perf]$ >> >> And this builds on all my test containers, please use: >> >> for (int i =3D 0, j =3D 0; i < a->nr; i++) >> >> In this case to make the source code more compact=2E > >Ack=2E We still need to declare 'j' and it is a bit weird to declare j >before i=2E Fwiw, Making=2Econfig has the CORE_CFLAGS set to gnu99, but >declaring in the loop is clearly valid in c99=2E > >> > + if (a->map[i]=2Ecpu > b->map[j]=2Ecpu) >> > + return false; >> > + if (a->map[i]=2Ecpu =3D=3D b->map[j]=2Ecpu) { >> > + j++; >> > + if (j =3D=3D b->nr) >> > + return true; >> >> Ok, as its guaranteed that cpu_maps are ordered=2E >> >> > + } >> > + } >> > + return false; >> > +} >> > + >> > /* >> > * Merge two cpumaps >> > * >> > @@ -335,17 +358,12 @@ struct perf_cpu_map *perf_cpu_map__merge(struct= perf_cpu_map *orig, >> > int i, j, k; >> > struct perf_cpu_map *merged; >> > >> > - if (!orig && !other) >> > - return NULL; >> > - if (!orig) { >> > - perf_cpu_map__get(other); >> > - return other; >> > - } >> > - if (!other) >> > - return orig; >> > - if (orig->nr =3D=3D other->nr && >> > - !memcmp(orig->map, other->map, orig->nr * sizeof(struct per= f_cpu))) >> > + if (perf_cpu_map__is_subset(orig, other)) >> > return orig; >> >> Can't we have first the introduction of perf_cpu_map__is_subset() and >> then another patch that gets the refcount, i=2Ee=2E the four lines belo= w? > >I believe that will fail as it'd be an unused static function warning >and werror=2E I thought that it seemed useful enough not to be a static, even if we don'= t at first export it, i=2Ee=2E keep it as internal to libperf > >Thanks, >Ian > >> > + if (perf_cpu_map__is_subset(other, orig)) { >> > + perf_cpu_map__put(orig); >> > + return perf_cpu_map__get(other); >> > + } >> > >> > tmp_len =3D orig->nr + other->nr; >> > tmp_cpus =3D malloc(tmp_len * sizeof(struct perf_cpu)); >> > -- >> > 2=2E35=2E1=2E1021=2Eg381101b075-goog >> >> -- >> >> - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50738C433F5 for ; Mon, 28 Mar 2022 20:58:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:References: In-Reply-To:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dq5MUmEsXiaahneFkxy4BaXrPlVgEzHcc2RrNvwxqG8=; b=0E4UbhnRFilt5b iMllAEdxKcyVMCLY0AT0dAlbWmfkgKggY6mkWDlwA0KGXHpY+J4NNpQXV61It47TsbLoO14D4wbqJ BGa4MtXROVj/SfDUWN4KH22hAVV15WY8Km+rG1QB3YCq/FpdxpZg+hunQ2i8TCN3iRTFB41ktqewL fOK2nzgSu66h13Fn8ZDhux4bKRDoF7Y+Y9OfyAKmcOxCVAiSAPFj3+OMbsHUc6XwA+EG49ufDboeO NoQfcbpfTuD+Uugkaa+ti7yv9b83ORLC4xcbdFjcWcvPIF3ySiFRxJU0k+91+E7MHZCfiAfIlIdn6 C6sME0Mb6FN7ouuNaKvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYwQM-00ABmk-6F; Mon, 28 Mar 2022 20:57:14 +0000 Received: from mail-oi1-x232.google.com ([2607:f8b0:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYwQI-00ABl8-B4 for linux-arm-kernel@lists.infradead.org; Mon, 28 Mar 2022 20:57:11 +0000 Received: by mail-oi1-x232.google.com with SMTP id b188so16959901oia.13 for ; Mon, 28 Mar 2022 13:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:user-agent:in-reply-to:references :message-id:mime-version:content-transfer-encoding; bh=JcBVwR8XLDQBSP8SxdAoaozEKj20bLEdjh0fLBcT41c=; b=pdQ/Q1QGUGjzOJukBJjP4U5oOV6QzltQSsx0ywlFcFCxlHmErpakQ71Ntftr133p/8 FiUxg7uBYqulSwcKApicZjUwChuTc//+n5LXj0fDgjPJOQgU9TPkUxpjMFbVGtlg5CDM Xi0ug5YTneIlO2qI5h32eR0TqUbgrRcZLSF8VtxcWrpE1NVLGphOT31Ia4hKaege9aqD 0SKsvPhD/qQDbCjCZm2aT6XzhjbpxJZC7TE+umvo+Qv29z2Zp71EaiOQNMPIxeMayaQ/ E23mZCjnjnXRN/Nw377YmYdX7i74xgj5uxtYGqNUDtJ7qCI9VG+Rom988/z8VlI1XGy3 ObGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:user-agent:in-reply-to :references:message-id:mime-version:content-transfer-encoding; bh=JcBVwR8XLDQBSP8SxdAoaozEKj20bLEdjh0fLBcT41c=; b=WoBXI1Ky4OmOLN4Kg+DZkq/+56atTWQ0Ng5LikC8Wv5lteLG1oRaLYDTvC8FPEJr8n I0ubk4JiepsoU1Agh2DgsOAba0DgIU+mtQnb0LKURnZUVlZNByk2E/NiixkodNq6qlb1 f8GSpewKjFCjAskK/8jVs6Erv2kKDbxANe8DZ0RJ/v413Ttp19LDgSyrtgYSx/OM6eot op5IlJTFscKyw9rgdliOuPuz7cUkQYujXbEaoKBZD79Ao6X6eF/wpYx/+qDhM/kmRXus 5auqZWg7tyi67nWjK20x7EX2HFruMzIZEUVppFXGdjSj4ofRJmLXZg17kbW59VG8gjus hTdw== X-Gm-Message-State: AOAM532LGu6Eeyg0XzNhZqAiFdG9vo4bjC2PTxTQIpNkhknjAuIchtW9 gmjGwu9GABThmMNwzb3dMDE= X-Google-Smtp-Source: ABdhPJx3MOEnr/6Eihy5bZZNDW1D7o+VpA7ydx7vu88ZTQ2eahIrFjmv3Vruk4sayEBSpk+UbOV7bQ== X-Received: by 2002:aca:aa55:0:b0:2ee:e8e8:cf80 with SMTP id t82-20020acaaa55000000b002eee8e8cf80mr581870oie.64.1648501027588; Mon, 28 Mar 2022 13:57:07 -0700 (PDT) Received: from [127.0.0.1] ([187.19.239.165]) by smtp.gmail.com with ESMTPSA id u14-20020a4ad0ce000000b0032174de7c2csm7414197oor.8.2022.03.28.13.57.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Mar 2022 13:57:06 -0700 (PDT) Date: Mon, 28 Mar 2022 17:56:07 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers , Arnaldo Carvalho de Melo CC: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , John Garry , Will Deacon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Kajol Jain , James Clark , German Gomez , Adrian Hunter , Riccardo Mancini , Andi Kleen , Alexey Bayduraev , Alexander Antonov , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH 2/5] perf cpumap: More cpu map reuse by merge. User-Agent: K-9 Mail for Android In-Reply-To: References: <20220328062414.1893550-1-irogers@google.com> <20220328062414.1893550-3-irogers@google.com> Message-ID: <0A053E2F-284B-4C1B-B09E-AC082916DD0E@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220328_135710_423861_825DD69D X-CRM114-Status: GOOD ( 30.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiBNYXJjaCAyOCwgMjAyMiA1OjUwOjIxIFBNIEdNVC0wMzowMCwgSWFuIFJvZ2VycyA8aXJv Z2Vyc0Bnb29nbGUuY29tPiB3cm90ZToKPk9uIE1vbiwgTWFyIDI4LCAyMDIyIGF0IDE6MjYgUE0g QXJuYWxkbyBDYXJ2YWxobyBkZSBNZWxvCj48YWNtZUBrZXJuZWwub3JnPiB3cm90ZToKPj4KPj4g RW0gU3VuLCBNYXIgMjcsIDIwMjIgYXQgMTE6MjQ6MTFQTSAtMDcwMCwgSWFuIFJvZ2VycyBlc2Ny ZXZldToKPj4gPiBwZXJmX2NwdV9tYXBfX21lcmdlIHdpbGwgcmV1c2Ugb25lIG9mIGl0cyBhcmd1 bWVudHMgaWYgdGhleSBhcmUgZXF1YWwgb3IKPj4gPiB0aGUgb3RoZXIgYXJndW1lbnQgaXMgTlVM TC4gVGhlIGFyZ3VtZW50cyBjb3VsZCBiZSByZXVzZWQgaWYgaXQgaXMga25vd24KPj4gPiBvbmUg c2V0IG9mIHZhbHVlcyBpcyBhIHN1YnNldCBvZiB0aGUgb3RoZXIuIEZvciBleGFtcGxlLCBhIG1h cCBvZiAwLTEKPj4gPiBhbmQgYSBtYXAgb2YganVzdCAwIHdoZW4gbWVyZ2VkIHlpZWxkcyB0aGUg bWFwIG9mIDAtMS4gQ3VycmVudGx5IGEgbmV3Cj4+ID4gbWFwIGlzIGNyZWF0ZWQgcmF0aGVyIHRo YW4gYWRkaW5nIGEgcmVmZXJlbmNlIGNvdW50IHRvIHRoZSBvcmlnaW5hbCAwLTEKPj4gPiBtYXAu Cj4+ID4KPj4gPiBTaWduZWQtb2ZmLWJ5OiBJYW4gUm9nZXJzIDxpcm9nZXJzQGdvb2dsZS5jb20+ Cj4+ID4gLS0tCj4+ID4gIHRvb2xzL2xpYi9wZXJmL2NwdW1hcC5jIHwgMzggKysrKysrKysrKysr KysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KPj4gPiAgMSBmaWxlIGNoYW5nZWQsIDI4IGluc2Vy dGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+PiA+Cj4+ID4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xp Yi9wZXJmL2NwdW1hcC5jIGIvdG9vbHMvbGliL3BlcmYvY3B1bWFwLmMKPj4gPiBpbmRleCBlZTY2 NzYwZjFlNjMuLjk1M2JjNTBiMGU0MSAxMDA2NDQKPj4gPiAtLS0gYS90b29scy9saWIvcGVyZi9j cHVtYXAuYwo+PiA+ICsrKyBiL3Rvb2xzL2xpYi9wZXJmL2NwdW1hcC5jCj4+ID4gQEAgLTMxOSw2 ICszMTksMjkgQEAgc3RydWN0IHBlcmZfY3B1IHBlcmZfY3B1X21hcF9fbWF4KHN0cnVjdCBwZXJm X2NwdV9tYXAgKm1hcCkKPj4gPiAgICAgICByZXR1cm4gbWFwLT5uciA+IDAgPyBtYXAtPm1hcFtt YXAtPm5yIC0gMV0gOiByZXN1bHQ7Cj4+ID4gIH0KPj4gPgo+PiA+ICsvKiogSXMgJ2InIGEgc3Vi c2V0IG9mICdhJy4gKi8KPj4gPiArc3RhdGljIGJvb2wgcGVyZl9jcHVfbWFwX19pc19zdWJzZXQo Y29uc3Qgc3RydWN0IHBlcmZfY3B1X21hcCAqYSwKPj4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY29uc3Qgc3RydWN0IHBlcmZfY3B1X21hcCAqYikKPj4gPiArewo+PiA+ICsg ICAgIGludCBpLCBqOwo+PiA+ICsKPj4gPiArICAgICBpZiAoYSA9PSBiIHx8ICFiKQo+PiA+ICsg ICAgICAgICAgICAgcmV0dXJuIHRydWU7Cj4+ID4gKyAgICAgaWYgKCFhIHx8IGItPm5yID4gYS0+ bnIpCj4+ID4gKyAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4+ID4gKyAgICAgaiA9IDA7Cj4+ ID4gKyAgICAgZm9yIChpID0gMDsgaSA8IGEtPm5yOyBpKyspIHsKPj4KPj4gU2luY2UgdGhlIGtl cm5lbCBidW1wZWQgdGhlIG1pbmltdW0gZ2NjIHZlcnNpb24gdG8gb25lIHRoYXQgc3VwcG9ydHMK Pj4gZGVjbGFyaW5nIGxvb3AgdmFyaWFibGVzIGxvY2FsbHkgYW5kIHRoYXQgcGVyZiBoYXMgYmVl biB1c2luZyB0aGlzIHNpbmNlCj4+IGZvcmV2ZXI6Cj4+Cj4+IOKsolthY21lQHRvb2xib3ggcGVy Zl0kIGdyZXAgLXIgJyhpbnQgW1s6YWxwaGE6XV0gPSAwOycgdG9vbHMvcGVyZgo+PiB0b29scy9w ZXJmL3V0aWwvYmxvY2staW5mby5jOiAgIGZvciAoaW50IGkgPSAwOyBpIDwgbnJfaHBwczsgaSsr KQo+PiB0b29scy9wZXJmL3V0aWwvYmxvY2staW5mby5jOiAgIGZvciAoaW50IGkgPSAwOyBpIDwg bnJfaHBwczsgaSsrKSB7Cj4+IHRvb2xzL3BlcmYvdXRpbC9ibG9jay1pbmZvLmM6ICAgZm9yIChp bnQgaSA9IDA7IGkgPCBucl9yZXBzOyBpKyspCj4+IHRvb2xzL3BlcmYvdXRpbC9zdHJlYW0uYzog ICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBucl9ldnNlbDsgaSsrKQo+PiB0b29scy9wZXJmL3V0 aWwvc3RyZWFtLmM6ICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbnJfZXZzZWw7IGkrKykgewo+ PiB0b29scy9wZXJmL3V0aWwvc3RyZWFtLmM6ICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgZWxz LT5ucl9ldnNlbDsgaSsrKSB7Cj4+IHRvb2xzL3BlcmYvdXRpbC9zdHJlYW0uYzogICAgICAgZm9y IChpbnQgaSA9IDA7IGkgPCBlc19wYWlyLT5ucl9zdHJlYW1zOyBpKyspIHsKPj4gdG9vbHMvcGVy Zi91dGlsL3N0cmVhbS5jOiAgICAgICBmb3IgKGludCBpID0gMDsgaSA8IGVzX2Jhc2UtPm5yX3N0 cmVhbXM7IGkrKykgewo+PiB0b29scy9wZXJmL3V0aWwvY3B1bWFwLmM6ICAgICAgICAgICAgICAg Zm9yIChpbnQgaiA9IDA7IGogPCBjLT5ucjsgaisrKSB7Cj4+IHRvb2xzL3BlcmYvdXRpbC9tZW0t ZXZlbnRzLmM6ICAgZm9yIChpbnQgaiA9IDA7IGogPCBQRVJGX01FTV9FVkVOVFNfX01BWDsgaisr KSB7Cj4+IHRvb2xzL3BlcmYvdXRpbC9oZWFkZXIuYzogICAgICAgZm9yIChpbnQgaSA9IDA7IGkg PCBmZi0+cGgtPmVudi5ucl9oeWJyaWRfY3BjX25vZGVzOyBpKyspIHsKPj4gdG9vbHMvcGVyZi9i dWlsdGluLWRpZmYuYzogICAgICBmb3IgKGludCBpID0gMDsgaSA8IG51bTsgaSsrKQo+PiB0b29s cy9wZXJmL2J1aWx0aW4tZGlmZi5jOiAgICAgICAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBw YWlyLT5ibG9ja19pbmZvLT5udW07IGkrKykgewo+PiB0b29scy9wZXJmL2J1aWx0aW4tc3RhdC5j OiAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgcGVyZl9jcHVfbWFwX19ucihhLT5jb3JlLmNwdXMp OyBpKyspIHsKPj4g4qyiW2FjbWVAdG9vbGJveCBwZXJmXSQKPj4KPj4gQW5kIHRoaXMgYnVpbGRz IG9uIGFsbCBteSB0ZXN0IGNvbnRhaW5lcnMsIHBsZWFzZSB1c2U6Cj4+Cj4+ICAgICAgICAgZm9y IChpbnQgaSA9IDAsIGogPSAwOyBpIDwgYS0+bnI7IGkrKykKPj4KPj4gSW4gdGhpcyBjYXNlIHRv IG1ha2UgdGhlIHNvdXJjZSBjb2RlIG1vcmUgY29tcGFjdC4KPgo+QWNrLiBXZSBzdGlsbCBuZWVk IHRvIGRlY2xhcmUgJ2onIGFuZCBpdCBpcyBhIGJpdCB3ZWlyZCB0byBkZWNsYXJlIGoKPmJlZm9y ZSBpLiBGd2l3LCBNYWtpbmcuY29uZmlnIGhhcyB0aGUgQ09SRV9DRkxBR1Mgc2V0IHRvIGdudTk5 LCBidXQKPmRlY2xhcmluZyBpbiB0aGUgbG9vcCBpcyBjbGVhcmx5IHZhbGlkIGluIGM5OS4KPgo+ PiA+ICsgICAgICAgICAgICAgaWYgKGEtPm1hcFtpXS5jcHUgPiBiLT5tYXBbal0uY3B1KQo+PiA+ ICsgICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4+ID4gKyAgICAgICAgICAgICBp ZiAoYS0+bWFwW2ldLmNwdSA9PSBiLT5tYXBbal0uY3B1KSB7Cj4+ID4gKyAgICAgICAgICAgICAg ICAgICAgIGorKzsKPj4gPiArICAgICAgICAgICAgICAgICAgICAgaWYgKGogPT0gYi0+bnIpCj4+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7Cj4+Cj4+IE9rLCBh cyBpdHMgZ3VhcmFudGVlZCB0aGF0IGNwdV9tYXBzIGFyZSBvcmRlcmVkLgo+Pgo+PiA+ICsgICAg ICAgICAgICAgfQo+PiA+ICsgICAgIH0KPj4gPiArICAgICByZXR1cm4gZmFsc2U7Cj4+ID4gK30K Pj4gPiArCj4+ID4gIC8qCj4+ID4gICAqIE1lcmdlIHR3byBjcHVtYXBzCj4+ID4gICAqCj4+ID4g QEAgLTMzNSwxNyArMzU4LDEyIEBAIHN0cnVjdCBwZXJmX2NwdV9tYXAgKnBlcmZfY3B1X21hcF9f bWVyZ2Uoc3RydWN0IHBlcmZfY3B1X21hcCAqb3JpZywKPj4gPiAgICAgICBpbnQgaSwgaiwgazsK Pj4gPiAgICAgICBzdHJ1Y3QgcGVyZl9jcHVfbWFwICptZXJnZWQ7Cj4+ID4KPj4gPiAtICAgICBp ZiAoIW9yaWcgJiYgIW90aGVyKQo+PiA+IC0gICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4+ID4g LSAgICAgaWYgKCFvcmlnKSB7Cj4+ID4gLSAgICAgICAgICAgICBwZXJmX2NwdV9tYXBfX2dldChv dGhlcik7Cj4+ID4gLSAgICAgICAgICAgICByZXR1cm4gb3RoZXI7Cj4+ID4gLSAgICAgfQo+PiA+ IC0gICAgIGlmICghb3RoZXIpCj4+ID4gLSAgICAgICAgICAgICByZXR1cm4gb3JpZzsKPj4gPiAt ICAgICBpZiAob3JpZy0+bnIgPT0gb3RoZXItPm5yICYmCj4+ID4gLSAgICAgICAgICFtZW1jbXAo b3JpZy0+bWFwLCBvdGhlci0+bWFwLCBvcmlnLT5uciAqIHNpemVvZihzdHJ1Y3QgcGVyZl9jcHUp KSkKPj4gPiArICAgICBpZiAocGVyZl9jcHVfbWFwX19pc19zdWJzZXQob3JpZywgb3RoZXIpKQo+ PiA+ICAgICAgICAgICAgICAgcmV0dXJuIG9yaWc7Cj4+Cj4+IENhbid0IHdlIGhhdmUgZmlyc3Qg dGhlIGludHJvZHVjdGlvbiBvZiBwZXJmX2NwdV9tYXBfX2lzX3N1YnNldCgpIGFuZAo+PiB0aGVu IGFub3RoZXIgcGF0Y2ggdGhhdCBnZXRzIHRoZSByZWZjb3VudCwgaS5lLiB0aGUgZm91ciBsaW5l cyBiZWxvdz8KPgo+SSBiZWxpZXZlIHRoYXQgd2lsbCBmYWlsIGFzIGl0J2QgYmUgYW4gdW51c2Vk IHN0YXRpYyBmdW5jdGlvbiB3YXJuaW5nCj5hbmQgd2Vycm9yLgoKSSB0aG91Z2h0IHRoYXQgaXQg c2VlbWVkIHVzZWZ1bCBlbm91Z2ggbm90IHRvIGJlIGEgc3RhdGljLCBldmVuIGlmIHdlIGRvbid0 IGF0IGZpcnN0IGV4cG9ydCBpdCwgaS5lLiBrZWVwIGl0IGFzIGludGVybmFsIHRvIGxpYnBlcmYK Cj4KPlRoYW5rcywKPklhbgo+Cj4+ID4gKyAgICAgaWYgKHBlcmZfY3B1X21hcF9faXNfc3Vic2V0 KG90aGVyLCBvcmlnKSkgewo+PiA+ICsgICAgICAgICAgICAgcGVyZl9jcHVfbWFwX19wdXQob3Jp Zyk7Cj4+ID4gKyAgICAgICAgICAgICByZXR1cm4gcGVyZl9jcHVfbWFwX19nZXQob3RoZXIpOwo+ PiA+ICsgICAgIH0KPj4gPgo+PiA+ICAgICAgIHRtcF9sZW4gPSBvcmlnLT5uciArIG90aGVyLT5u cjsKPj4gPiAgICAgICB0bXBfY3B1cyA9IG1hbGxvYyh0bXBfbGVuICogc2l6ZW9mKHN0cnVjdCBw ZXJmX2NwdSkpOwo+PiA+IC0tCj4+ID4gMi4zNS4xLjEwMjEuZzM4MTEwMWIwNzUtZ29vZwo+Pgo+ PiAtLQo+Pgo+PiAtIEFybmFsZG8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK