From: "Benjamin Coddington" <bcodding@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/285: discover allocation size for NFS
Date: Sun, 16 Oct 2016 06:18:13 -0400 [thread overview]
Message-ID: <0A92328A-9E9C-4D8D-AADF-F995369A3E40@redhat.com> (raw)
In-Reply-To: <20161016071752.GC17675@infradead.org>
On 16 Oct 2016, at 3:17, Christoph Hellwig wrote:
> On Fri, Oct 14, 2016 at 06:28:37AM -0400, Benjamin Coddington wrote:
>> On NFS, try to discover the allocation size for the exported filesystem.
>> NFS st_blksize is optimized for the network, and will usually be much
>> larger than the allocation size of the exported filesystem, which may
>> trigger preallocation strategies in the exported filesystem causing the
>> seek tests here to fail.
>
> Is there a reason not to use your new evidence-based check for all
> file systems?
Only that on the filesystems I've checked (ext4, xfs, btrfs, tmpfs)
st_blksize is correct, so trying to discover it is unnecessary.
Ben
next prev parent reply other threads:[~2016-10-16 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 10:28 [PATCH] generic/285: discover allocation size for NFS Benjamin Coddington
2016-10-16 7:17 ` Christoph Hellwig
2016-10-16 10:18 ` Benjamin Coddington [this message]
2016-10-16 21:15 ` Dave Chinner
2016-10-18 12:40 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0A92328A-9E9C-4D8D-AADF-F995369A3E40@redhat.com \
--to=bcodding@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.