All of lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Kooi <koen@dominion.thruhere.net>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/5] kernel.bbclass: blacklist 'perf-dbg' as well for the modules metapackage
Date: Thu, 22 Sep 2011 15:56:03 +0200	[thread overview]
Message-ID: <0AEFA847-426C-4F4C-9099-A0A3B8990BE5@dominion.thruhere.net> (raw)
In-Reply-To: <CADkTA4Pn7enn_ocpzwAeX7si=u-+UAabjrJDwBDoC1ODQqiQZg@mail.gmail.com>


Op 22 sep. 2011, om 15:28 heeft Bruce Ashfield het volgende geschreven:

> On Thu, Sep 22, 2011 at 9:17 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> 
>> Op 22 sep. 2011, om 15:00 heeft Dmitry Eremin-Solenikov het volgende geschreven:
>> 
>>> On 09/22/2011 04:35 PM, Koen Kooi wrote:
>>>> 
>>>> Op 22 sep. 2011, om 14:25 heeft Dmitry Eremin-Solenikov het volgende geschreven:
>>>> 
>>>>> On 09/18/2011 02:23 AM, Otavio Salvador wrote:
>>>>>> I have sent this in July and it was nacked. See at
>>>>>> https://github.com/OSSystems/oe-core/commit/5c53cbf951a11ed92fb2ad0837991db256c11489
>>>>> 
>>>>> Answering the original question by Saul:
>>>>> A possible better question is why perf-dbg is getting generated and what's in it?
>>>>> 
>>>>> perf and perf-dbg are generated to contain perf tool if it's not directly enabled (AFAIK), but you can compile it by running make in tools/perf. It has some additional depends (like binutils-dev, elfutils-dev, news-dev, etc., so it's not enabled by default. Probably we should enable it though.
>>>> 
>>>> the oe core kernel.bbclass builds perf by default
>>> 
>>> according to kernel.bbclass: "perf must be enabled in individual kernel recipes"
>> 
>> And pretty much everything uses recipes-kernel/linux/linux-tools.inc, which enables it. I had to add do_compile_perf() { : } to my old kernel recipes that have a broken perf, so it's opt-out, not opt-in.
> 
> We can always flip this around if required. When I initially did the kernel
> tree based builds for perf it was right in a specific kernel recipe, and then
> pulled it out into linux-tools.inc for easier reuse it was the intention that
> just including/requiring that .inc file would trigger a build of perf.


I'm not complaining about perf being built, I'm complaining that the patch is held up on a question why perf-dbg is getting built. If 'perf' is in the blacklist, 'perf-dbg' should be in as well. If 'perf-dbg' isn't allowed in, take out 'perf' as well, since they are a matched pair.


  reply	other threads:[~2011-09-22 14:01 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-17 22:18 [PATCH 1/5] kernel.bbclass: blacklist 'perf-dbg' as well for the modules metapackage Dmitry Eremin-Solenikov
2011-09-17 22:18 ` [PATCH 2/5] kernel.bbclass: respect MACHINE_KERNEL_PR Dmitry Eremin-Solenikov
2011-09-17 22:24   ` Otavio Salvador
2011-09-27 13:52   ` Bruce Ashfield
2011-09-27 23:40     ` Koen Kooi
2011-09-28 14:54       ` Richard Purdie
2011-09-28 18:42         ` Koen Kooi
2011-09-28 18:50           ` Dmitry Eremin-Solenikov
2011-09-28 19:50           ` Richard Purdie
2011-09-28 20:04             ` Otavio Salvador
2011-10-20  6:23               ` Koen Kooi
2011-10-20 11:21                 ` Richard Purdie
2011-10-20 11:29                   ` Koen Kooi
2011-10-20 11:35                     ` Otavio Salvador
2011-10-20 11:53                     ` Frans Meulenbroeks
2011-10-20 12:38                     ` Richard Purdie
2011-10-20 12:54                       ` Koen Kooi
2011-10-20 13:02                         ` Otavio Salvador
2011-10-21 12:05                           ` Koen Kooi
2011-10-20 13:56                         ` Richard Purdie
2011-09-17 22:18 ` [PATCH 3/5] kernel.bbclass: move uImage handling to separate task Dmitry Eremin-Solenikov
2011-09-17 22:25   ` Otavio Salvador
2011-09-21 13:09     ` Dmitry Eremin-Solenikov
2011-09-27 13:39   ` Bruce Ashfield
2011-09-17 22:18 ` [PATCH 4/5] kernel.bbclass: handle .cis firmware Dmitry Eremin-Solenikov
2011-09-27 13:40   ` Bruce Ashfield
2011-09-28 14:50   ` Richard Purdie
2011-09-17 22:18 ` [PATCH 5/5] kernel.bbclass: remove unshipped files in do_install Dmitry Eremin-Solenikov
2011-09-27 13:41   ` Bruce Ashfield
2011-09-28 14:50   ` Richard Purdie
2011-09-17 22:23 ` [PATCH 1/5] kernel.bbclass: blacklist 'perf-dbg' as well for the modules metapackage Otavio Salvador
2011-09-22 12:25   ` Dmitry Eremin-Solenikov
2011-09-22 12:35     ` Koen Kooi
2011-09-22 13:00       ` Dmitry Eremin-Solenikov
2011-09-22 13:17         ` Koen Kooi
2011-09-22 13:28           ` Bruce Ashfield
2011-09-22 13:56             ` Koen Kooi [this message]
2011-09-22 14:04               ` Bruce Ashfield
2011-09-28  8:47 ` Dmitry Eremin-Solenikov
2011-09-28 14:52   ` Richard Purdie
2011-09-28 14:50 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0AEFA847-426C-4F4C-9099-A0A3B8990BE5@dominion.thruhere.net \
    --to=koen@dominion.thruhere.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.