From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DFBC388F7 for ; Tue, 10 Nov 2020 13:49:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48A53207D3 for ; Tue, 10 Nov 2020 13:49:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="o/lWQGJF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730044AbgKJNtq (ORCPT ); Tue, 10 Nov 2020 08:49:46 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.164]:12177 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729898AbgKJNtq (ORCPT ); Tue, 10 Nov 2020 08:49:46 -0500 X-Greylist: delayed 101949 seconds by postgrey-1.27 at vger.kernel.org; Tue, 10 Nov 2020 08:49:45 EST DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1605016184; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=h/cvCoRx6ABjRnuNnggq6iBygV6wWKaNDHvZMbMP6NU=; b=o/lWQGJFOHmHvmDWKM2n7lmJ/qjKpmEOpIfGesMs5uBNCjc+ZYOVFGCk05H/2cM4Vu LcS8tuitf/je3COb42esg8Rh+DqdGPFlJ17Nj9NwpmzANDh/oZ+EYiBb0FwCNT1WL46N OKVFv0hFfacMO/CpAt/C8yGppcdY05LQ3EMvZF0UOVqi8ZfGULOLOcN/4zgI7Mph2yCj kIJFodYvGdYeNTSEO2ldeFd0a7vw7MYiM6m1s9LQM8idlZIuEMXBPl4VM+pUWQ73p3sb cYT3uHXC2VSh0sB9ds7Rl/6nhYwuwUwjazAWL6NOvbuoJAvc0lGC+lebwgkeM37/tMHy OvMw== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj5Qpw97WFDVCUXAYLEg==" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.3.4 DYNA|AUTH) with ESMTPSA id N02faawAADnQ15y (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Tue, 10 Nov 2020 14:49:26 +0100 (CET) Subject: Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii From: "H. Nikolaus Schaller" In-Reply-To: <7f820fd2-820b-bfdd-a43b-174ad6b09868@ti.com> Date: Tue, 10 Nov 2020 14:49:25 +0100 Cc: Sebastian Reichel , Laurent Pinchart , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , Discussions about the Letux Kernel Content-Transfer-Encoding: quoted-printable Message-Id: <0AF59BFD-89F2-46D3-9EB6-F47FBB52B183@goldelico.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <61C04176-4654-4D2D-A55B-31FBB6D2E5AA@goldelico.com> <579243AA-014A-411B-9014-F5846C9B8137@goldelico.com> <837EA533-9946-43B3-B058-69060EC43981@goldelico.com> <08589e51-f5e6-2743-57ec-8ac509f97ff0@ti.com> <1f1afce4-c822-0fbf-1ce3-dda0064b65c6@ti.com> <67786545-23D2-444F-85B8-7A030070B317@goldelico.com> <17F5238B-1CC3-4764-B744-C57D9CE4EB42@goldelico.com> <6A9407FC-69F7-4E30-B4A3-FFB2E91CAE3B@goldelico.com> <1cf563e5-2dc0-1802-86e3-3e24150f0651@ti.com> <7f820fd2-820b-bfdd-a43b-174ad6b09868@ti.com> To: Tomi Valkeinen X-Mailer: Apple Mail (2.3124) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi, > Am 09.11.2020 um 12:33 schrieb Tomi Valkeinen : >=20 > On 09/11/2020 13:09, H. Nikolaus Schaller wrote: >=20 >>>> I see. >>>> Anyways there is missing some simple thing which makes the driver = not prepared/enabled. >>>> Or is this related to VC? >>>=20 >>> No, that's not related to the VC. >>=20 >> Ok, then it is worth searching for that independently. Any idea/hint = what could be missing? >=20 > Well, if I had to guess, I would go for either 1) some registration or = such is missing from the > panel driver, or 2) some config value is invalid, which makes the DRM = framework or the DSI driver > fail before calling prepare or enable. I did now some tests based on v5.10-rc3 by adding mre and more printk() = and dump_stack(). And I did blacklist the panel driver so that I could boot and after = modprobing it manually I could trigger a re-probe by inserting some USB memory stick. With this procedure I could trace the problem down to this call = sequence: dsi_probe() ... w677l_probe() drm_panel_add() -- after this, of_drm_find_panel() is = successful ... component_add() try_to_bring_up_master() master->ops->bind(master->dev) This call to bind() does not return and likely the probing thread is = then blocked and holds some locks which manifests itself in that the system isn't running = stable any more (e.g. heartbeat LEDs are sometimes stuck although console still = works). dbg_info() in try_to_bring_up_master() prints: [ 102.199362] omapdss_dss 58000000.dss: trying to bring up master So I am not sure if this is a panel driver issue at all or the DSI patch = set is not running stable on OMAP5. Is a good next step to trace dss_bind() in = drivers/gpu/drm/omapdrm//dss/dss.c? BR, Nikolaus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3402EC388F9 for ; Wed, 11 Nov 2020 07:55:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF279206B5 for ; Wed, 11 Nov 2020 07:55:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="DGwnM3xg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF279206B5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goldelico.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E648C89F5F; Wed, 11 Nov 2020 07:55:00 +0000 (UTC) Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E33389A62 for ; Tue, 10 Nov 2020 13:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1605016350; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=h/cvCoRx6ABjRnuNnggq6iBygV6wWKaNDHvZMbMP6NU=; b=DGwnM3xgQaZhqk1X1Rsw404OfXD7x/+LlSP9nW+2vBXhpHzh4Vb3flCVi8trTdWrOO V8n83jQZn+kfU7v/lOUB6BNjDGilka1vA4SJFMp7obmlBUL9XMu85q8ooozNqMofKAQk YRhMZemdPV4GP0L2XCgBr7SN8wl56inauWCi3EBI2O9suvsMITqRUCUwXc/xHKMMYFoD xotzLewc9F/XEnWo3AsBhHzDglKfIxlQ36et3QvQy9EI+vPWLe9gdeCrD2oRKyFtxzj3 +oLJj+OGXxo4lU0KnGCLblTCLPXBRN2iIUQVE2xYsddxaV+eXXmoCT4tqLPpzlpZkqqq 7NbQ== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj5Qpw97WFDVCUXAYLEg==" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.3.4 DYNA|AUTH) with ESMTPSA id N02faawAADnQ15y (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Tue, 10 Nov 2020 14:49:26 +0100 (CET) Subject: Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: "H. Nikolaus Schaller" In-Reply-To: <7f820fd2-820b-bfdd-a43b-174ad6b09868@ti.com> Date: Tue, 10 Nov 2020 14:49:25 +0100 Message-Id: <0AF59BFD-89F2-46D3-9EB6-F47FBB52B183@goldelico.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <61C04176-4654-4D2D-A55B-31FBB6D2E5AA@goldelico.com> <579243AA-014A-411B-9014-F5846C9B8137@goldelico.com> <837EA533-9946-43B3-B058-69060EC43981@goldelico.com> <08589e51-f5e6-2743-57ec-8ac509f97ff0@ti.com> <1f1afce4-c822-0fbf-1ce3-dda0064b65c6@ti.com> <67786545-23D2-444F-85B8-7A030070B317@goldelico.com> <17F5238B-1CC3-4764-B744-C57D9CE4EB42@goldelico.com> <6A9407FC-69F7-4E30-B4A3-FFB2E91CAE3B@goldelico.com> <1cf563e5-2dc0-1802-86e3-3e24150f0651@ti.com> <7f820fd2-820b-bfdd-a43b-174ad6b09868@ti.com> To: Tomi Valkeinen X-Mailer: Apple Mail (2.3124) X-Mailman-Approved-At: Wed, 11 Nov 2020 07:54:43 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Discussions about the Letux Kernel , Tony Lindgren , Sekhar Nori , Sebastian Reichel , dri-devel@lists.freedesktop.org, Laurent Pinchart , linux-omap@vger.kernel.org, Nikhil Devshatwar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Tomi, > Am 09.11.2020 um 12:33 schrieb Tomi Valkeinen : > > On 09/11/2020 13:09, H. Nikolaus Schaller wrote: > >>>> I see. >>>> Anyways there is missing some simple thing which makes the driver not prepared/enabled. >>>> Or is this related to VC? >>> >>> No, that's not related to the VC. >> >> Ok, then it is worth searching for that independently. Any idea/hint what could be missing? > > Well, if I had to guess, I would go for either 1) some registration or such is missing from the > panel driver, or 2) some config value is invalid, which makes the DRM framework or the DSI driver > fail before calling prepare or enable. I did now some tests based on v5.10-rc3 by adding mre and more printk() and dump_stack(). And I did blacklist the panel driver so that I could boot and after modprobing it manually I could trigger a re-probe by inserting some USB memory stick. With this procedure I could trace the problem down to this call sequence: dsi_probe() ... w677l_probe() drm_panel_add() -- after this, of_drm_find_panel() is successful ... component_add() try_to_bring_up_master() master->ops->bind(master->dev) This call to bind() does not return and likely the probing thread is then blocked and holds some locks which manifests itself in that the system isn't running stable any more (e.g. heartbeat LEDs are sometimes stuck although console still works). dbg_info() in try_to_bring_up_master() prints: [ 102.199362] omapdss_dss 58000000.dss: trying to bring up master So I am not sure if this is a panel driver issue at all or the DSI patch set is not running stable on OMAP5. Is a good next step to trace dss_bind() in drivers/gpu/drm/omapdrm//dss/dss.c? BR, Nikolaus _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel