From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14C95C6FA82 for ; Tue, 20 Sep 2022 23:24:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230112AbiITXYD (ORCPT ); Tue, 20 Sep 2022 19:24:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230025AbiITXYB (ORCPT ); Tue, 20 Sep 2022 19:24:01 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68E1C753A8 for ; Tue, 20 Sep 2022 16:24:00 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a26so9848120ejc.4 for ; Tue, 20 Sep 2022 16:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date; bh=qKZPVG5iME12/xaovZM6A6+qsWvmHnon3GYaJNYHOS8=; b=fCK9HNlTrRewEDKb1ki/vTFY3BFU4vzCnR5/5SporYyj2K3I0iIme7NT7sFxvxSWk3 umbS7mgSQHCv4vemkhsUb7I8ViXwtdzvdECA7Hg1aPJOJHkBgajnUvnzOd15ofRxvKPW 2NmhmYzO4jI0zH5j583BH2fYOyCqRhQagr8KEfGrHxwOvw9vpW0RHacBcO/xfLZqnbG9 JGQYdHCVFxtkFHNb5If1sypH5E1lsaKJVmD0Bts992LCNZLkqOhf1P9RqHOcsUAWXlWu d4YWu7xGj+i6DW0je9gZb13SoS+moDDgWL9JmB1tDOJPynLYKJKZy8VNJloyV8FGfrcV cuNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=qKZPVG5iME12/xaovZM6A6+qsWvmHnon3GYaJNYHOS8=; b=zmzGAJY2DDWrMMVBdbBfK7r7EjUzsOAjBcjMhWGxt3JnVVEYFHqQe+k3UB2BqBypaY 8W6pG+YpuJtsOOCMqbTyb49Rmva0LUnI4eg2KllNO1XAZj8kvKQjZ1VEGdPprXfJDVpD T4kDfnzENMpOEjVbV8yfUcI1Hs60Nsifw2nZR25T3/VtdflYJ8QgPWlwYJAz0epJRlSR yv44t6yOS3yMsPrdJkRY0+gARaGDVx8/quLrx7g8EgInzGSXMpeiUrE5+NXUYxymnsty o3NU7YdCXdF3ssfa7g0JokUKpCRJhwbXYkL5XzhrqLCQF411ZC8RssBVETKNs1X15PvF CAEg== X-Gm-Message-State: ACrzQf3vktzwRpXZUp2ioR1pjR8hdJumVctooTtyNFEhNniRtPHpbGuE KjKBAm8s3pMyCMIVgh4ltRs= X-Google-Smtp-Source: AMsMyM5RM/OVc3EykNVPTfjHa4cDBJJ/DnJiA70xAhCb8RUZeIR5sVs3l/o+BP+JEU8fpdRpHUyjcA== X-Received: by 2002:a17:906:eec9:b0:73d:c369:690f with SMTP id wu9-20020a170906eec900b0073dc369690fmr19058158ejb.767.1663716238901; Tue, 20 Sep 2022 16:23:58 -0700 (PDT) Received: from [127.0.0.1] (dynamic-078-054-006-055.78.54.pool.telefonica.de. [78.54.6.55]) by smtp.gmail.com with ESMTPSA id j22-20020a508a96000000b0044ed7a75c33sm689265edj.6.2022.09.20.16.23.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 16:23:58 -0700 (PDT) Date: Tue, 20 Sep 2022 23:23:52 +0000 From: Bernhard Beschow To: Markus Armbruster , Alistair Francis , Bin Meng , Palmer Dabbelt CC: "qemu-devel@nongnu.org Developers" , "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Eric Auger , David Gibson , =?ISO-8859-1?Q?Daniel_P=2E_Berrang=E9?= , Christian Borntraeger , =?ISO-8859-1?Q?C=E9dric_Le_Goater?= , Stefan Hajnoczi , Qemu-block , Eduardo Habkost , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , "open list:New World" , Cornelia Huck , Helge Deller , Stefano Stabellini , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , "open list:RISC-V" , Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x , =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , "open list:X86" , Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , "open list:Overall" , Qiuhao Li , John G Johnson , Sunil Muthuswamy , Max Filippov , qemu-arm , Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState In-Reply-To: <87edw6xoog.fsf@pond.sub.org> References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-2-shentey@gmail.com> <87edw6xoog.fsf@pond.sub.org> Message-ID: <0BBD7391-7B2D-44E7-9396-D1747784B9DA@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Am 20=2E September 2022 11:36:47 UTC schrieb Markus Armbruster : >Alistair Francis writes: > >> On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow = wrote: >>> >>> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it = to >>> inherit from TYPE_MACHINE=2E This is an inconsistency which can cause >>> undefined behavior such as memory corruption=2E >>> >>> Change SiFiveEState to inherit from MachineState since it is registere= d >>> as a machine=2E >>> >>> Signed-off-by: Bernhard Beschow >> >> Reviewed-by: Alistair Francis > >To the SiFive maintainers: since this is a bug fix, let's merge it right >away=2E I could repost this particular patch with the three new tags (incl=2E Fixe= s) if desired=2E Best regards, Bernhard >