All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Du, Changbin" <changbin.du@intel.com>
To: Peter Chen <hzpeterchen@gmail.com>
Cc: "balbi@ti.com" <balbi@ti.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"mina86@mina86.com" <mina86@mina86.com>,
	"r.baldyga@samsung.com" <r.baldyga@samsung.com>,
	"rui.silva@linaro.org" <rui.silva@linaro.org>,
	"k.opasiak@samsung.com" <k.opasiak@samsung.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: f_fs: avoid race condition with ffs_epfile_io_complete
Date: Tue, 5 Jan 2016 06:22:02 +0000	[thread overview]
Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A05C94106@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20160105054906.GB29244@shlinux2>

> >
> > You are right, but the problem is the request->status is wrong. If the data
> > send out but report caller as -EINTR, it will introduce duplicate-send
> > issue.
> >
> 
> Why -EINTR, the kernel-doc said it should return -ECONNRESET for active
> request, see include/linux/usb/gadget.h.
> 
> --
> 
> Best Regards,
> Peter Chen
F_fs return -EINTER in its dequeuer case, not udc driver. What I want
to say is driver should return the right status for each usb request.


  reply	other threads:[~2016-01-05  6:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-29  6:36 [PATCH] usb: f_fs: avoid race condition with ffs_epfile_io_complete changbin.du
2016-01-04 20:33 ` Michal Nazarewicz
2016-01-05  3:32 ` Peter Chen
2016-01-05  4:09   ` Du, Changbin
2016-01-05  5:49     ` Peter Chen
2016-01-05  6:22       ` Du, Changbin [this message]
2016-01-05 12:45       ` Michal Nazarewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0C18FE92A7765D4EB9EE5D38D86A563A05C94106@SHSMSX103.ccr.corp.intel.com \
    --to=changbin.du@intel.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hzpeterchen@gmail.com \
    --cc=k.opasiak@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mina86@mina86.com \
    --cc=r.baldyga@samsung.com \
    --cc=rui.silva@linaro.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.