From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755122AbcLZHln convert rfc822-to-8bit (ORCPT ); Mon, 26 Dec 2016 02:41:43 -0500 Received: from mga03.intel.com ([134.134.136.65]:56002 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751222AbcLZHlm (ORCPT ); Mon, 26 Dec 2016 02:41:42 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,404,1477983600"; d="scan'208";a="206827209" From: "Du, Changbin" To: Chris Wilson CC: "Vetter, Daniel" , "airlied@linux.ie" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Subject: RE: [Intel-gfx] [PATCH] drm/i915: check if execlist_port is empty before using its content Thread-Topic: [Intel-gfx] [PATCH] drm/i915: check if execlist_port is empty before using its content Thread-Index: AQHSXOAbd/qOIcoMQkeDu+nQv5T4MKEUoteAgAU46fA= Date: Mon, 26 Dec 2016 07:41:36 +0000 Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A53A9C855@SHSMSX103.ccr.corp.intel.com> References: <20161223054636.3924-1-changbin.du@intel.com> <20161223075121.GB14877@nuc-i3427.alporthouse.com> In-Reply-To: <20161223075121.GB14877@nuc-i3427.alporthouse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTA5MTFiMmUtZmVjNS00Yzc1LWJjYTgtZTRjMDVjYmZlNjhlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImRjUEo2UURqUnFlQzhDZnZZdnQzTXlsa2g5RDBnU2ZmTEtYMzFNZUZlUE09In0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Fri, Dec 23, 2016 at 01:46:36PM +0800, changbin.du@intel.com wrote: > > From: "Du, Changbin" > > > > This patch fix a crash in function reset_common_ring. In this case, > > the port[0].request is null when reset the render ring, so a null > > dereference exception is raised. We need to check execlist_port status > > first. > > No. The root cause is whatever got you into the illegal condition in the > first place. > -Chris > Thanks, I will restudy the code after process my current job. Since this happen on gvt guest, so this may related to gvt emulation. > -- > Chris Wilson, Intel Open Source Technology Centre From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Du, Changbin" Subject: Re: [PATCH] drm/i915: check if execlist_port is empty before using its content Date: Mon, 26 Dec 2016 07:41:36 +0000 Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A53A9C855@SHSMSX103.ccr.corp.intel.com> References: <20161223054636.3924-1-changbin.du@intel.com> <20161223075121.GB14877@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20161223075121.GB14877@nuc-i3427.alporthouse.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: "airlied@linux.ie" , "Vetter, Daniel" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org PiBPbiBGcmksIERlYyAyMywgMjAxNiBhdCAwMTo0NjozNlBNICswODAwLCBjaGFuZ2Jpbi5kdUBp bnRlbC5jb20gd3JvdGU6Cj4gPiBGcm9tOiAiRHUsIENoYW5nYmluIiA8Y2hhbmdiaW4uZHVAaW50 ZWwuY29tPgo+ID4KPiA+IFRoaXMgcGF0Y2ggZml4IGEgY3Jhc2ggaW4gZnVuY3Rpb24gcmVzZXRf Y29tbW9uX3JpbmcuIEluIHRoaXMgY2FzZSwKPiA+IHRoZSBwb3J0WzBdLnJlcXVlc3QgaXMgbnVs bCB3aGVuIHJlc2V0IHRoZSByZW5kZXIgcmluZywgc28gYSBudWxsCj4gPiBkZXJlZmVyZW5jZSBl eGNlcHRpb24gaXMgcmFpc2VkLiBXZSBuZWVkIHRvIGNoZWNrIGV4ZWNsaXN0X3BvcnQgc3RhdHVz Cj4gPiBmaXJzdC4KPiAKPiBOby4gVGhlIHJvb3QgY2F1c2UgaXMgd2hhdGV2ZXIgZ290IHlvdSBp bnRvIHRoZSBpbGxlZ2FsIGNvbmRpdGlvbiBpbiB0aGUKPiBmaXJzdCBwbGFjZS4KPiAtQ2hyaXMK PiAKVGhhbmtzLCBJIHdpbGwgcmVzdHVkeSB0aGUgY29kZSBhZnRlciBwcm9jZXNzIG15IGN1cnJl bnQgam9iLiBTaW5jZSB0aGlzIGhhcHBlbgpvbiBndnQgZ3Vlc3QsIHNvIHRoaXMgbWF5IHJlbGF0 ZWQgdG8gZ3Z0IGVtdWxhdGlvbi4KCj4gLS0KPiBDaHJpcyBXaWxzb24sIEludGVsIE9wZW4gU291 cmNlIFRlY2hub2xvZ3kgQ2VudHJlCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=