From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Butler, Siobhan A" Subject: Re: [PATCH] ixgbe: do not include CRC in Tx byte count Date: Thu, 2 Apr 2015 20:20:17 +0000 Message-ID: <0C5AFCA4B3408848ADF2A3073F7D8CC86D587279@IRSMSX109.ger.corp.intel.com> References: <1421994224-2127-1-git-send-email-stephen@networkplumber.org> <2601191342CEEE43887BDE71AB9772582140700B@irsmsx105.ger.corp.intel.com> <20150324085513.0752d9ba@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" , Stephen Hemminger To: Stephen Hemminger , "Ananyev, Konstantin" Return-path: In-Reply-To: <20150324085513.0752d9ba@urahara> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Stephen > Hemminger > Sent: Tuesday, March 24, 2015 3:55 PM > To: Ananyev, Konstantin > Cc: dev-VfR2kkLFssw@public.gmane.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte coun= t >=20 > On Mon, 23 Mar 2015 16:45:44 +0000 > "Ananyev, Konstantin" wrote: >=20 > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of > > > stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org > > > Sent: Friday, January 23, 2015 6:24 AM > > > To: dev-VfR2kkLFssw@public.gmane.org > > > Cc: Stephen Hemminger > > > Subject: [dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte > > > count > > > > > > From: Stephen Hemminger > > > > > > The ixgbe driver was including CRC in the transmit packet byte > > > count, but not for packets received. > > > This was notice when forwarding and > > > the number of bytes received was greater than the number of bytes > > > transmitted for the same number of packets. Make the driver behave > > > like other virtual devices and not include CRC in byte count. Use > > > the same queue counters already computed and used for Rx. > > > > About RX side stats - as I remember it depends to what value hw_stip_cr= c > is set at configure(). > > If hw_stip_crc=3D=3D1, then, yes CRC bytes are not included into QBRC = value. > > I If hw_stip_crc=3D=3D0, then CRC bytes are included into QBRC. >=20 > That is an additional bug! > * CRC should never be included in the byte count. > This is not how Linux or other drivers report byte count. >=20 > * the byte count must be symmetrical Rx =3D=3D Tx >=20 > The Brocade router always set strip_crc to 1. So did not see the addition= al > bug of CRC being included in byte count. >=20 >=20 Great to see some discussion here all but can we hold on to the patch until= after the 2.0 package is made so there is enough time to review and test i= t properly? Thanks=20 Siobhan