From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754099AbdKFT6y (ORCPT ); Mon, 6 Nov 2017 14:58:54 -0500 Received: from mail-by2nam03on0083.outbound.protection.outlook.com ([104.47.42.83]:52532 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753698AbdKFT6w (ORCPT ); Mon, 6 Nov 2017 14:58:52 -0500 From: "Madhani, Himanshu" To: Bart Van Assche CC: "keescook@chromium.org" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , Dept-Eng QLA2xxx Upstream , "martin.petersen@oracle.com" Subject: Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Topic: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Index: AQHTUnxphvT5wFV2bEGlxCWwLUqo66L/3oqAgAAI8ACABp0wAIABSaiA Date: Mon, 6 Nov 2017 19:58:45 +0000 Message-ID: <0CA81505-0EFB-4F30-A0B1-E021953741D1@cavium.com> References: <1509477229-62141-1-git-send-email-keescook@chromium.org> <1509927529.8757.1.camel@wdc.com> In-Reply-To: <1509927529.8757.1.camel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Himanshu.Madhani@cavium.com; x-originating-ip: [173.186.134.106] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR07MB3455;6:E4wWRY8oIfjjsDgECDWFVt9Vunz1+pMrkxd4DnU/ggalS+lQZPdJuwVIds0Y/fNjfBOT7pcfsgv9ts2z9XpwKS4QmIl5XQYMAEOvInPhiIyMOenBo/EGELK1gHxae7IboriHQ0s9k7nGZdexL6KIi0H4eYO6T9u626RwUjwbHLSbvCOTevSnbMZ6QfrkDHVspjzNvdtZ/X9mDX68AXZbOaCLelOCQWhMDaIoZBsMHGK+XwWTQSHYmIhkqb0OkMJzKyTsYLSDZVb7AkfdKrEXXaCOZLRwHPMpthwSvAorkjccGTt5VUtXqYq034aWzh7y9ONL6sNuoZxnYUmrBgLCp4YNFcGGA49urVVDASOuXZ8=;5:SXX9vM7yGMd5cHO6m7lA586qWcFUHwzeu4Q/WB6+9WmTbscZ83fnX04ul+dL0THDrmJ/mdKz7U4s+EZSXWd9SJtxIFUh+275kjVXTcydf/Jn4snPPbZRbff8HNFAkz9XuA0Kdwb6P+egGC/OuJBVayLsTlA/2zkkblx7bungwi0=;24:hPeUzh7abY0J01Uz9tx5IHCRu2gzQuPAe6IQVD8gXOriRxyT0Vaoz4oGdwR98uiNLNaOJTFnmUtPahYmGVlu1IKPLdIwwm511Jqo2m9Ul5g=;7:xRmKCRSIRwHO2TA3h525Zu85QXTLuGr0ThuV/kBrRfoisyP4XE1Hj9dsvtXtrYN+N2hsY27SoGKsh+ssIHsJwmLUVwEGP9WvFcGwKOXIeO2967kPUr7xn2g/ktc6GahPJ6K3izaW8d8Ljna97h6B76lIyy11V9JBpZnguHDYYgD8eXqZ/+AyntchHOwTHdTQkxc4Qj/3AIGvsNZHsLdAW0dbiz6CjUJZ9NZxWbq+U9LMpMg3yXGAH/rvUFx8oz7h x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: ea09c59f-b8d0-45a8-758b-08d52550c9b4 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:MWHPR07MB3455; x-ms-traffictypediagnostic: MWHPR07MB3455: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(3231021)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR07MB3455;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR07MB3455; x-forefront-prvs: 048396AFA0 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(189002)(199003)(377424004)(24454002)(6486002)(68736007)(8936002)(72206003)(76176999)(77096006)(101416001)(6506006)(102836003)(478600001)(2900100001)(36756003)(82746002)(97736004)(54356999)(33656002)(6116002)(6246003)(83716003)(99286004)(4326008)(6436002)(53546010)(229853002)(3846002)(189998001)(50986999)(93886005)(14454004)(6512007)(6916009)(86362001)(106356001)(54906003)(81156014)(2950100002)(81166006)(2906002)(5660300001)(3280700002)(316002)(105586002)(53936002)(25786009)(8676002)(66066001)(305945005)(3660700001)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB3455;H:MWHPR07MB3455.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea09c59f-b8d0-45a8-758b-08d52550c9b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2017 19:58:45.1795 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3455 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vA6JwwuA025071 Hi Bart, > On Nov 5, 2017, at 4:18 PM, Bart Van Assche wrote: > > On Wed, 2017-11-01 at 19:18 +0000, Madhani, Himanshu wrote: >> Hi Kees, >> >>> On Nov 1, 2017, at 11:46 AM, Kees Cook wrote: >>> >>> On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook wrote: >>>> This breaks out the logical steps to convert the qla2xxx timers: >>>> >>>> 1) init_timer() -> setup_timer() >>>> 2) refactor qla2x00_start_timer() to not pass callback as argument >>>> 3) qla2x00_timer() to use timer_setup() >>>> 4) qla2x00_sp_timeout() to use timer_setup() >>>> >>>> The resulting diff is identical to the patch that appears to lock up >>>> the driver. This should help identify which step causes this behavior. >>> >>> Hi, just curious if there's been any progress on debugging the issue >>> you saw with this series? >> >> Sorry for delay. I will test this series later today and post update. > > Hello Himanshu and Kees, > > The qla2xxx driver does not crash if apply these four patches on kernel > v4.14-rc8 and load the qla2xxx driver on my test setup. Point-to-point > mode seems broken again but I don't think that's related to this patch > series. > > Bart. What kind of errors you are seeing with Point-to-point mode. I’ll look at those and will submit fixes for it along with the other issues you have raised earlier. Kees, I’ll get back to validating the series again now. Sorry for delay. Thanks, - Himanshu