All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [BUG] sandbox: './u-boot -l ' fails
Date: Tue, 29 Sep 2020 13:47:12 +0200	[thread overview]
Message-ID: <0CBB3DF2-632B-4DAB-BD39-E2CE9F5AF513@gmx.de> (raw)
In-Reply-To: <173293.1601377945@gemini.denx.de>

Am 29. September 2020 13:12:25 MESZ schrieb Wolfgang Denk <wd@denx.de>:
>Dear Heinrich,
>
>In message <cab32aa2-0423-c966-47e1-a6f59411b0d1@gmx.de> you wrote:
>>
>> As we always try to use the same definition in U-Boot as in glibc we
>> should really replace getc() by another symbol, e.g. chget() so that
>we
>> avoid confusion.
>
>We should not invent any new names when there are existing good
>alterntives.
>
>Why not use getchar()?
>
>Quote fgetc(3) man page:
>
>...
>       int getchar(void);
>...
>       getchar() is equivalent to getc(stdin).
>...
>
>Best regards,
>
>Wolfgang Denk


Hello Wolfgang,

please, have a look at http://patchwork.ozlabs.org/project/uboot/patch/20200928234514.124945-1-xypron.glpk at gmx.de/

Is such a #define the way to go or should we globally rename getc?

Best regards

Heinrich

  reply	other threads:[~2020-09-29 11:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-19 19:48 [BUG] sandbox: './u-boot -l ' fails Heinrich Schuchardt
2020-09-28  4:24 ` Simon Glass
2020-09-28  4:46   ` Heinrich Schuchardt
2020-09-28 11:31     ` Heinrich Schuchardt
2020-09-28 13:22       ` Simon Glass
2020-09-28 13:30         ` Heinrich Schuchardt
2020-09-28 13:42           ` Simon Glass
2020-09-28 21:23             ` Heinrich Schuchardt
2020-09-28 22:19               ` Simon Glass
2020-09-28 23:59                 ` Heinrich Schuchardt
2020-09-29  1:21                   ` Heinrich Schuchardt
2020-09-29 11:12           ` Wolfgang Denk
2020-09-29 11:47             ` Heinrich Schuchardt [this message]
2020-09-29 13:05               ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0CBB3DF2-632B-4DAB-BD39-E2CE9F5AF513@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.