From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755793AbbAOSut (ORCPT ); Thu, 15 Jan 2015 13:50:49 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.163]:39785 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755768AbbAOSuq convert rfc822-to-8bit (ORCPT ); Thu, 15 Jan 2015 13:50:46 -0500 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcKdUCnXG6JabOfSXKWrat/jdPryY0= X-RZG-CLASS-ID: mo00 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation From: "Dr. H. Nikolaus Schaller" In-Reply-To: <20150115181637.GE33214@dtor-ws> Date: Thu, 15 Jan 2015 19:49:52 +0100 Cc: Sebastian Reichel , Belisko Marek , Rob Herring , Pawel Moll , Mark Rutland , "ijc+devicetree@hellion.org.uk" , Kumar Gala , Benoit Cousson , Tony Lindgren , Russell King - ARM Linux , "devicetree@vger.kernel.org" , LKML , "linux-omap@vger.kernel.org" , linux-arm-kernel , linux-input@vger.kernel.org, Marek Belisko , Jonathan Richardson , Scott Branden , Yoichi Yuasa , Maxime Ripard , List for communicating with real GTA04 owners Content-Transfer-Encoding: 8BIT Message-Id: <0CD142CE-0BC3-4A86-AAFB-383805A81646@goldelico.com> References: <1412108254-19234-1-git-send-email-marek@goldelico.com> <1412108254-19234-2-git-send-email-marek@goldelico.com> <20150115005938.GB9134@dtor-ws> <0F9A17C1-9B01-4EE9-BE98-266B8FC02B84@goldelico.com> <20150115143855.GD512@earth.universe> <8B08216C-13DD-40D8-9BA9-060F1C18A018@goldelico.com> <20150115181637.GE33214@dtor-ws> To: Dmitry Torokhov X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 15.01.2015 um 19:16 schrieb Dmitry Torokhov : > On Thu, Jan 15, 2015 at 05:14:38PM +0100, Dr. H. Nikolaus Schaller wrote: >> >> Am 15.01.2015 um 15:38 schrieb Sebastian Reichel : >> >>> Hi, >>> >>> On Thu, Jan 15, 2015 at 08:36:44AM +0100, Dr. H. Nikolaus Schaller wrote: >>>>> 1. Perform conversion in input core rather than individual drivers. I >>>>> think we should allocate a new bitmaps for some transformations and have >>>>> the code do X/Y flip/clip of the coordinates. >>>> >>>> Do you have a suggestion where this should be (I have no clue how >>>> the input system works or is structured - we just know how to extend a >>>> driver that uses it)? >>>> >>>>> 2. Standardize on bindings. We already have of-touchscreen.c doing >>>>> rudimentary parsing, we shoudl look into extending it rather than >>>>> creating myriad of driver-specific bindings. >>>> >>>> Ok, looks reasonable. >>> >>> Documentation is in >>> >>> Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt >> >> I did look into it now. Unfortunately, it does not fit well into my view of how bindings >> should be. They should describe hardware (as we are told for many other kernel >> subsystems). >> >> Pixels and resolutions are IMHO related to the screen it is glued on - and that is >> quite independent. > > Well, I think pixels was the wrong word to be used there. It is meant to > be native units, as opposed to millimeters, inches, points, etc. ok. > >> >> So I don’t see how they do describe the different ways the touch screen can be >> wired to a tsc2007 controller. >> >> Please can you add minimum and maximum properties for us? >> >> Then, inverted-x and inverted-y is redundant because it is the same as having >> an expected higher value from the ADC for the minimum coordinate and a lower >> for the maximum. > > I'd rather not add minimum and maximum, but add the touchscreen-start-x and > touchscreen-start-y instead so that we limit the number of obsolete > properties. ok, that should not be too difficult to add. So we will modify our driver to use the new functions and align omap3-gta04.dtsi accordingly. BR, Nikolaus From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dr. H. Nikolaus Schaller" Subject: Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation Date: Thu, 15 Jan 2015 19:49:52 +0100 Message-ID: <0CD142CE-0BC3-4A86-AAFB-383805A81646@goldelico.com> References: <1412108254-19234-1-git-send-email-marek@goldelico.com> <1412108254-19234-2-git-send-email-marek@goldelico.com> <20150115005938.GB9134@dtor-ws> <0F9A17C1-9B01-4EE9-BE98-266B8FC02B84@goldelico.com> <20150115143855.GD512@earth.universe> <8B08216C-13DD-40D8-9BA9-060F1C18A018@goldelico.com> <20150115181637.GE33214@dtor-ws> Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150115181637.GE33214@dtor-ws> Sender: linux-input-owner@vger.kernel.org To: Dmitry Torokhov Cc: Sebastian Reichel , Belisko Marek , Rob Herring , Pawel Moll , Mark Rutland , "ijc+devicetree@hellion.org.uk" , Kumar Gala , Benoit Cousson , Tony Lindgren , Russell King - ARM Linux , "devicetree@vger.kernel.org" , LKML , "linux-omap@vger.kernel.org" , linux-arm-kernel , linux-input@vger.kernel.org, Marek Belisko , Jonathan Richardson , Scott Branden , Yoichi Yuasa , Maxime Ripard , List List-Id: devicetree@vger.kernel.org Am 15.01.2015 um 19:16 schrieb Dmitry Torokhov : > On Thu, Jan 15, 2015 at 05:14:38PM +0100, Dr. H. Nikolaus Schaller wr= ote: >>=20 >> Am 15.01.2015 um 15:38 schrieb Sebastian Reichel : >>=20 >>> Hi, >>>=20 >>> On Thu, Jan 15, 2015 at 08:36:44AM +0100, Dr. H. Nikolaus Schaller = wrote: >>>>> 1. Perform conversion in input core rather than individual driver= s. I >>>>> think we should allocate a new bitmaps for some transformations a= nd have >>>>> the code do X/Y flip/clip of the coordinates. >>>>=20 >>>> Do you have a suggestion where this should be (I have no clue how >>>> the input system works or is structured - we just know how to exte= nd a >>>> driver that uses it)? >>>>=20 >>>>> 2. Standardize on bindings. We already have of-touchscreen.c doin= g >>>>> rudimentary parsing, we shoudl look into extending it rather than >>>>> creating myriad of driver-specific bindings. >>>>=20 >>>> Ok, looks reasonable. >>>=20 >>> Documentation is in=20 >>>=20 >>> Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt >>=20 >> I did look into it now. Unfortunately, it does not fit well into my = view of how bindings >> should be. They should describe hardware (as we are told for many ot= her kernel >> subsystems). >>=20 >> Pixels and resolutions are IMHO related to the screen it is glued on= - and that is >> quite independent. >=20 > Well, I think pixels was the wrong word to be used there. It is meant= to > be native units, as opposed to millimeters, inches, points, etc. ok. >=20 >>=20 >> So I don=92t see how they do describe the different ways the touch s= creen can be >> wired to a tsc2007 controller. >>=20 >> Please can you add minimum and maximum properties for us? >>=20 >> Then, inverted-x and inverted-y is redundant because it is the same = as having >> an expected higher value from the ADC for the minimum coordinate and= a lower >> for the maximum. >=20 > I'd rather not add minimum and maximum, but add the touchscreen-start= -x and > touchscreen-start-y instead so that we limit the number of obsolete > properties. ok, that should not be too difficult to add. So we will modify our driver to use the new functions and align omap3-g= ta04.dtsi accordingly. BR, Nikolaus -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: hns@goldelico.com (Dr. H. Nikolaus Schaller) Date: Thu, 15 Jan 2015 19:49:52 +0100 Subject: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation In-Reply-To: <20150115181637.GE33214@dtor-ws> References: <1412108254-19234-1-git-send-email-marek@goldelico.com> <1412108254-19234-2-git-send-email-marek@goldelico.com> <20150115005938.GB9134@dtor-ws> <0F9A17C1-9B01-4EE9-BE98-266B8FC02B84@goldelico.com> <20150115143855.GD512@earth.universe> <8B08216C-13DD-40D8-9BA9-060F1C18A018@goldelico.com> <20150115181637.GE33214@dtor-ws> Message-ID: <0CD142CE-0BC3-4A86-AAFB-383805A81646@goldelico.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am 15.01.2015 um 19:16 schrieb Dmitry Torokhov : > On Thu, Jan 15, 2015 at 05:14:38PM +0100, Dr. H. Nikolaus Schaller wrote: >> >> Am 15.01.2015 um 15:38 schrieb Sebastian Reichel : >> >>> Hi, >>> >>> On Thu, Jan 15, 2015 at 08:36:44AM +0100, Dr. H. Nikolaus Schaller wrote: >>>>> 1. Perform conversion in input core rather than individual drivers. I >>>>> think we should allocate a new bitmaps for some transformations and have >>>>> the code do X/Y flip/clip of the coordinates. >>>> >>>> Do you have a suggestion where this should be (I have no clue how >>>> the input system works or is structured - we just know how to extend a >>>> driver that uses it)? >>>> >>>>> 2. Standardize on bindings. We already have of-touchscreen.c doing >>>>> rudimentary parsing, we shoudl look into extending it rather than >>>>> creating myriad of driver-specific bindings. >>>> >>>> Ok, looks reasonable. >>> >>> Documentation is in >>> >>> Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt >> >> I did look into it now. Unfortunately, it does not fit well into my view of how bindings >> should be. They should describe hardware (as we are told for many other kernel >> subsystems). >> >> Pixels and resolutions are IMHO related to the screen it is glued on - and that is >> quite independent. > > Well, I think pixels was the wrong word to be used there. It is meant to > be native units, as opposed to millimeters, inches, points, etc. ok. > >> >> So I don?t see how they do describe the different ways the touch screen can be >> wired to a tsc2007 controller. >> >> Please can you add minimum and maximum properties for us? >> >> Then, inverted-x and inverted-y is redundant because it is the same as having >> an expected higher value from the ADC for the minimum coordinate and a lower >> for the maximum. > > I'd rather not add minimum and maximum, but add the touchscreen-start-x and > touchscreen-start-y instead so that we limit the number of obsolete > properties. ok, that should not be too difficult to add. So we will modify our driver to use the new functions and align omap3-gta04.dtsi accordingly. BR, Nikolaus