From mboxrd@z Thu Jan 1 00:00:00 1970 From: H Hartley Sweeten Subject: RE: [PATCH] EDB93xx: Add support for CS4271 CODEC on EDB93xx boards Date: Wed, 2 Feb 2011 11:21:40 -0600 Message-ID: <0D753D10438DA54287A00B027084269764CEFD4693@AUSP01VMBX24.collaborationhost.net> References: <1296603653.1504.9.camel@r60e> <0D753D10438DA54287A00B027084269764CEF59B2B@AUSP01VMBX24.collaborationhost.net> <1296643688.1504.23.camel@r60e> <20110202104943.GN12743@opensource.wolfsonmicro.com> <1296645167.1504.31.camel@r60e> <20110202125327.GO12743@opensource.wolfsonmicro.com> <1296653211.1504.40.camel@r60e> <0D753D10438DA54287A00B027084269764CEFD45C8@AUSP01VMBX24.collaborationhost.net> <20110202165959.GT12743@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110202165959.GT12743@opensource.wolfsonmicro.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mark Brown Cc: Dimitris Papastamos , "alsa-devel@alsa-project.org" , Alexander Sverdlin , "linux-arm-kernel@lists.infradead.org" , Lennert Buytenhek , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Wednesday, February 02, 2011 10:00 AM, Mark Brown wrote: > On Wed, Feb 02, 2011 at 10:53:15AM -0600, H Hartley Sweeten wrote: >> I don't have any problem with leaving the reset management in the codec. >> The enable (chip-select) should be handled in the platform code. But, >> gpio_disable should be removed from struct cs4271_platform_data to avoid >> any confusion. > > Is that really a chip select or is it a power control? >>From the datasheet: Pin Name # Pin Description -------- -- ---------------------------------------------------------- AD0/nCS 13 Address Bit 0 (I2S)/Control Port Chip Select (SPI) (Input) - AD0 is a chip address pin in I2C mode; nCS is the chip signal select for SPI format. The other pin in question: Pin Name # Pin Description -------- -- ---------------------------------------------------------- nRST 14 Reset (Input) - The device enters a low power mode when this pin is driven low. Regards, Hartley From mboxrd@z Thu Jan 1 00:00:00 1970 From: hartleys@visionengravers.com (H Hartley Sweeten) Date: Wed, 2 Feb 2011 11:21:40 -0600 Subject: [PATCH] EDB93xx: Add support for CS4271 CODEC on EDB93xx boards In-Reply-To: <20110202165959.GT12743@opensource.wolfsonmicro.com> References: <1296603653.1504.9.camel@r60e> <0D753D10438DA54287A00B027084269764CEF59B2B@AUSP01VMBX24.collaborationhost.net> <1296643688.1504.23.camel@r60e> <20110202104943.GN12743@opensource.wolfsonmicro.com> <1296645167.1504.31.camel@r60e> <20110202125327.GO12743@opensource.wolfsonmicro.com> <1296653211.1504.40.camel@r60e> <0D753D10438DA54287A00B027084269764CEFD45C8@AUSP01VMBX24.collaborationhost.net> <20110202165959.GT12743@opensource.wolfsonmicro.com> Message-ID: <0D753D10438DA54287A00B027084269764CEFD4693@AUSP01VMBX24.collaborationhost.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday, February 02, 2011 10:00 AM, Mark Brown wrote: > On Wed, Feb 02, 2011 at 10:53:15AM -0600, H Hartley Sweeten wrote: >> I don't have any problem with leaving the reset management in the codec. >> The enable (chip-select) should be handled in the platform code. But, >> gpio_disable should be removed from struct cs4271_platform_data to avoid >> any confusion. > > Is that really a chip select or is it a power control?