From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758307Ab1EZSsT (ORCPT ); Thu, 26 May 2011 14:48:19 -0400 Received: from mail131.messagelabs.com ([216.82.242.99]:49351 "EHLO mail131.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755482Ab1EZSsS convert rfc822-to-8bit (ORCPT ); Thu, 26 May 2011 14:48:18 -0400 X-VirusChecked: Checked X-Env-Sender: hartleys@visionengravers.com X-Msg-Ref: server-7.tower-131.messagelabs.com!1306435676!25771982!32 X-StarScan-Version: 6.2.17; banners=-,-,- X-Originating-IP: [216.166.12.69] From: H Hartley Sweeten To: Mika Westerberg , Linus Walleij CC: "linux-arm-kernel@lists.infradead.org" , Vinod Koul , "linux-kernel@vger.kernel.org" , "ryan@bluewatersys.com" , Dan Williams , Grant Likely , spi mailing list Date: Thu, 26 May 2011 13:48:12 -0500 Subject: RE: [PATCH 1/5] dmaengine: add ep93xx DMA support Thread-Topic: [PATCH 1/5] dmaengine: add ep93xx DMA support Thread-Index: Acwb1FWbkgwYzaFORuSCd5huHhXeagAALG/g Message-ID: <0D753D10438DA54287A00B027084269764D3319EC4@AUSP01VMBX24.collaborationhost.net> References: <20110525195413.GC2996@acer> <20110526043344.GA2749@acer> <20110526183800.GE2957@acer> In-Reply-To: <20110526183800.GE2957@acer> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, May 26, 2011 11:38 AM, Mika Westerberg wrote: > On Thu, May 26, 2011 at 09:15:25AM +0200, Linus Walleij wrote: >> On Thu, May 26, 2011 at 6:33 AM, Mika Westerberg wrote: >> >>> Do you think that we can go forward with this patch series if I drop the last >>> patch (spi/ep93xx: add DMA support)? This way we will have dmaengine >>> implementation in place, whatever SPI driver we choose to use with ep93xx. >> >> Yes and you don't have to drop any DMA support for the existing driver >> for me alone, now that it's in the tree it should be maintained. I only >> wanted to raise the issue of code duplication, not block any patches. > > Ok, so I'll keep the last patch for now. > > BTW: if we get amba-pl022 driver to work with ep93xx, do you have any ideas > how to proceed from there? I mean, should we convert existing users to use > that driver instead and finally remove the ep93xx_spi driver? I think the biggest hurdle with using the amba-pl022 driver is that the ep93xx spi peripheral does not have the registers with the pid and cid id's. Without those I don't think the amba bus driver will be able to match the device to the driver. Regards, Hartley From mboxrd@z Thu Jan 1 00:00:00 1970 From: H Hartley Sweeten Subject: RE: [PATCH 1/5] dmaengine: add ep93xx DMA support Date: Thu, 26 May 2011 13:48:12 -0500 Message-ID: <0D753D10438DA54287A00B027084269764D3319EC4@AUSP01VMBX24.collaborationhost.net> References: <20110525195413.GC2996@acer> <20110526043344.GA2749@acer> <20110526183800.GE2957@acer> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "linux-arm-kernel@lists.infradead.org" , Vinod Koul , "linux-kernel@vger.kernel.org" , "ryan@bluewatersys.com" , Dan Williams , Grant Likely , spi mailing list To: Mika Westerberg , Linus Walleij Return-path: In-Reply-To: <20110526183800.GE2957@acer> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Thursday, May 26, 2011 11:38 AM, Mika Westerberg wrote: > On Thu, May 26, 2011 at 09:15:25AM +0200, Linus Walleij wrote: >> On Thu, May 26, 2011 at 6:33 AM, Mika Westerberg wrote: >> >>> Do you think that we can go forward with this patch series if I drop the last >>> patch (spi/ep93xx: add DMA support)? This way we will have dmaengine >>> implementation in place, whatever SPI driver we choose to use with ep93xx. >> >> Yes and you don't have to drop any DMA support for the existing driver >> for me alone, now that it's in the tree it should be maintained. I only >> wanted to raise the issue of code duplication, not block any patches. > > Ok, so I'll keep the last patch for now. > > BTW: if we get amba-pl022 driver to work with ep93xx, do you have any ideas > how to proceed from there? I mean, should we convert existing users to use > that driver instead and finally remove the ep93xx_spi driver? I think the biggest hurdle with using the amba-pl022 driver is that the ep93xx spi peripheral does not have the registers with the pid and cid id's. Without those I don't think the amba bus driver will be able to match the device to the driver. Regards, Hartley From mboxrd@z Thu Jan 1 00:00:00 1970 From: hartleys@visionengravers.com (H Hartley Sweeten) Date: Thu, 26 May 2011 13:48:12 -0500 Subject: [PATCH 1/5] dmaengine: add ep93xx DMA support In-Reply-To: <20110526183800.GE2957@acer> References: <20110525195413.GC2996@acer> <20110526043344.GA2749@acer> <20110526183800.GE2957@acer> Message-ID: <0D753D10438DA54287A00B027084269764D3319EC4@AUSP01VMBX24.collaborationhost.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday, May 26, 2011 11:38 AM, Mika Westerberg wrote: > On Thu, May 26, 2011 at 09:15:25AM +0200, Linus Walleij wrote: >> On Thu, May 26, 2011 at 6:33 AM, Mika Westerberg wrote: >> >>> Do you think that we can go forward with this patch series if I drop the last >>> patch (spi/ep93xx: add DMA support)? This way we will have dmaengine >>> implementation in place, whatever SPI driver we choose to use with ep93xx. >> >> Yes and you don't have to drop any DMA support for the existing driver >> for me alone, now that it's in the tree it should be maintained. I only >> wanted to raise the issue of code duplication, not block any patches. > > Ok, so I'll keep the last patch for now. > > BTW: if we get amba-pl022 driver to work with ep93xx, do you have any ideas > how to proceed from there? I mean, should we convert existing users to use > that driver instead and finally remove the ep93xx_spi driver? I think the biggest hurdle with using the amba-pl022 driver is that the ep93xx spi peripheral does not have the registers with the pid and cid id's. Without those I don't think the amba bus driver will be able to match the device to the driver. Regards, Hartley