From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zxq_yx_007@163.com>) id 1ayJum-0005Fe-2N
	for qemu-devel@nongnu.org; Thu, 05 May 2016 10:06:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zxq_yx_007@163.com>) id 1ayJua-00069i-0B
	for qemu-devel@nongnu.org; Thu, 05 May 2016 10:05:58 -0400
Received: from m12-11.163.com ([220.181.12.11]:55089)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zxq_yx_007@163.com>) id 1ayJuY-000631-1T
	for qemu-devel@nongnu.org; Thu, 05 May 2016 10:05:51 -0400
Content-Type: text/plain;
	charset=gb2312
Mime-Version: 1.0 (1.0)
From: xiaoqiang zhao <zxq_yx_007@163.com>
In-Reply-To: <CAFEAcA-BDp9ybo+Z2xUG_cqWo_jeRaq863Z4PJnNVPEpWHv8nA@mail.gmail.com>
Date: Thu, 5 May 2016 22:04:58 +0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <0E1D7CCF-C61A-45ED-938C-1F85FA6DD353@163.com>
References: <1459237645-17227-1-git-send-email-zxq_yx_007@163.com>
	<1e5877c8.11366.154807f2624.Coremail.zxq_yx_007@163.com>
	<CAFEAcA-BDp9ybo+Z2xUG_cqWo_jeRaq863Z4PJnNVPEpWHv8nA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/6] QOM'ify hw/char devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Michael Walle <michael@walle.cc>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>


> =D4=DA 2016=C4=EA5=D4=C25=C8=D5=A3=AC20:51=A3=ACPeter Maydell <peter.mayde=
ll@linaro.org> =D0=B4=B5=C0=A3=BA
>=20
>> On 5 May 2016 at 11:38, =D5=D4=D0=A1=C7=BF <zxq_yx_007@163.com> wrote:
>> At 2016-03-29 15:47:19, "xiaoqiang zhao" <zxq_yx_007@163.com> wrote:
>>> This patch set trys to QOM'ify hw/char files, see commit messages
>>> for more details
>>>=20
>>> Changes in v2:
>>> * rename TYPE_SCLP_LM_CONSOLE to TYPE_SCLPLM_CONSOLE which is suggested b=
y
>>> Cornelia Huck <cornelia.huck@de.ibm.com>
>>> * rebase on the current master
>>>=20
>>> xiaoqiang zhao (6):
>>> hw/char: QOM'ify escc.c
>>> hw/char: QOM'ify etraxfs_ser.c
>>> hw/char: QOM'ify lm32_juart.c
>>> hw/char: QOM'ify lm32_uart.c
>>> hw/char: QOM'ify sclpconsole-lm.c
>>> hw/char: QOM'ify sclpconsole.c
>>>=20
>>> hw/char/escc.c           | 12 +++++-------
>>> hw/char/etraxfs_ser.c    | 11 +++++------
>>> hw/char/lm32_juart.c     |  9 +++------
>>> hw/char/lm32_uart.c      | 12 +++++-------
>>> hw/char/sclpconsole-lm.c | 14 +++++++++-----
>>> hw/char/sclpconsole.c    | 12 ++++++++----
>>> 6 files changed, 35 insertions(+), 35 deletions(-)
>>>=20
>>> --
>>> 2.1.4
>>=20
>> ping ???
>=20
> I think you will have better luck if you rearrange all these
> QOM patches so that you provide them as one series per board
> or per target architecture, not one per type of device.
> There is no single person with responsibility for "all of
> hw/char" so structuring your cleanup patchsets like this will
> tend to result in the people who might care about the devices
> not looking at them. (Also you can concentrate on the devices
> which are actively maintained, like ARM ones, x86 ones, MIPS
> and SPARC ones, rather than the oddballs semi-orphaned ones
> like lm32, CRIS, etc.)
>=20
> thanks
> -- PMM

Thanks peter, Sounds reasonable!=